Skip to contentSkip to conversation

tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info

PATCH In review Peter Hurley 2 participants 4 messages Nov 16, 2015 – Dec 3, 2015 3 messages not in the archive Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tty_ioctl.4: Remove TIOCTTYGSTRUCT ioctl info

Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by:

commit b3506a09d15dc5aee6d4bb88d759b157016e1864
Author: Andries E. Brouwer <[email protected]>
Date: Tue Apr 1 04:42:46 2003 -0800

[PATCH] kill TIOCTTYGSTRUCT

Only used for (dubious) debugging purposes, and exposes internal kernel state.

[The git SHA is from Thomas Gleixner's history tree at
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git]

---
 man4/tty_ioctl.4 | 8 --------
 1 file changed, 8 deletions(-)
man4/tty_ioctl.4 +0 -8
index 53645d8..c3bee35 100644
@@ -471,14 +471,6 @@ For the
 .B TIOCLINUX
 ioctl, see
 .BR console_ioctl (4).
-.SS Kernel debugging
-.B "#include <linux/tty.h>"
-.TP
-.BI "TIOCTTYGSTRUCT	struct tty_struct *" argp
-Get the
-.I tty_struct
-corresponding to
-.IR fd .
 .\"
 .\" .SS Serial info
 .\" .BR "#include <linux/serial.h>"
Signature · 6 lines
2.6.3

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 1447709969-26477-1-git-send-email-peter-WaGBZJeGNqdsbIuE7sb01tBPR1lH4CV8@public.gmane.org

#2 lore raw

Hello Peter,

Quoted 6 lines · Peter Hurley

Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by:

commit b3506a09d15dc5aee6d4bb88d759b157016e1864
Author: Andries E. Brouwer <[email protected]>
Date: Tue Apr 1 04:42:46 2003 -0800

Quoted 7 lines

[PATCH] kill TIOCTTYGSTRUCT

Only used for (dubious) debugging purposes, and exposes internal kernel state.

[The git SHA is from Thomas Gleixner's history tree at
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git]

Thanks for the report/patch. Man-pages tends to take a conservative approach about discarding stuff though, since people reading man pages also need to know about past behavior. Therefore, I instead just added a note that this ioctl() disappeared in Linux 2.5.67:
"This command was removed in Linux 2.5.67."

Cheers,

Michael

Quoted 25 lines
---
 man4/tty_ioctl.4 | 8 --------
 1 file changed, 8 deletions(-)
man4/tty_ioctl.4 +0 -8
index 53645d8..c3bee35 100644
@@ -471,14 +471,6 @@ For the
 .B TIOCLINUX
 ioctl, see
 .BR console_ioctl (4).
-.SS Kernel debugging
-.B "#include <linux/tty.h>"
-.TP
-.BI "TIOCTTYGSTRUCT	struct tty_struct *" argp
-Get the
-.I tty_struct
-corresponding to
-.IR fd .
 .\"
 .\" .SS Serial info
 .\" .BR "#include <linux/serial.h>"
Signature · 7 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#4 lore raw
Quoted 14 lines · Michael Kerrisk (man-pages)

Hello Peter,

Quoted 11 lines · Peter Hurley

Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by:

commit b3506a09d15dc5aee6d4bb88d759b157016e1864
Author: Andries E. Brouwer <[email protected]>
Date: Tue Apr 1 04:42:46 2003 -0800

[PATCH] kill TIOCTTYGSTRUCT

Only used for (dubious) debugging purposes, and exposes internal kernel state.

Quoted 8 lines
Quoted 2 lines

[The git SHA is from Thomas Gleixner's history tree at
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git]

Thanks for the report/patch. Man-pages tends to take a conservative approach about discarding stuff though, since people reading man pages also need to know about past behavior. Therefore, I instead just added a note that this ioctl() disappeared in Linux 2.5.67:
"This command was removed in Linux 2.5.67."

Ok, thanks for the clarification.

I saw the commented-out TIOCGSERIAL/TIOCSSERIAL (which is _never_ going away) and assumed the policy was more best-practices than complete.

Regards,
Peter Hurley

Quoted 17 lines
Quoted 17 lines
---
 man4/tty_ioctl.4 | 8 --------
 1 file changed, 8 deletions(-)
man4/tty_ioctl.4 +0 -4
index 53645d8..c3bee35 100644
@@ -471,14 +471,6 @@ For the
 .B TIOCLINUX
 ioctl, see
 .BR console_ioctl (4).
-.SS Kernel debugging
-.B "#include <linux/tty.h>"
-.TP
-.BI "TIOCTTYGSTRUCT	struct tty_struct *" argp
Quoted 10 lines

man4/tty_ioctl.4 For the · line 476

Quoted 8 lines
man4/tty_ioctl.4 +0 -4
-Get the
-.I tty_struct
-corresponding to
-.IR fd .
 .\"
 .\" .SS Serial info
 .\" .BR "#include <linux/serial.h>"

--
To unsubscribe from this list: send the line "unsubscribe linux-man" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): [email protected]

#6 lore raw
Quoted 24 lines · Peter Hurley
Quoted 14 lines · Michael Kerrisk (man-pages)

Hello Peter,

Quoted 11 lines · Peter Hurley

Thankfully, TIOCTTYGSTRUCT was removed in v2.5.67 by:

commit b3506a09d15dc5aee6d4bb88d759b157016e1864
Author: Andries E. Brouwer <[email protected]>
Date: Tue Apr 1 04:42:46 2003 -0800

[PATCH] kill TIOCTTYGSTRUCT

Only used for (dubious) debugging purposes, and exposes internal kernel state.

Quoted 8 lines
Quoted 2 lines

[The git SHA is from Thomas Gleixner's history tree at
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git]

Thanks for the report/patch. Man-pages tends to take a conservative approach about discarding stuff though, since people reading man pages also need to know about past behavior. Therefore, I instead just added a note that this ioctl() disappeared in Linux 2.5.67:
"This command was removed in Linux 2.5.67."

Quoted 5 lines

Ok, thanks for the clarification.

I saw the commented-out TIOCGSERIAL/TIOCSSERIAL (which is _never_ going away) and assumed the policy was more best-practices than complete.

Yes, things have not always been consistent, and TIOCTTYGSTRUCT is borderline. The change happened long enough ago now that I considered just applying you patch.

Cheers

Michael

Signature · 7 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html