ftrace/x86: Add comment on static function tracing
PATCH 1/1 ftrace/x86: Add comment on static function tracing
There was a confusion between update_ftrace_function() and static function tracing trampoline regarding 3rd parameter (ftrace_ops). Add a comment for clarification.
Suggested-by Steven Rostedt <[email protected]>
Signed-off-by Namhyung Kim <[email protected]>
--- arch/x86/kernel/mcount_64.S | 6 ++++++ 1 file changed, 6 insertions(+)
arch/x86/kernel/mcount_64.S +6 -0
@@ -278,6 +278,12 @@ GLOBAL(ftrace_stub) /* save_mcount_regs fills in first two parameters */ save_mcount_regs + /* + * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not + * set (see include/asm/ftrace.h and include/linux/ftrace.h). Only the + * ip and parent ip are used and the list function is called when + * function tracing is enabled. + */ call *ftrace_trace_function restore_mcount_regs
Signature · 1 line
2.6.2
Quoted 5 lines · On Tue, 17 Nov 2015 09:43:24 +0900 Namhyung Kim <[email protected]> wrote:
There was a confusion between
update_ftrace_function()and static function tracing trampoline regarding 3rd parameter (ftrace_ops). Add a comment for clarification.Suggested-by Steven Rostedt <[email protected]>
Acked-by Steven Rostedt <[email protected]>
-- Steve
Quoted 22 lines
Signed-off-by Namhyung Kim <[email protected]>--- arch/x86/kernel/mcount_64.S | 6 ++++++ 1 file changed, 6 insertions(+)arch/x86/kernel/mcount_64.S +6
-0@@ -278,6 +278,12 @@ GLOBAL(ftrace_stub) /* save_mcount_regs fills in first two parameters */ save_mcount_regs + /* + * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not + * set (see include/asm/ftrace.h and include/linux/ftrace.h). Only the + * ip and parent ip are used and the list function is called when + * function tracing is enabled. + */ call *ftrace_trace_function restore_mcount_regs
tip-bot for Namhyung Kim
merge bot[tip:x86/urgent] x86/ftrace: Add comment on static function tracing
In reply to Namhyung Kimx86/ftrace: Add comment on static function tracing
Commit-ID: 112677d683d31ebd6a8e8b02e0620ae512354b2d Gitweb: http://git.kernel.org/tip/112677d683d31ebd6a8e8b02e0620ae512354b2d Author: Namhyung Kim <[email protected]> AuthorDate: Tue, 17 Nov 2015 09:43:24 +0900 Committer: Thomas Gleixner <[email protected]> CommitDate: Thu, 19 Nov 2015 11:07:49 +0100
x86/ftrace: Add comment on static function tracing
There was a confusion between update_ftrace_function() and static function tracing trampoline regarding 3rd parameter (ftrace_ops). Add a comment for clarification.
Suggested-by Steven Rostedt <[email protected]>
Signed-off-by Namhyung Kim <[email protected]>
Cc H. Peter Anvin <[email protected]>
Cc Steven Rostedt <[email protected]>
Signed-off-by Thomas Gleixner <[email protected]>
--- arch/x86/kernel/mcount_64.S | 6 ++++++ 1 file changed, 6 insertions(+)
arch/x86/kernel/mcount_64.S +6 -0
@@ -278,6 +278,12 @@ trace: /* save_mcount_regs fills in first two parameters */ save_mcount_regs + /* + * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not + * set (see include/asm/ftrace.h and include/linux/ftrace.h). Only the + * ip and parent ip are used and the list function is called when + * function tracing is enabled. + */ call *ftrace_trace_function restore_mcount_regs