Skip to contentSkip to conversation

net: encx24j600: quiet logging noise on open

PATCH In review [email protected] 2 participants 2 messages Nov 17, 2015 – Nov 18, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 net: encx24j600: quiet logging noise on open

From: Jon Ringle <[email protected]>

When encx24j600 is open and closed many times due to userspace polling the interface, the log gets noise with this log message. Change logging level to debug

---
 drivers/net/ethernet/microchip/encx24j600.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/ethernet/microchip/encx24j600.c +2 -2
index bf08ce2..a6763c3 100644
@@ -613,8 +613,8 @@ static int encx24j600_hw_init(struct encx24j600_priv *priv)
 		goto err_out;
 	}
 
-	netif_info(priv, drv, dev, "Silicon rev ID: 0x%02x\n",
-		   (eidled & REVID_MASK) >> REVID_SHIFT);
+	netif_dbg(priv, drv, dev, "Silicon rev ID: 0x%02x\n",
+		  (eidled & REVID_MASK) >> REVID_SHIFT);
 
 	/* PHY Leds: link status,
 	 * LEDA: Link State + collision events
Signature · 1 line
2.4.1
maintainer
#1 lore raw

From: [email protected]
Date: Tue, 17 Nov 2015 16:42:31 -0500

Quoted 7 lines

From: Jon Ringle <[email protected]>

When encx24j600 is open and closed many times due to userspace polling the interface, the log gets noise with this log message. Change logging level to debug

This should be moved into the probe method instead, as that's where outputting something like that belongs.