Patch "virtio-net: drop NETIF_F_FRAGLIST" has been added to the 4.1-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
virtio-net: drop NETIF_F_FRAGLIST
to the 4.1-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
virtio-net-drop-netif_f_fraglist.patch
and it can be found in the queue-4.1 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Tue Nov 17 14:35:45 PST 2015
From: Jason Wang <[email protected]>
Date: Wed, 5 Aug 2015 10:34:04 +0800
Subject: virtio-net: drop NETIF_F_FRAGLIST
From: Jason Wang <[email protected]>
[ Upstream commit 48900cb6af4282fa0fb6ff4d72a81aa3dadb5c39 ]
virtio declares support for NETIF_F_FRAGLIST, but assumes that there are at most MAX_SKB_FRAGS + 2 fragments which isn't always true with a fraglist.
A longer fraglist in the skb will make the call to skb_to_sgvec overflow the sg array, leading to memory corruption.
Drop NETIF_F_FRAGLIST so we only get what we can handle.
--- drivers/net/virtio_net.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/net/virtio_net.c +2 -2
@@ -1756,9 +1756,9 @@ static int virtnet_probe(struct virtio_d/* Do we support "hardware" checksums? */ if (virtio_has_feature (vdev,VIRTIO_NET_F_CSUM )) {/* This opens up the world of extra features. */ - dev->hw_features |=NETIF_F_HW_CSUM |NETIF_F_SG |NETIF_F_FRAGLIST ; + dev->hw_features |=NETIF_F_HW_CSUM |NETIF_F_SG ;if (csum) - dev->features |=NETIF_F_HW_CSUM |NETIF_F_SG |NETIF_F_FRAGLIST ; + dev->features |=NETIF_F_HW_CSUM |NETIF_F_SG ;if (virtio_has_feature (vdev,VIRTIO_NET_F_GSO )) { dev->hw_features |=NETIF_F_TSO |NETIF_F_UFO
Patches currently in stable-queue which might be from [email protected] are
queue-4.1/virtio-net-drop-netif_f_fraglist.patch queue-4.1/macvtap-unbreak-receiving-of-gro-skb-with-frag-list.patch