Skip to contentSkip to conversation

Patch "net: fec: Remove unneeded use of IS_ERR_VALUE() macro" has been added to the 4.2-stable tree

PATCH [email protected] 1 participant 1 message Nov 17, 2015

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

net: fec: Remove unneeded use of IS_ERR_VALUE() macro

to the 4.2-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
net-fec-remove-unneeded-use-of-is_err_value-macro.patch
and it can be found in the queue-4.2 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Tue Nov 17 14:34:38 PST 2015

From: Fabio Estevam <[email protected]>
Date: Wed, 12 Aug 2015 12:10:23 -0300
Subject: net: fec: Remove unneeded use of IS_ERR_VALUE() macro

From: Fabio Estevam <[email protected]>

[ Upstream commit b0c6ce24911fcb64715de9569f0f7b4f54d1d045 ]

There is no need to use the IS_ERR_VALUE() macro for checking the return value from pm_runtime_* functions.

Just do a simple negative test instead.

The semantic patch that makes this change is available in scripts/coccinelle/api/pm_runtime.cocci.

---
 drivers/net/ethernet/freescale/fec_main.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/net/ethernet/freescale/fec_main.c +3 -3
@@ -1775,7 +1775,7 @@ static int fec_enet_mdio_read(struct mii
 	int ret = 0;
 
 	ret = pm_runtime_get_sync(dev);
-	if (IS_ERR_VALUE(ret))
+	if (ret < 0)
 		return ret;
 
 	fep->mii_timeout = 0;
@@ -1814,7 +1814,7 @@ static int fec_enet_mdio_write(struct mi
 	int ret = 0;
 
 	ret = pm_runtime_get_sync(dev);
-	if (IS_ERR_VALUE(ret))
+	if (ret < 0)
 		return ret;
 
 	fep->mii_timeout = 0;
@@ -2866,7 +2866,7 @@ fec_enet_open(struct net_device *ndev)
 	int ret;
 
 	ret = pm_runtime_get_sync(&fep->pdev->dev);
-	if (IS_ERR_VALUE(ret))
+	if (ret < 0)
 		return ret;
 
 	pinctrl_pm_select_default_state(&fep->pdev->dev);

Patches currently in stable-queue which might be from [email protected] are

queue-4.2/net-fec-remove-unneeded-use-of-is_err_value-macro.patch