ethernet/atheros/alx: add Killer E2400 device ID
Subsystems (3)
PATCH 1/1 ethernet/atheros/alx: add Killer E2400 device ID
From: Ben Pope <[email protected]>
This patch adds the PCI device ID (0xe0a1) and alx_pci_tbl entry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver.
This patch was originally authored by Ben Pope, but it got held up by issues in the commit message, so I'm resubmitting it on his behalf.
I've extensively used a kernel with this patch on a System76 serw9 laptop and am quite confident it works well (at least on the hardware I have available for testing).
Note that as a favor to System76, Ubuntu has been carrying this as a sauce patch in their 4.2 based Wily kernel, which presumably has given it real-world testing on other E2400 equipped hardware (I don't know of any Ubuntu kernel bugs filed about it):
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
--- drivers/net/ethernet/atheros/alx/main.c | 2 ++ drivers/net/ethernet/atheros/alx/reg.h | 1 + 2 files changed, 3 insertions(+)
drivers/net/ethernet/atheros/alx/main.c +2 -0
@@ -1534,6 +1534,8 @@ static const struct pci_device_id alx_pci_tbl[] = { .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2200), .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, + { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2400), + .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8162), .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8171) },
drivers/net/ethernet/atheros/alx/reg.h +1 -0
@@ -37,6 +37,7 @@#define ALX_DEV_ID_AR8161 0x1091#define ALX_DEV_ID_E2200 0xe091 +#define ALX_DEV_ID_E2400 0xe0a1#define ALX_DEV_ID_AR8162 0x1090#define ALX_DEV_ID_AR8171 0x10A1#define ALX_DEV_ID_AR8172 0x10A0
Signature · 1 line
2.5.0
Hello.
Quoted 13 lines · Jason Gerard DeRose
From: Ben Pope <[email protected]>
This patch adds the PCI device ID (
0xe0a1) andalx_pci_tblentry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver.This patch was originally authored by Ben Pope, but it got held up by issues in the commit message, so I'm resubmitting it on his behalf.
I've extensively used a kernel with this patch on a System76 serw9 laptop and am quite confident it works well (at least on the hardware I have available for testing).
Quoted 8 lines
Note that as a favor to System76, Ubuntu has been carrying this as a sauce patch in their 4.2 based Wily kernel, which presumably has given it real-world testing on other E2400 equipped hardware (I don't know of any Ubuntu kernel bugs filed about it):
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
Signed-off-by Jason Gerard DeRose <[email protected]>
No sign-off from Ben?
[...]
MBR, Sergei
Sergei,
Quoted 22 lines · Sergei Shtylyov
Hello.
Quoted 18 lines · Jason Gerard DeRose
From: Ben Pope <[email protected]>
This patch adds the PCI device ID (
0xe0a1) andalx_pci_tblentry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver.This patch was originally authored by Ben Pope, but it got held up by issues in the commit message, so I'm resubmitting it on his behalf.
I've extensively used a kernel with this patch on a System76 serw9 laptop and am quite confident it works well (at least on the hardware I have available for testing).
Note that as a favor to System76, Ubuntu has been carrying this as a sauce patch in their 4.2 based Wily kernel, which presumably has given it real-world testing on other E2400 equipped hardware (I don't know of any Ubuntu kernel bugs filed about it):
Quoted 5 lines
Quoted 3 lines
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
Signed-off-by Jason Gerard DeRose <[email protected]>No sign-off from Ben?
Apologies, this is my first time submitting a kernel patch :)
Should I use git send-email to send this again, this time with the sign-off from Ben? And if so, should I do so as a reply to this thread?
Thanks for you time!
Quoted 4 lines
[...]
MBR, Sergei
Quoted 20 lines · Jason Gerard DeRose
Quoted 20 lines
Quoted 20 lines
From: Ben Pope <[email protected]>
This patch adds the PCI device ID (
0xe0a1) andalx_pci_tblentry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver.This patch was originally authored by Ben Pope, but it got held up by issues in the commit message, so I'm resubmitting it on his behalf.
I've extensively used a kernel with this patch on a System76 serw9 laptop and am quite confident it works well (at least on the hardware I have available for testing).
Note that as a favor to System76, Ubuntu has been carrying this as a sauce patch in their 4.2 based Wily kernel, which presumably has given it real-world testing on other E2400 equipped hardware (I don't know of any Ubuntu kernel bugs filed about it):
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Jason Gerard DeRose <[email protected]>No sign-off from Ben?
Apologies, this is my first time submitting a kernel patch :)
Should I use git send-email to send this again,
I didn't notice if your mailer corrupted the patch but if it did 'git
send-email' should be used indeed.
Quoted 1 line
this time with the sign-off from Ben?
No need to resend if it wasn't corrupted. Just replying to this patch with
his sign-off should be enough -- patchwork should collect the tags from the follow-ups.
Quoted 1 line
And if so, should I do so as a reply to this thread?
No, not on this list. DaveM prefers the patch reposts to be done as the
fresh new postings.
Quoted 1 line
Thanks for you time!
Your, I guess? Not at all. :-)
MBR, Sergei
Quoted 25 lines · Sergei Shtylyov
Quoted 23 lines · Jason Gerard DeRose
Quoted 23 lines
Quoted 22 lines
From: Ben Pope <[email protected]>
This patch adds the PCI device ID (
0xe0a1) andalx_pci_tblentry for the
Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver.This patch was originally authored by Ben Pope, but it got held up by issues in the commit message, so I'm resubmitting it on his behalf.
I've extensively used a kernel with this patch on a System76 serw9 laptop and am quite confident it works well (at least on the hardware I have available for testing).
Note that as a favor to System76, Ubuntu has been carrying this as a sauce patch in their 4.2 based Wily kernel, which presumably has given it real-world testing on other E2400 equipped hardware (I don't know of any Ubuntu kernel bugs filed about it):
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
Signed-off-by Jason Gerard DeRose <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 1 line
No sign-off from Ben?
Apologies, this is my first time submitting a kernel patch :)
Should I use git send-email to send this again,
I didn't notice if your mailer corrupted the patch but if it did
'git send-email' should be used indeed.
I originally used git send-email, so the patch should not have been corrupted.
Quoted 5 lines
Quoted 1 line
this time with the sign-off from Ben?
No need to resend if it wasn't corrupted. Just replying to this
patch with his sign-off should be enough -- patchwork should collect the tags from the follow-ups.
Okay, thanks for the clarification!
Quoted 8 lines
Quoted 1 line
And if so, should I do so as a reply to this thread?
No, not on this list. DaveM prefers the patch reposts to be done as
the fresh new postings.Quoted 1 line
Thanks for you time!
Your, I guess? Not at all. :-)
Also thank you for enduring my typos ;)
Quoted 2 lines
MBR, Sergei
Quoted 44 lines · Jason Gerard DeRose
From: Ben Pope <[email protected]>
This patch adds the PCI device ID (
0xe0a1) andalx_pci_tblentry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver.This patch was originally authored by Ben Pope, but it got held up by issues in the commit message, so I'm resubmitting it on his behalf.
I've extensively used a kernel with this patch on a System76 serw9 laptop and am quite confident it works well (at least on the hardware I have available for testing).
Note that as a favor to System76, Ubuntu has been carrying this as a sauce patch in their 4.2 based Wily kernel, which presumably has given it real-world testing on other E2400 equipped hardware (I don't know of any Ubuntu kernel bugs filed about it):
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
Signed-off-by Jason Gerard DeRose <[email protected]>--- drivers/net/ethernet/atheros/alx/main.c | 2 ++ drivers/net/ethernet/atheros/alx/reg.h | 1 + 2 files changed, 3 insertions(+)drivers/net/ethernet/atheros/alx/main.c +2
-0@@ -1534,6 +1534,8 @@ static const struct pci_device_id alx_pci_tbl[] = { .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2200), .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, + { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_E2400), + .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8162), .driver_data = ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, { PCI_VDEVICE(ATTANSIC, ALX_DEV_ID_AR8171) },drivers/net/ethernet/atheros/alx/reg.h +0
-0
drivers/net/ethernet/atheros/alx/reg.h line 43
Quoted 7 lines
drivers/net/ethernet/atheros/alx/reg.h +1
-0@@ -37,6 +37,7 @@#define ALX_DEV_ID_AR8161 0x1091#define ALX_DEV_ID_E2200 0xe091 +#define ALX_DEV_ID_E2400 0xe0a1#define ALX_DEV_ID_AR8162 0x1090#define ALX_DEV_ID_AR8171 0x10A1#define ALX_DEV_ID_AR8172 0x10A0
From: Jason Gerard DeRose <[email protected]>
Date: Tue, 17 Nov 2015 18:21:07 -0700
Quoted 13 lines
From: Ben Pope <[email protected]>
This patch adds the PCI device ID (
0xe0a1) andalx_pci_tblentry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver.This patch was originally authored by Ben Pope, but it got held up by issues in the commit message, so I'm resubmitting it on his behalf.
I've extensively used a kernel with this patch on a System76 serw9 laptop and am quite confident it works well (at least on the hardware I have available for testing).
Quoted 8 lines
Note that as a favor to System76, Ubuntu has been carrying this as a sauce patch in their 4.2 based Wily kernel, which presumably has given it real-world testing on other E2400 equipped hardware (I don't know of any Ubuntu kernel bugs filed about it):
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
Signed-off-by Jason Gerard DeRose <[email protected]>
Applied.
Quoted 21 lines · David Miller
From: Jason Gerard DeRose <[email protected]>
Date: Tue, 17 Nov 2015 18:21:07 -0700Quoted 18 lines
From: Ben Pope <[email protected]>
This patch adds the PCI device ID (
0xe0a1) andalx_pci_tblentry for the Killer E2400 Ethernet controller, modeled after the Killer E2200 controller support (0xe091) already present in the alx driver.This patch was originally authored by Ben Pope, but it got held up by issues in the commit message, so I'm resubmitting it on his behalf.
I've extensively used a kernel with this patch on a System76 serw9 laptop and am quite confident it works well (at least on the hardware I have available for testing).
Note that as a favor to System76, Ubuntu has been carrying this as a sauce patch in their 4.2 based Wily kernel, which presumably has given it real-world testing on other E2400 equipped hardware (I don't know of any Ubuntu kernel bugs filed about it):
Quoted 5 lines
Quoted 3 lines
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1498633
Signed-off-by Jason Gerard DeRose <[email protected]>Applied.
Much thanks!