SKL intel_pstate update MSR values when changing governors
Subsystems (2)
PATCH v2 1/1 SKL intel_pstate update MSR values when changing governors
From: root <[email protected]>
When changing from powersave to performance governors Intel_pstate fails to update the MSR values that reflect the max_perf_pct to 100%. For instance in SKL reading rdmsr 0x774:
Governor MSR max_perf_pct
========= ======== ============
Powersave 80002808 100%
Powersave 80002008 80%
Performance 80002028 [error] 100%
Performance 80002828 [expected] 100%
The line label [error] shows the culprit. At this point the MSR should reflect the max_perf_pct that is 100%, that corresponds to MSR 80002828 as shown on the next line of the example. Which is the maximum performance for the Performance governor. Instead it holds back the MSR value previously set by the Powersave, in this case 80002028.
This patch allows the system to print the correct MSR value 80002828 that corresponds to the 100% max_perf_pct when changing from powersave to performance governors.
For more information on the MSR values for SKL please visit ISDM under Managing HWP.
--- drivers/cpufreq/intel_pstate.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/cpufreq/intel_pstate.c +2 -0
@@ -1242,6 +1242,8 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy) policy->max >= policy->cpuinfo.max_freq) {pr_debug ("intel_pstate: set performance\n" ); limits = &performance_limits; +if (hwp_active) +intel_pstate_hwp_set ();return 0 ; }
Signature · 1 line
1.9.1
Srinivas Pandruvada
maintainerQuoted 1 line · Alexandra Yates
From: root <[email protected]>
You need to fix the git config ...
The change itself is OK.
Thanks,
Srinivas
Quoted 44 lines
When changing from powersave to performance governors
Intel_pstatefails to update the MSR values that reflect themax_perf_pctto 100%. For instance in SKL reading rdmsr0x774:Governor MSR
max_perf_pct
========= ======== ============
Powersave 80002808 100%
Powersave 80002008 80%
Performance 80002028 [error] 100%
Performance 80002828 [expected] 100%The line label [error] shows the culprit. At this point the MSR should reflect the
max_perf_pctthat is 100%, that corresponds to MSR 80002828 as shown on the next line of the example. Which is the maximum performance for the Performance governor. Instead it holds back the MSR value previously set by the Powersave, in this case 80002028.This patch allows the system to print the correct MSR value 80002828 that corresponds to the 100%
max_perf_pctwhen changing from powersave to performance governors.For more information on the MSR values for SKL please visit ISDM under Managing HWP.
Signed-off-by root <[email protected]>--- drivers/cpufreq/intel_pstate.c | 2 ++ 1 file changed, 2 insertions(+)drivers/cpufreq/intel_pstate.c +2
-0@@ -1242,6 +1242,8 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy) policy->max >= policy->cpuinfo.max_freq) {pr_debug ("intel_pstate: set performance\n" ); limits = &performance_limits; +if (hwp_active) +intel_pstate_hwp_set ();return 0 ; }