Skip to contentSkip to conversation

Enable PCIe PHY support in Cygnus

PATCH Applied Ray Jui 4 participants 9 messages Nov 18, 2015 – Dec 1, 2015

Subsystems (2)
lore
Share & tools
lore

Ray Jui

author maintainer
#0 lore raw

PATCH 1/1 Enable PCIe PHY support in Cygnus

This patch enales PCIe PHY in device tree for Broadcom Cygnus based platforms

This patch is developed based on v4.4-rc1 and available here:
https://github.com/Broadcom/cygnus-linux/tree/cygnus-pcie-phy-dt-v1

Ray Jui (1):
ARM: dts: enable PCIe PHY support for Cygnus

 arch/arm/boot/dts/bcm-cygnus.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
Signature · 1 line
1.9.1
author maintainer
#1 lore raw

PATCH 1/1 ARM: dts: enable PCIe PHY support for Cygnus

Enable PCIe PHY for both PCIe root complexes on Cygnus

---
 arch/arm/boot/dts/bcm-cygnus.dtsi | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)
arch/arm/boot/dts/bcm-cygnus.dtsi +21 -0
index 2778533..5df5300 100644
@@ -91,6 +91,21 @@
 		#address-cells = <1>;
 		#size-cells = <1>;
 
+		pcie_phy: phy at 0301d0a0 {
+			compatible = "brcm,cygnus-pcie-phy";
+			reg = <0x0301d0a0 0x14>;
+
+			pcie0_phy: phy at 0 {
+				reg = <0>;
+				#phy-cells = <0>;
+			};
+
+			pcie1_phy: phy at 1 {
+				reg = <1>;
+				#phy-cells = <0>;
+			};
+		};
+
 		pinctrl: pinctrl at 0x0301d0c8 {
 			compatible = "brcm,cygnus-pinmux";
 			reg = <0x0301d0c8 0x30>,
@@ -161,6 +176,9 @@
 			ranges = <0x81000000 0 0	  0x28000000 0 0x00010000
 				  0x82000000 0 0x20000000 0x20000000 0 0x04000000>;
 
+			phys = <&pcie0_phy>;
+			phy-names = "pcie-phy";
+
 			status = "disabled";
 		};
 
@@ -182,6 +200,9 @@
 			ranges = <0x81000000 0 0	  0x48000000 0 0x00010000
 				  0x82000000 0 0x40000000 0x40000000 0 0x04000000>;
 
+			phys = <&pcie1_phy>;
+			phy-names = "pcie-phy";
+
 			status = "disabled";
 		};
 
Signature · 1 line
1.9.1
author maintainer
#2 lore raw

Re: [PATCH] ARM: dts: enable PCIe PHY support for Cygnus

Any comment on this DT change to enable PCIe PHY support for Cygnus?

Note the PHY driver has been accepted and is in v4.4.

Thanks,

Ray

Quoted 54 lines · Ray Jui

Enable PCIe PHY for both PCIe root complexes on Cygnus

---
  arch/arm/boot/dts/bcm-cygnus.dtsi | 21 +++++++++++++++++++++
  1 file changed, 21 insertions(+)
arch/arm/boot/dts/bcm-cygnus.dtsi +21 -0
index 2778533..5df5300 100644
@@ -91,6 +91,21 @@
  		#address-cells = <1>;
  		#size-cells = <1>;
 
+		pcie_phy: phy at 0301d0a0 {
+			compatible = "brcm,cygnus-pcie-phy";
+			reg = <0x0301d0a0 0x14>;
+
+			pcie0_phy: phy at 0 {
+				reg = <0>;
+				#phy-cells = <0>;
+			};
+
+			pcie1_phy: phy at 1 {
+				reg = <1>;
+				#phy-cells = <0>;
+			};
+		};
+
  		pinctrl: pinctrl at 0x0301d0c8 {
  			compatible = "brcm,cygnus-pinmux";
  			reg = <0x0301d0c8 0x30>,
@@ -161,6 +176,9 @@
  			ranges = <0x81000000 0 0	  0x28000000 0 0x00010000
  				  0x82000000 0 0x20000000 0x20000000 0 0x04000000>;
 
+			phys = <&pcie0_phy>;
+			phy-names = "pcie-phy";
+
  			status = "disabled";
  		};
 
@@ -182,6 +200,9 @@
  			ranges = <0x81000000 0 0	  0x48000000 0 0x00010000
  				  0x82000000 0 0x40000000 0x40000000 0 0x04000000>;
 
+			phys = <&pcie1_phy>;
+			phy-names = "pcie-phy";
+
  			status = "disabled";
  		};
 
maintainer Acked-by on v1 1/1
#3 lore raw

Re: [PATCH] ARM: dts: enable PCIe PHY support for Cygnus

In reply to Ray Jui

Ray,

Patch looks good.

Quoted 3 lines · Ray Jui

Enable PCIe PHY for both PCIe root complexes on Cygnus

Quoted 51 lines
---
  arch/arm/boot/dts/bcm-cygnus.dtsi | 21 +++++++++++++++++++++
  1 file changed, 21 insertions(+)
arch/arm/boot/dts/bcm-cygnus.dtsi +21 -0
index 2778533..5df5300 100644
@@ -91,6 +91,21 @@
  		#address-cells = <1>;
  		#size-cells = <1>;
 
+		pcie_phy: phy at 0301d0a0 {
+			compatible = "brcm,cygnus-pcie-phy";
+			reg = <0x0301d0a0 0x14>;
+
+			pcie0_phy: phy at 0 {
+				reg = <0>;
+				#phy-cells = <0>;
+			};
+
+			pcie1_phy: phy at 1 {
+				reg = <1>;
+				#phy-cells = <0>;
+			};
+		};
+
  		pinctrl: pinctrl at 0x0301d0c8 {
  			compatible = "brcm,cygnus-pinmux";
  			reg = <0x0301d0c8 0x30>,
@@ -161,6 +176,9 @@
  			ranges = <0x81000000 0 0	  0x28000000 0 0x00010000
  				  0x82000000 0 0x20000000 0x20000000 0 0x04000000>;
 
+			phys = <&pcie0_phy>;
+			phy-names = "pcie-phy";
+
  			status = "disabled";
  		};
 
@@ -182,6 +200,9 @@
  			ranges = <0x81000000 0 0	  0x48000000 0 0x00010000
  				  0x82000000 0 0x40000000 0x40000000 0 0x04000000>;
 
+			phys = <&pcie1_phy>;
+			phy-names = "pcie-phy";
+
  			status = "disabled";
  		};
 
#5 lore raw
Quoted 10 lines · Florian Fainelli
Quoted 7 lines · Ray Jui

This patch enales PCIe PHY in device tree for Broadcom Cygnus based platforms

This patch is developed based on v4.4-rc1 and available here:
https://github.com/Broadcom/cygnus-linux/tree/cygnus-pcie-phy-dt-v1

Ray Jui (1):
ARM: dts: enable PCIe PHY support for Cygnus

Applied to devicetree/next with Scott's Acked-by, thanks!

This caused the DTC compiler to warn:

Warning (reg_format): "reg" property in /axi/phy at 0301d0a0/phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /axi/phy at 0301d0a0/phy at 1 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /axi/phy at 0301d0a0/phy at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /axi/phy at 0301d0a0/phy at 0
Warning (avoid_default_addr_size): Relying on default #address-cells value for /axi/phy at 0301d0a0/phy at 1
Warning (avoid_default_addr_size): Relying on default #size-cells value for /axi/phy at 0301d0a0/phy at 1

  CC      drivers/base/power/runtime.o
  DTC     arch/arm/boot/dts/bcm911360k.dtb
  CC      lib/bitmap.o

I added an #address-cells = <0> and #size-cells = <1> to fix this, since your reg property is a single digit.

Signature · 1 line
Florian
author maintainer
#6 lore raw
Quoted 26 lines · Florian Fainelli
Quoted 10 lines · Florian Fainelli
Quoted 7 lines · Ray Jui

This patch enales PCIe PHY in device tree for Broadcom Cygnus based platforms

This patch is developed based on v4.4-rc1 and available here:
https://github.com/Broadcom/cygnus-linux/tree/cygnus-pcie-phy-dt-v1

Ray Jui (1):
ARM: dts: enable PCIe PHY support for Cygnus

Applied to devicetree/next with Scott's Acked-by, thanks!

This caused the DTC compiler to warn:

Warning (reg_format): "reg" property in /axi/phy at 0301d0a0/phy at 0 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (reg_format): "reg" property in /axi/phy at 0301d0a0/phy at 1 has invalid length (4 bytes) (#address-cells == 2, #size-cells == 1) Warning (avoid_default_addr_size): Relying on default #address-cells value for /axi/phy at 0301d0a0/phy at 0
Warning (avoid_default_addr_size): Relying on default #size-cells value for /axi/phy at 0301d0a0/phy at 0
Warning (avoid_default_addr_size): Relying on default #address-cells value for /axi/phy at 0301d0a0/phy at 1
Warning (avoid_default_addr_size): Relying on default #size-cells value for /axi/phy at 0301d0a0/phy at 1

Quoted 7 lines
   CC      drivers/base/power/runtime.o
   DTC     arch/arm/boot/dts/bcm911360k.dtb
   CC      lib/bitmap.o

I added an #address-cells = <0> and #size-cells = <1> to fix this, since your reg property is a single digit.

Sorry I missed that. Both are required properties.

Thanks!

Ray

#7 lore raw
In reply to Florian Fainelli
Quoted 4 lines · On Tuesday 01 December 2015 15:12:41 Florian Fainelli wrote:

CC lib/bitmap.o

I added an #address-cells = <0> and #size-cells = <1> to fix this, since your reg property is a single digit.

Did you mean #address-cells = <1> and #size-cells = <0>?

Arnd

#8 lore raw
Quoted 7 lines · Arnd Bergmann
Quoted 4 lines · On Tuesday 01 December 2015 15:12:41 Florian Fainelli wrote:

CC lib/bitmap.o

I added an #address-cells = <0> and #size-cells = <1> to fix this, since your reg property is a single digit.

Did you mean #address-cells = <1> and #size-cells = <0>?

Ermm, yes, thanks for catching this..

Signature · 1 line
Florian