Fix _FIT vs. NFIT processing breakage
RFC PATCH 1/1 Fix _FIT vs. NFIT processing breakage
Since commit 209851649dc4f7900a6bfe1de5e2640ab2c7d931, we no longer see NVDIMM devices on our systems. The NFIT/_FIT processing at initialization gets a table from _FIT but doesn't like it.
When support for _FIT was added, the code presumed that the data returned by the _FIT method is identical to the NFIT table, which starts with an acpi_table_header. However, the _FIT is defined to return a data in the format of a series of NFIT type structure entries and as a method, has an acpi_object header rather tahn an acpi_table_header.
To address the differences, explicitly save the acpi_table_header from the NFIT, since it is accessible through /sys, and change the nfit pointer in the acpi_desc structure to point to the table entries rather than the headers.
This is an RFC patch for several reasons.
1) I've only tested the boot path, not the code path gets gets a _FIT later.
2) There is some debug information that we probably don't want to keep in there.
3) I'm not even sure we should be checking _FIT at boot time
4) While this fixes my platform, it probably breaks the tests that were used to test the original commit.
If we need to have a long discussion about whether our firmware is correct, then perhaps we can remove the _FIT code from acpi_nfit_add() while we sort it out.
--- drivers/acpi/nfit.c | 55 +++++++++++++++++++++++++++++++++++++++++------------ drivers/acpi/nfit.h | 3 ++- 2 files changed, 45 insertions(+), 13 deletions(-)
drivers/acpi/nfit.c +44 -12
@@ -655,7 +655,7 @@ static ssize_t revision_show(struct device *dev,struct nvdimm_bus_descriptor *nd_desc =to_nd_desc (nvdimm_bus);struct acpi_nfit_desc *acpi_desc =to_acpi_desc (nd_desc); -return sprintf (buf,"%d\n" , acpi_desc->nfit->header.revision); +return sprintf (buf,"%d\n" , acpi_desc->acpi_header.revision); }static DEVICE_ATTR_RO (revision);
@@ -1652,7 +1652,6 @@ int acpi_nfit_init(struct acpi_nfit_desc *acpi_desc, acpi_size sz) data = (u8 *) acpi_desc->nfit; end = data + sz; - data +=sizeof (struct acpi_table_nfit );while (!IS_ERR_OR_NULL (data)) data =add_table (acpi_desc, &prev, data, end);
@@ -1748,13 +1747,34 @@ static int acpi_nfit_add(struct acpi_device *adev)return PTR_ERR (acpi_desc); } - acpi_desc->nfit = (struct acpi_table_nfit *) tbl; +/* +* Save the acpi header for later and then skip it, make +* nfit point to the first nfit table header. +*/ + acpi_desc->acpi_header = *tbl; + acpi_desc->nfit = (void *) tbl +sizeof (struct acpi_table_nfit ); + sz -=sizeof (struct acpi_table_nfit );/* Evaluate _FIT and override with that if present */ status =acpi_evaluate_object (adev->handle,"_FIT" ,NULL , &buf);if (ACPI_SUCCESS (status) && buf.length >0 ) { - acpi_desc->nfit = (struct acpi_table_nfit *)buf.pointer; - sz = buf.length; +union acpi_object *obj; + +dev_dbg (dev,"%s _FIT ptr %p, length: %d\n" , + __func__, buf.pointer, (int )buf.length); +print_hex_dump_debug ("_FIT: " ,DUMP_PREFIX_OFFSET ,16 ,1 , + buf.pointer, buf.length, true); + +/* +* Adjust for the acpi_object header of the _FIT +*/ + obj = buf.pointer; +if (obj->type ==ACPI_TYPE_BUFFER ) { + acpi_desc->nfit = (struct acpi_nfit_header *)obj->buffer.pointer; + sz = obj->buffer.length; + }else +dev_dbg (dev,"%s invalid type %d, ignoring _FIT\n" , + __func__, (int ) obj->type); } rc =acpi_nfit_init (acpi_desc, sz);
@@ -1777,8 +1796,9 @@ static void acpi_nfit_notify(struct acpi_device *adev, u32 event) {struct acpi_nfit_desc *acpi_desc =dev_get_drvdata (&adev->dev);struct acpi_buffer buf = {ACPI_ALLOCATE_BUFFER ,NULL }; -struct acpi_table_nfit *nfit_saved; +struct acpi_nfit_header *nfit_saved;struct device *dev = &adev->dev; +union acpi_object *obj;acpi_status status;int ret;
@@ -1807,13 +1827,24 @@ static void acpi_nfit_notify(struct acpi_device *adev, u32 event) goto out_unlock; } +dev_dbg (dev,"%s _FIT ptr %p, length: %d\n" , + __func__, buf.pointer, (int )buf.length); +print_hex_dump_debug ("_FIT: " ,DUMP_PREFIX_OFFSET ,16 ,1 , + buf.pointer, buf.length, true); + nfit_saved = acpi_desc->nfit; - acpi_desc->nfit = (struct acpi_table_nfit *)buf.pointer; - ret =acpi_nfit_init (acpi_desc, buf.length); -if (!ret) { -/* Merge failed, restore old nfit, and exit */ - acpi_desc->nfit = nfit_saved; -dev_err (dev,"failed to merge updated NFIT\n" ); + obj = buf.pointer; +if (obj->type ==ACPI_TYPE_BUFFER ) { + acpi_desc->nfit = (struct acpi_nfit_header *)obj->buffer.pointer; + ret =acpi_nfit_init (acpi_desc, obj->buffer.length); +if (!ret) { +/* Merge failed, restore old nfit, and exit */ + acpi_desc->nfit = nfit_saved; +dev_err (dev,"failed to merge updated NFIT\n" ); + } + }else { +/* Bad _FIT, restore old nfit */ +dev_err (dev,"Invalid _FIT\n" ); }kfree (buf.pointer);
drivers/acpi/nfit.h +2 -1
@@ -96,7 +96,8 @@ struct nfit_mem {struct acpi_nfit_desc {struct nvdimm_bus_descriptor nd_desc; -struct acpi_table_nfit *nfit; +struct acpi_table_header acpi_header; +struct acpi_nfit_header *nfit;struct mutex spa_map_mutex;struct mutex init_mutex;struct list_head spa_maps;
Signature · 1 line
1.8.3.1
Quoted 10 lines · Linda Knippers
Since commit
209851649dc4f7900a6bfe1de5e2640ab2c7d931, we no longer see NVDIMM devices on our systems. The NFIT/_FIT processing at initialization gets a table from_FITbut doesn't like it.When support for
_FITwas added, the code presumed that the data returned by the_FITmethod is identical to the NFIT table, which starts with an acpi_table_header. However, the_FITis defined to return a data in the format of a series of NFIT type structure entries and as a method, has anacpi_objectheader rather tahn anacpi_table_header.
Hm, I couldn't find any reference to this in the spec - that NFIT will have the acpi_table_header but _FIT will have a different header - but I'm no ACPI expert - is this usual convention? Any pointers where I could look at?
Quoted 6 lines
To address the differences, explicitly save the
acpi_table_headerfrom the NFIT, since it is accessible through /sys, and change the nfit pointer in theacpi_descstructure to point to the table entries rather than the headers.
Quoted 6 lines
This is an RFC patch for several reasons.
1) I've only tested the boot path, not the code path gets gets a_FITlater.
2) There is some debug information that we probably don't want to keep in there.
3) I'm not even sure we should be checking_FITat boot time
I think there is good reason to. If the driver is reloaded after a hotplug event but prior to a full system reboot, if we don't check _FIT, we will get the stale NFIT.
Quoted 147 lines
4) While this fixes my platform, it probably breaks the tests that were used to test the original commit.
If we need to have a long discussion about whether our firmware is correct, then perhaps we can remove the
_FITcode fromacpi_nfit_add()
while we sort it out.Reported-by Jeff Moyer ([email protected]>Signed-off-by Linda Knippers <[email protected]>---
drivers/acpi/nfit.c | 55 +++++++++++++++++++++++++++++++++++++++++---
---------
drivers/acpi/nfit.h | 3 ++-2 files changed, 45 insertions(+), 13 deletions(-)drivers/acpi/nfit.c +0
-0@@ -655,7 +655,7 @@ static ssize_t revision_show(struct device *dev,struct
nvdimm_bus_descriptor*nd_desc=to_nd_desc(nvdimm_bus);
structacpi_nfit_desc*acpi_desc=to_acpi_desc(nd_desc);drivers/acpi/nfit.c +0
-1- return sprintf(buf, "%d\n", acpi_desc->nfit-Quoted 1 line
header.revision);
drivers/acpi/nfit.c +1
-0+return sprintf (buf,"%d\n" , acpi_desc->acpi_header.revision);}
staticDEVICE_ATTR_RO(revision);drivers/acpi/nfit.c +0
-0@@ -1652,7 +1652,6 @@ int acpi_nfit_init(struct acpi_nfit_desc *acpi_desc, acpi_size sz)
data = (u8 *)acpi_desc->nfit;
end = data + sz;drivers/acpi/nfit.c +0
-1- data +=sizeof (struct acpi_table_nfit );while (!IS_ERR_OR_NULL(data))
data =add_table(acpi_desc, &prev, data, end);drivers/acpi/nfit.c +0
-0@@ -1748,13 +1747,34 @@ static int acpi_nfit_add(struct acpi_device *adev) return PTR_ERR(acpi_desc); }drivers/acpi/nfit.c +6
-1- acpi_desc->nfit = (struct acpi_table_nfit *) tbl; +/* +* Save the acpi header for later and then skip it, make +* nfit point to the first nfit table header. +*/ + acpi_desc->acpi_header = *tbl; + acpi_desc->nfit = (void *) tbl + sizeof(struct
acpi_table_nfit);drivers/acpi/nfit.c +1
-0+ sz -=sizeof (struct acpi_table_nfit );
/* Evaluate_FITand override with that if present */ status =acpi_evaluate_object(adev->handle, "_FIT", NULL, &buf);
if (ACPI_SUCCESS(status)&& buf.length > 0) {drivers/acpi/nfit.c +0
-1- acpi_desc->nfit = (struct acpi_table_nfit*)buf.pointer;
drivers/acpi/nfit.c +5
-1- sz = buf.length; +union acpi_object *obj; + +dev_dbg (dev,"%s _FIT ptr %p, length: %d\n" , + __func__, buf.pointer, (int )buf.length); + print_hex_dump_debug("_FIT: ", DUMP_PREFIX_OFFSET,16, 1,
drivers/acpi/nfit.c +8
-0+ buf.pointer, buf.length, true); + +/* +* Adjust for the acpi_object header of the _FIT +*/ + obj = buf.pointer; +if (obj->type ==ACPI_TYPE_BUFFER ) { + acpi_desc->nfit = (struct acpi_nfit_header*)obj->buffer.pointer;
drivers/acpi/nfit.c +3
-0+ sz = obj->buffer.length; + }else + dev_dbg(dev, "%s invalid type %d, ignoring_FIT\n",
drivers/acpi/nfit.c +1
-0+ __func__, (int) obj->type);}
rc =acpi_nfit_init(acpi_desc, sz);drivers/acpi/nfit.c +0
-0@@ -1777,8 +1796,9 @@ static void acpi_nfit_notify(struct acpi_device *adev, u32 event) {struct
acpi_nfit_desc*acpi_desc= dev_get_drvdata(&adev-Quoted 1 line
dev);
struct
acpi_bufferbuf = {ACPI_ALLOCATE_BUFFER, NULL };drivers/acpi/nfit.c +1
-1-struct acpi_table_nfit *nfit_saved; +struct acpi_nfit_header *nfit_saved;struct device *dev =
&adev->dev;drivers/acpi/nfit.c +1
-0+union acpi_object *obj;
acpi_statusstatus;
int ret;drivers/acpi/nfit.c +0
-0@@ -1807,13 +1827,24 @@ static void acpi_nfit_notify(struct acpi_device *adev, u32 event) goto out_unlock; }drivers/acpi/nfit.c +5
-0+dev_dbg (dev,"%s _FIT ptr %p, length: %d\n" , + __func__, buf.pointer, (int )buf.length); +print_hex_dump_debug ("_FIT: " ,DUMP_PREFIX_OFFSET ,16 ,1 , + buf.pointer, buf.length, true); +
nfit_saved=acpi_desc->nfit;drivers/acpi/nfit.c +3
-6- acpi_desc->nfit = (struct acpi_table_nfit *)buf.pointer; - ret =acpi_nfit_init (acpi_desc, buf.length); -if (!ret) { -/* Merge failed, restore old nfit, and exit */ - acpi_desc->nfit = nfit_saved; -dev_err (dev,"failed to merge updated NFIT\n" ); + obj = buf.pointer; +if (obj->type ==ACPI_TYPE_BUFFER ) { + acpi_desc->nfit = (struct acpi_nfit_header *)obj-Quoted 1 line
buffer.pointer;
drivers/acpi/nfit.c +3
-0+ ret =acpi_nfit_init (acpi_desc, obj->buffer.length); +if (!ret) { +/* Merge failed, restore old nfit, and exit */
drivers/acpi/nfit.c +2
-0+ acpi_desc->nfit = nfit_saved; + dev_err(dev, "failed to merge updatedNFIT\n");
drivers/acpi/nfit.c +4
-0+ } + }else { +/* Bad _FIT, restore old nfit */ +dev_err (dev,"Invalid _FIT\n" );}
kfree(buf.pointer);drivers/acpi/nfit.h +0
-0@@ -96,7 +96,8 @@ struct nfit_mem {
structacpi_nfit_desc{
structnvdimm_bus_descriptornd_desc;drivers/acpi/nfit.h +2
-1-struct acpi_table_nfit *nfit; +struct acpi_table_header acpi_header; +struct acpi_nfit_header *nfit;struct mutex
spa_map_mutex;
struct mutexinit_mutex;
structlist_headspa_maps;
Quoted 12 lines · Vishal L
Quoted 10 lines · Linda Knippers
Since commit
209851649dc4f7900a6bfe1de5e2640ab2c7d931, we no longer see NVDIMM devices on our systems. The NFIT/_FIT processing at initialization gets a table from_FITbut doesn't like it.When support for
_FITwas added, the code presumed that the data returned by the_FITmethod is identical to the NFIT table, which starts with anacpi_table_header. However, the_FITis defined to return a data in the format of a series of NFIT type structure entries and as a method, has anacpi_objectheader rather tahn anacpi_table_header.
Quoted 4 lines
Hm, I couldn't find any reference to this in the spec - that NFIT will have the
acpi_table_headerbut_FITwill have a different header - but I'm no ACPI expert - is this usual convention? Any pointers where I could look at?
I'm no ACPI expert either so maybe Toshi or someone else will help me here but according to the FW developer, the convention is that there is no ACPI table header because you already know what the table is.
Also, if you look at the NFIT definition (table 5-126) , the definition explicitly includes the APCI table header but the _FIT definition does not. It just says it's a series of NFIT Types structure entries.
-- ljk
Quoted 157 lines
Quoted 7 lines
To address the differences, explicitly save the
acpi_table_headerfrom the NFIT, since it is accessible through /sys, and change the nfit pointer in theacpi_descstructure to point to the table entries rather than the headers.Quoted 6 lines
This is an RFC patch for several reasons.
1) I've only tested the boot path, not the code path gets gets a_FITlater.
2) There is some debug information that we probably don't want to keep in there.
3) I'm not even sure we should be checking_FITat boot timeI think there is good reason to. If the driver is reloaded after a hotplug event but prior to a full system reboot, if we don't check
_FIT, we will get the stale NFIT.Quoted 139 lines
4) While this fixes my platform, it probably breaks the tests that were used to test the original commit.
If we need to have a long discussion about whether our firmware is correct, then perhaps we can remove the
_FITcode fromacpi_nfit_add()
while we sort it out.Reported-by Jeff Moyer ([email protected]>Signed-off-by Linda Knippers <[email protected]>--- drivers/acpi/nfit.c | 55 +++++++++++++++++++++++++++++++++++++++++--- --------- drivers/acpi/nfit.h | 3 ++- 2 files changed, 45 insertions(+), 13 deletions(-)drivers/acpi/nfit.c +1
-1@@ -655,7 +655,7 @@ static ssize_t revision_show(struct device *dev,struct nvdimm_bus_descriptor *nd_desc =to_nd_desc (nvdimm_bus);struct acpi_nfit_desc *acpi_desc =to_acpi_desc (nd_desc); -return sprintf (buf,"%d\n" , acpi_desc->nfit- > header.revision); +return sprintf (buf,"%d\n" , acpi_desc->acpi_header.revision); }static DEVICE_ATTR_RO(revision);drivers/acpi/nfit.c +12
-4@@ -1652,7 +1652,6 @@ int acpi_nfit_init(struct acpi_nfit_desc *acpi_desc, acpi_size sz) data = (u8 *) acpi_desc->nfit; end = data + sz; - data +=sizeof (struct acpi_table_nfit );while (!IS_ERR_OR_NULL (data)) data =add_table (acpi_desc, &prev, data, end);@@ -1748,13 +1747,34 @@ static int acpi_nfit_add(struct acpi_device *adev)return PTR_ERR (acpi_desc); } - acpi_desc->nfit = (struct acpi_table_nfit *) tbl; +/* +* Save the acpi header for later and then skip it, make +* nfit point to the first nfit table header. +*/ + acpi_desc->acpi_header = *tbl; + acpi_desc->nfit = (void *) tbl +sizeof (struct acpi_table_nfit ); + sz -=sizeof (struct acpi_table_nfit );/* Evaluate _FIT and override with that if present */ status =acpi_evaluate_object (adev->handle,"_FIT" ,NULL , &buf);if (ACPI_SUCCESS (status) && buf.length >0 ) { - acpi_desc->nfit = (struct acpi_table_nfit *)buf.pointer; - sz = buf.length; +union acpi_object *obj; + +dev_dbg (dev,"%s _FIT ptr %p, length: %d\n" , + __func__, buf.pointer, (int )buf.length); + print_hex_dump_debug("_FIT: ", DUMP_PREFIX_OFFSET,16, 1,
drivers/acpi/nfit.c +8
-0+ buf.pointer, buf.length, true); + +/* +* Adjust for the acpi_object header of the _FIT +*/ + obj = buf.pointer; +if (obj->type ==ACPI_TYPE_BUFFER ) { + acpi_desc->nfit = (struct acpi_nfit_header*)obj->buffer.pointer;
drivers/acpi/nfit.c +3
-0+ sz = obj->buffer.length; + }else + dev_dbg(dev, "%s invalid type %d, ignoring_FIT\n",
drivers/acpi/nfit.c +3
-1+ __func__, (int) obj->type); } rc =acpi_nfit_init (acpi_desc, sz);@@ -1777,8 +1796,9 @@ static void acpi_nfit_notify(struct acpi_device *adev, u32 event) {struct acpi_nfit_desc *acpi_desc =dev_get_drvdata (&adev- > dev);struct acpi_buffer buf = {ACPI_ALLOCATE_BUFFER ,NULL }; -struct acpi_table_nfit *nfit_saved; +struct acpi_nfit_header *nfit_saved;struct device *dev = &adev->dev; +union acpi_object *obj;acpi_status status;int ret;
drivers/acpi/nfit.c +13
-6@@ -1807,13 +1827,24 @@ static void acpi_nfit_notify(struct acpi_device *adev, u32 event) goto out_unlock; } +dev_dbg (dev,"%s _FIT ptr %p, length: %d\n" , + __func__, buf.pointer, (int )buf.length); +print_hex_dump_debug ("_FIT: " ,DUMP_PREFIX_OFFSET ,16 ,1 , + buf.pointer, buf.length, true); + nfit_saved = acpi_desc->nfit; -acpi_desc->nfit = (struct acpi_table_nfit *)buf.pointer; -ret = acpi_nfit_init(acpi_desc, buf.length); -if (!ret) { -/* Merge failed, restore old nfit, and exit */ - acpi_desc->nfit = nfit_saved; -dev_err (dev,"failed to merge updated NFIT\n" ); + obj = buf.pointer; +if (obj->type ==ACPI_TYPE_BUFFER ) { + acpi_desc->nfit = (struct acpi_nfit_header *)obj- > buffer.pointer; + ret =acpi_nfit_init (acpi_desc, obj->buffer.length); +if (!ret) { +/* Merge failed, restore old nfit, and exit */ + acpi_desc->nfit = nfit_saved; + dev_err(dev, "failed to merge updatedNFIT\n");
drivers/acpi/nfit.c +4
-0+ } + }else { +/* Bad _FIT, restore old nfit */ +dev_err (dev,"Invalid _FIT\n" ); }kfree (buf.pointer);drivers/acpi/nfit.h +0
-0@@ -96,7 +96,8 @@ struct nfit_mem {
Quoted 8 lines
drivers/acpi/nfit.h struct nfit_mem {
Quoted 8 lines
drivers/acpi/nfit.h +2
-1struct acpi_nfit_desc { struct nvdimm_bus_descriptor nd_desc; - struct acpi_table_nfit *nfit; + struct acpi_table_header acpi_header; + struct acpi_nfit_header *nfit; struct mutex spa_map_mutex; struct mutex init_mutex; struct list_head spa_maps;N�����r��y���b�X��ǧv�^�){.n�+����{�i�b�{ay�ʇڙ�,j��f���h���z��w������j:+v���w�j�m��������zZ+�����ݢj"��!tml=
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 13 lines · Linda Knippers
Quoted 12 lines · Vishal L
Quoted 10 lines · Linda Knippers
Since commit
209851649dc4f7900a6bfe1de5e2640ab2c7d931, we no longer see NVDIMM devices on our systems. The NFIT/_FIT processing at initialization gets a table from_FITbut doesn't like it.When support for
_FITwas added, the code presumed that the data returned by the_FITmethod is identical to the NFIT table, which starts with anacpi_table_header. However, the_FITis defined to return a data in the format of a series of NFIT type structure entries and as a method, has anacpi_objectheader rather tahn anacpi_table_header.
Quoted 8 lines
Quoted 4 lines
Hm, I couldn't find any reference to this in the spec - that NFIT will have the
acpi_table_headerbut_FITwill have a different header - but I'm no ACPI expert - is this usual convention? Any pointers where I could look at?I'm no ACPI expert either so maybe Toshi or someone else will help me here but according to the FW developer, the convention is that there is no ACPI table header because you already know what the table is.
map_mat_entry() handles _MAT for processor objects, which expects no MADT header table.
Thanks,
-Toshi
Quoted 4 lines
Also, if you look at the NFIT definition (table 5-126) , the definition explicitly includes the APCI table header but the
_FITdefinition does not. It just says it's a series of NFIT Types structure entries.
Quoted 31 lines · Toshi Kani
Quoted 24 lines · Linda Knippers
Quoted 15 lines · Vishal L
Quoted 5 lines · Linda Knippers
Since commit
209851649dc4f7900a6bfe1de5e2640ab2c7d931, we no longer
see NVDIMM devices on our systems. The NFIT/_FIT processing at initialization gets a table from_FITbut doesn't like it.Quoted 8 lines
When support for
_FITwas added, the code presumed that the data returned by the_FITmethod is identical to the NFIT table, which
starts with an acpi_table_header. However, the_FITis defined to return a data in the format of a series of NFIT type structure
entries and as a method, has anacpi_objectheader rather tahn anacpi_table_header.Quoted 7 lines
Hm, I couldn't find any reference to this in the spec - that NFIT will
have theacpi_table_headerbut_FITwill have a different header - but
I'm no ACPI expert - is this usual convention? Any pointers where I
could look at?Quoted 5 lines
I'm no ACPI expert either so maybe Toshi or someone else will help me
here but according to the FW developer, the convention is that there is
no ACPI table header because you already know what the table is.
Quoted 3 lines
map_mat_entry()handles_MATfor processor objects, which expects no MADT header
table.
Ok, thanks for the clarifications. I'm fine with the fix. Could you resend an updated patch without the extra debug. We'd also have to update the unit test framework - in tools/testing/nvdimm/test/nfit.c, in nfit_test0_setup, based on whether it is being called with the hotplug flag or not, decide which header to include.
Thanks,
-Vishal
Quoted 11 lines
Thanks,
-ToshiQuoted 6 lines
Also, if you look at the NFIT definition (table 5-126) , the definition
explicitly includes the APCI table header but the_FITdefinition does not.
It just says it's a series of NFIT Types structure entries.
Quoted 32 lines · Vishal L
Quoted 31 lines · Toshi Kani
Quoted 29 lines · Linda Knippers
Quoted 15 lines · Vishal L
Quoted 5 lines · Linda Knippers
Since commit
209851649dc4f7900a6bfe1de5e2640ab2c7d931, we no longer
see NVDIMM devices on our systems. The NFIT/_FIT processing at initialization gets a table from_FITbut doesn't like it.Quoted 8 lines
When support for
_FITwas added, the code presumed that the data returned by the_FITmethod is identical to the NFIT table, which
starts with anacpi_table_header. However, the_FITis defined to return a data in the format of a series of NFIT type structure
entries and as a method, has anacpi_objectheader rather tahn anacpi_table_header.Quoted 7 lines
Hm, I couldn't find any reference to this in the spec - that NFIT will
have theacpi_table_headerbut_FITwill have a different header - but
I'm no ACPI expert - is this usual convention? Any pointers where I
could look at?I'm no ACPI expert either so maybe Toshi or someone else will help me
here but according to the FW developer, the convention is that there is
no ACPI table header because you already know what the table is.
Quoted 6 lines
Quoted 3 lines
map_mat_entry()handles_MATfor processor objects, which expects no MADT header
table.Ok, thanks for the clarifications. I'm fine with the fix. Could you resend an updated patch without the extra debug.
Yes, I will do that. I've only tested the boot path of the patch though. Is there an easy way for me to trigger the notification so I can test the other code path?
- ljk
Quoted 18 lines
We'd also have to
update the unit test framework - intools/testing/nvdimm/test/nfit.c, innfit_test0_setup, based on whether it is being called with the hotplug flag or not, decide which header to include.Thanks,
-VishalQuoted 10 lines
Thanks,
-ToshiQuoted 6 lines
Also, if you look at the NFIT definition (table 5-126) , the definition
explicitly includes the APCI table header but the_FITdefinition does not.
It just says it's a series of NFIT Types structure entries.
On Thu, 2015-11-19 at 11:25 -0500, Linda Knippers wrote:
<>
Quoted 6 lines
Yes, I will do that. I've only tested the boot path of the patch though.
Is there an easy way for me to trigger the notification so I can test the other
code path?
Hm, I don't believe there is an easy way yet. I believe KVM enabling for NVDIMMS using the NFIT is under way, and once they are ready we might have a way to test that path, but for now I just tested acpi_nfit_init onward using the test framework in tools/testing/nvdimm.
Quoted 8 lines · Vishal L
On Thu, 2015-11-19 at 11:25 -0500, Linda Knippers wrote:
<>
Quoted 4 lines
Yes, I will do that. I've only tested the boot path of the patch though. Is there an easy way for me to trigger the notification so I can test the other code path?
Quoted 4 lines
Hm, I don't believe there is an easy way yet. I believe KVM enabling for NVDIMMS using the NFIT is under way, and once they are ready we might have a way to test that path, but for now I just tested
acpi_nfit_initonward using the test framework intools/testing/nvdimm.
After looking around for some generic way to get an ACPI device notify function called and failing miserably, I ended up just hacking the nfit.c revision_show() function to call the notify function any time I look at the /sys/.../nfit/revision file.
It's complaining that the new nfit deletes entries so I'm looking into that.
-- ljk