drm/tegra: fix locking of SET_TILING ioctl
PATCH v2 1/1 drm/tegra: fix locking of SET_TILING ioctl
Commit ef4c6270bf28 made the check of whether struct_mutex is held more verbose, and this triggers a warning when calling drm_gem_object_unreference() from tegra_gem_set_tiling() which does not acquire that lock.
Use drm_gem_object_unreference_unlocked() instead to ensure locking is handled correctly.
Signed-off-by Alexandre Courbot <[email protected]>
Reviewed-by Daniel Vetter <[email protected]>
---
v2: fix commit log according to Daniel's comments, add review tag.
drivers/gpu/drm/tegra/drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/tegra/drm.c +1 -1
@@ -683,7 +683,7 @@ static int tegra_gem_set_tiling(struct drm_device *drm, void *data, bo->tiling.mode = mode; bo->tiling.value = value; -drm_gem_object_unreference (gem); +drm_gem_object_unreference_unlocked (gem);return 0 ; }
Signature · 6 lines
2.6.2 _______________________________________________ dri-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/dri-devel