Skip to contentSkip to conversation

mk: fix compilation for icc version 16

PATCH Applied Declan Doherty 3 participants 3 messages Nov 20, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mk: fix compilation for icc version 16

This patch changes the ICC conditional check to disable -no-inline-max-size and -no-inline-max-total-size to be for all versions of icc greater than 14 and not just for version 15.

---
 mk/toolchain/icc/rte.vars.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mk/toolchain/icc/rte.vars.mk +2 -2
index e39d710..9b6b34b 100644
@@ -74,8 +74,8 @@ WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
 
 # process cpu flags
 include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
-# disable max-inline params boundaries for ICC 15 compiler
-ifeq ($(shell test $(ICC_MAJOR_VERSION) -eq 15 && echo 1), 1)
+# disable max-inline params boundaries for ICC compiler for version 15 and greater
+ifeq ($(shell test $(ICC_MAJOR_VERSION) -ge 14 && echo 1), 1)
 	TOOLCHAIN_CFLAGS += -no-inline-max-size -no-inline-max-total-size
 endif
 
Signature · 1 line
2.5.0
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 15 lines · Declan Doherty

This patch changes the ICC conditional check to disable -no-inline-max-size and -no-inline-max-total-size to be for all versions of icc greater than 14 and not just for version 15.

---
 mk/toolchain/icc/rte.vars.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
mk/toolchain/icc/rte.vars.mk +0 -0
index e39d710..9b6b34b 100644

mk/toolchain/icc/rte.vars.mk WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527 · line 81

Quoted 10 lines
mk/toolchain/icc/rte.vars.mk +2 -2
@@ -74,8 +74,8 @@ WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
 
 # process cpu flags
 include $(RTE_SDK)/mk/toolchain/$(RTE_TOOLCHAIN)/rte.toolchain-compat.mk
-# disable max-inline params boundaries for ICC 15 compiler
-ifeq ($(shell test $(ICC_MAJOR_VERSION) -eq 15 && echo 1), 1)
+# disable max-inline params boundaries for ICC compiler for version 15 and greater
+ifeq ($(shell test $(ICC_MAJOR_VERSION) -ge 14 && echo 1), 1)
 	TOOLCHAIN_CFLAGS += -no-inline-max-size -no-inline-max-total-size
 endif