Skip to contentSkip to conversation

extcon: arizona: Update naming for second jack detection DT binding

PATCH In review Charles Keepax 4 participants 6 messages Nov 20, 2015

Subsystems (2)
Device tree bindings External connector subsystem (extcon)
lore
Share & tools
lore

Charles Keepax

author
#0 lore raw

PATCH 1/1 extcon: arizona: Update naming for second jack detection DT binding

Update the name for the second jack detection pin binding to be a little less confusing.

Signed-off-by Charles Keepax <[email protected]>
---
 .../devicetree/bindings/extcon/extcon-arizona.txt  |    4 ++--
 drivers/extcon/extcon-arizona.c                    |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/extcon/extcon-arizona.txt +2 -2
index 03fa7b7..da9813b 100644
@@ -14,9 +14,9 @@ Optional properties:
     If this node is not mentioned or if the value is unknown, then
     headphone detection mode is set to HPDETL.
 
-  - wlf,use-jd-gpio : Use GPIO input along with JD1 for dual pin jack
+  - wlf,use-jd2 : Use the additional JD input along with JD1 for dual pin jack
     detection.
-  - wlf,use-jd-gpio-nopull : Internal pull on GPIO is disabled when used for
+  - wlf,use-jd2-nopull : Internal pull on JD2 is disabled when used for
     jack detection.
   - wlf,jd-invert : Invert the polarity of the jack detection switch
drivers/extcon/extcon-arizona.c +2 -2
index 7c9598d..c377030 100644
@@ -1245,9 +1245,9 @@ static int arizona_extcon_device_get_pdata(struct arizona *arizona)
 	device_property_read_u32(arizona->dev, "wlf,gpsw", &pdata->gpsw);
 
 	pdata->jd_gpio5 = device_property_read_bool(arizona->dev,
-						    "wlf,use-jd-gpio");
+						    "wlf,use-jd2");
 	pdata->jd_gpio5_nopull = device_property_read_bool(arizona->dev,
-						"wlf,use-jd-gpio-nopull");
+						"wlf,use-jd2-nopull");
 
 	return 0;
 }
Signature · 1 line
1.7.2.5
#1 lore raw

Hi,

Quoted 8 lines · Charles Keepax

Update the name for the second jack detection pin binding to be a little less confusing.

Signed-off-by Charles Keepax <ckeepax-yzvPICuk2AATkU/[email protected]>
---
 .../devicetree/bindings/extcon/extcon-arizona.txt  |    4 ++--
 drivers/extcon/extcon-arizona.c                    |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Applied it.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer
#2 lore raw
In reply to Charles Keepax
Quoted 2 lines · Charles Keepax

Update the name for the second jack detection pin binding to be a little less confusing.

This breaks compatibility with old dtbs. Either the driver needs to support both names or you just have to live with the old name.

Quoted 46 lines
Signed-off-by Charles Keepax <[email protected]>
---
 .../devicetree/bindings/extcon/extcon-arizona.txt  |    4 ++--
 drivers/extcon/extcon-arizona.c                    |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/extcon/extcon-arizona.txt +2 -2
index 03fa7b7..da9813b 100644
@@ -14,9 +14,9 @@ Optional properties:
     If this node is not mentioned or if the value is unknown, then
     headphone detection mode is set to HPDETL.
 
-  - wlf,use-jd-gpio : Use GPIO input along with JD1 for dual pin jack
+  - wlf,use-jd2 : Use the additional JD input along with JD1 for dual pin jack
     detection.
-  - wlf,use-jd-gpio-nopull : Internal pull on GPIO is disabled when used for
+  - wlf,use-jd2-nopull : Internal pull on JD2 is disabled when used for
     jack detection.
   - wlf,jd-invert : Invert the polarity of the jack detection switch
drivers/extcon/extcon-arizona.c +2 -2
index 7c9598d..c377030 100644
@@ -1245,9 +1245,9 @@ static int arizona_extcon_device_get_pdata(struct arizona *arizona)
 	device_property_read_u32(arizona->dev, "wlf,gpsw", &pdata->gpsw);
 
 	pdata->jd_gpio5 = device_property_read_bool(arizona->dev,
-						    "wlf,use-jd-gpio");
+						    "wlf,use-jd2");
 	pdata->jd_gpio5_nopull = device_property_read_bool(arizona->dev,
-						"wlf,use-jd-gpio-nopull");
+						"wlf,use-jd2-nopull");
 
 	return 0;
 }
Signature · 6 lines
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw

Hi Rob,

Quoted 6 lines · Rob Herring
Quoted 2 lines · Charles Keepax

Update the name for the second jack detection pin binding to be a little less confusing.

This breaks compatibility with old dtbs. Either the driver needs to support both names or you just have to live with the old name.

This property has not been yet in all dtbs on Linux 4.4-rc1.

[snip]

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
In reply to Rob Herring
Quoted 7 lines · Rob Herring
Quoted 2 lines · Charles Keepax

Update the name for the second jack detection pin binding to be a little less confusing.

This breaks compatibility with old dtbs. Either the driver needs to support both names or you just have to live with the old name.

This is a new DT option, it's never gone into a release kernel so there can't be any dtbs using it.

Quoted 42 lines
Quoted 42 lines
Signed-off-by Charles Keepax <ckeepax-yzvPICuk2AATkU/[email protected]>
---
 .../devicetree/bindings/extcon/extcon-arizona.txt  |    4 ++--
 drivers/extcon/extcon-arizona.c                    |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/extcon/extcon-arizona.txt +2 -2
index 03fa7b7..da9813b 100644
@@ -14,9 +14,9 @@ Optional properties:
     If this node is not mentioned or if the value is unknown, then
     headphone detection mode is set to HPDETL.
 
-  - wlf,use-jd-gpio : Use GPIO input along with JD1 for dual pin jack
+  - wlf,use-jd2 : Use the additional JD input along with JD1 for dual pin jack
     detection.
-  - wlf,use-jd-gpio-nopull : Internal pull on GPIO is disabled when used for
+  - wlf,use-jd2-nopull : Internal pull on JD2 is disabled when used for
     jack detection.
   - wlf,jd-invert : Invert the polarity of the jack detection switch
drivers/extcon/extcon-arizona.c +2 -2
index 7c9598d..c377030 100644
@@ -1245,9 +1245,9 @@ static int arizona_extcon_device_get_pdata(struct arizona *arizona)
 	device_property_read_u32(arizona->dev, "wlf,gpsw", &pdata->gpsw);
 
 	pdata->jd_gpio5 = device_property_read_bool(arizona->dev,
-						    "wlf,use-jd-gpio");
+						    "wlf,use-jd2");
 	pdata->jd_gpio5_nopull = device_property_read_bool(arizona->dev,
-						"wlf,use-jd-gpio-nopull");
+						"wlf,use-jd2-nopull");
 
 	return 0;
 }
Signature · 1 line
1.7.2.5
Quoted 4 lines
Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

maintainer Acked-by
#5 lore raw
Quoted 11 lines · Richard Fitzgerald
Quoted 7 lines · Rob Herring
Quoted 2 lines · Charles Keepax

Update the name for the second jack detection pin binding to be a little less confusing.

This breaks compatibility with old dtbs. Either the driver needs to support both names or you just have to live with the old name.

This is a new DT option, it's never gone into a release kernel so there can't be any dtbs using it.

I see the thread now. The commit message should make that clear.

Acked-by Rob Herring <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html