UBI: fix use of "VID" vs. "EC" in header self-check
Subsystems (2)
PATCH 1/1 UBI: fix use of "VID" vs. "EC" in header self-check
Looks like a typo, using UBI_EC_HDR_SIZE_CRC (note the "EC") to compute the CRC for the VID header.
This shouldn't cause any functional change, as both structures are 64 bytes. Verified with:
BUILD_BUG_ON(UBI_VID_HDR_SIZE_CRC != UBI_EC_HDR_SIZE_CRC);
Reported here:
http://lists.infradead.org/pipermail/linux-mtd/2013-September/048570.html
Reported by: Bill Pringlemeir <[email protected]>
---
I was sorting through really old email. Don't ask.
drivers/mtd/ubi/io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/ubi/io.c +1 -1
@@ -1299,7 +1299,7 @@ static int self_check_peb_vid_hdr(const struct ubi_device *ubi, int pnum)if (err && err !=UBI_IO_BITFLIPS && !mtd_is_eccerr (err)) goto exit; - crc =crc32 (UBI_CRC32_INIT , vid_hdr,UBI_EC_HDR_SIZE_CRC ); + crc =crc32 (UBI_CRC32_INIT , vid_hdr,UBI_VID_HDR_SIZE_CRC ); hdr_crc =be32_to_cpu (vid_hdr->hdr_crc);if (hdr_crc != crc) { ubi_err(ubi, "bad VID header CRC at PEB %d, calculated %#08x, read %#08x",
Signature · 1 line
2.6.0.rc2.230.g3dd15c0
Richard Weinberger
maintainerAm 20.11.2015 um 23:10 schrieb Brian Norris:
Quoted 8 lines
Looks like a typo, using
UBI_EC_HDR_SIZE_CRC(note the "EC") to compute the CRC for the VID header.This shouldn't cause any functional change, as both structures are 64 bytes. Verified with:
BUILD_BUG_ON(UBI_VID_HDR_SIZE_CRC != UBI_EC_HDR_SIZE_CRC);
Quoted 7 lines
Reported here:
http://lists.infradead.org/pipermail/linux-mtd/2013-September/048570.htmlReported by: Bill Pringlemeir <[email protected]>
Signed-off-by Brian Norris <[email protected]>---
I was sorting through really old email. Don't ask.
Patch looks good, thanks for the exhumation! ;)
Thanks,
//richard