Skip to contentSkip to conversation

mtd: maps: kill DC21285 driver

PATCH New Brian Norris 2 participants 2 messages Nov 20, 2015 – Nov 21, 2015 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: maps: kill DC21285 driver

This driver wouldn't build for over 5 years, between commit:

bd31b85960a7 ("locking, ARM: Annotate low level hw locks as raw")

and

e5babdf928e5 ("mtd: dc21285: use raw spinlock functions for nw_gpio_lock")

Also, it's unsafe to build into arbitrary kernels, as it might just start probing around memory, whether or not there's a compatible flash there. See comments here, last time someone tried to enable it:

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/347133.html

So, let's kill it. I bet no one will notice.

Cc Uwe Kleine-K?nig <[email protected]>
Cc Russell King <[email protected]>
Cc Nicolas Pitre <[email protected]>
---
 drivers/mtd/maps/Kconfig   |   8 --
 drivers/mtd/maps/Makefile  |   1 -
 drivers/mtd/maps/dc21285.c | 231 ---------------------------------------------
 3 files changed, 240 deletions(-)
 delete mode 100644 drivers/mtd/maps/dc21285.c
drivers/mtd/maps/Kconfig +0 -8
index 7c95a656f9e4..ddad3645f481 100644
@@ -262,14 +262,6 @@ config MTD_SA1100
 	  the SA1100 and SA1110, including the Assabet and the Compaq iPAQ.
 	  If you have such a board, say 'Y'.
 
-config MTD_DC21285
-	tristate "CFI Flash device mapped on DC21285 Footbridge"
-	depends on MTD_CFI && ARCH_FOOTBRIDGE && MTD_COMPLEX_MAPPINGS
-	help
-	  This provides a driver for the flash accessed using Intel's
-	  21285 bridge used with Intel's StrongARM processors. More info at
-	  <http://www.intel.com/design/bridge/docs/21285_documentation.htm>.
-
 config MTD_IXP4XX
 	tristate "CFI Flash device mapped on Intel IXP4xx based systems"
 	depends on MTD_CFI && MTD_COMPLEX_MAPPINGS && ARCH_IXP4XX
drivers/mtd/maps/Makefile +0 -1
index 141c91a5b24c..c67fcf03c3ce 100644
@@ -8,7 +8,6 @@ endif
 
 # Chip mappings
 obj-$(CONFIG_MTD_CFI_FLAGADM)	+= cfi_flagadm.o
-obj-$(CONFIG_MTD_DC21285)	+= dc21285.o
 obj-$(CONFIG_MTD_L440GX)	+= l440gx.o
 obj-$(CONFIG_MTD_AMD76XROM)	+= amd76xrom.o
 obj-$(CONFIG_MTD_ESB2ROM)	+= esb2rom.o
drivers/mtd/maps/dc21285.c deleted +0 -231

231 lines not on this page · raw message

Signature · 1 line
2.6.0.rc2.230.g3dd15c0
#1 lore raw

PATCH 1/1 mtd: maps: kill DC21285 driver

Quoted 8 lines · Brian Norris

This driver wouldn't build for over 5 years, between commit:

bd31b85960a7 ("locking, ARM: Annotate low level hw locks as raw")

and

e5babdf928e5 ("mtd: dc21285: use raw spinlock functions for nw_gpio_lock")

Quoted 7 lines

Also, it's unsafe to build into arbitrary kernels, as it might just start probing around memory, whether or not there's a compatible flash there. See comments here, last time someone tried to enable it:

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/347133.html

So, let's kill it. I bet no one will notice.

Waow. And I'm apparently the author. Last time I had access to hardware that could use it was in 2001.

Now I suppose this depends if there are still people with Netwinders out there, and if they're interested in having mainline running on it.

Nicolas