Skip to contentSkip to conversation

staging: comedi: Coding style warning fix for block comments

PATCH In review Jitendra Kumar Khasdev 3 participants 4 messages Nov 22, 2015 – Nov 23, 2015 Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: comedi: Coding style warning fix for block comments

This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl :
I) Block comments use * on subsequent lines

---
 drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)
drivers/staging/comedi/comedilib.h +16 -16
index 56baf85..ccbe17b 100644
@@ -1,20 +1,20 @@
 /*
-    linux/include/comedilib.h
-    header file for kcomedilib
-
-    COMEDI - Linux Control and Measurement Device Interface
-    Copyright (C) 1998-2001 David A. Schleef <[email protected]>
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-*/
+ * linux/include/comedilib.h
+ * header file for kcomedilib
+ *
+ * COMEDI - Linux Control and Measurement Device Interface
+ * Copyright (C) 1998-2001 David A. Schleef <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
 
 #ifndef _LINUX_COMEDILIB_H
 #define _LINUX_COMEDILIB_H
Signature · 1 line
1.9.1
#1 lore raw
Quoted 14 lines · Jitendra Kumar Khasdev

This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl :
I) Block comments use * on subsequent lines

---
 drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)
drivers/staging/comedi/comedilib.h +0 -0
index 56baf85..ccbe17b 100644

drivers/staging/comedi/comedilib.h line 2

Quoted 2 lines
drivers/staging/comedi/comedilib.h +0 -1
@@ -1,20 +1,20 @@
 /*
-    linux/include/comedilib.h

I don't think the file name is somehow useful here.

drivers/staging/comedi/comedilib.h line 3

Quoted 1 line
drivers/staging/comedi/comedilib.h +0 -1
-    header file for kcomedilib

Perhaps

* Header file for kcomedilib.

Quoted 41 lines
drivers/staging/comedi/comedilib.h +16 -15
-
-    COMEDI - Linux Control and Measurement Device Interface
-    Copyright (C) 1998-2001 David A. Schleef <[email protected]>
-
-    This program is free software; you can redistribute it and/or modify
-    it under the terms of the GNU General Public License as published by
-    the Free Software Foundation; either version 2 of the License, or
-    (at your option) any later version.
-
-    This program is distributed in the hope that it will be useful,
-    but WITHOUT ANY WARRANTY; without even the implied warranty of
-    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-    GNU General Public License for more details.
-*/
+ * linux/include/comedilib.h
+ * header file for kcomedilib
+ *
+ * COMEDI - Linux Control and Measurement Device Interface
+ * Copyright (C) 1998-2001 David A. Schleef <[email protected]>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
 
 #ifndef _LINUX_COMEDILIB_H
 #define _LINUX_COMEDILIB_H
--

1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 2 lines
With Best Regards,
Andy Shevchenko
#2 lore raw
Quoted 11 lines · Andy Shevchenko
Quoted 9 lines · Jitendra Kumar Khasdev

This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl :
I) Block comments use * on subsequent lines

---
  drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
  1 file changed, 16 insertions(+), 16 deletions(-)
Quoted 9 lines

drivers/staging/comedi/comedilib.h line 2

Quoted 7 lines
drivers/staging/comedi/comedilib.h +0 -1
index 56baf85..ccbe17b 100644
@@ -1,20 +1,20 @@
  /*
-    linux/include/comedilib.h

I don't think the file name is somehow useful here.

To be fair, this patch is merely fixing the comment style, rather than changing the contents. Although I wouldn't mind if this line were changed, especially as the existing pathname is wrong.

It could be changed to be just the basename of the header file like this:

* comedilib.h

which is similar to the header comment in comedidev.h.

Quoted 7 lines

drivers/staging/comedi/comedilib.h line 3

Quoted 3 lines
drivers/staging/comedi/comedilib.h +0 -1
-    header file for kcomedilib

Perhaps

* Header file for kcomedilib.

No objections there.

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-
#3 lore raw
In reply to Jitendra Kumar Khasdev
Quoted 8 lines · Jitendra Kumar Khasdev

This patch is to comedilib.h file that fixes up following warnings reported by checkpatch.pl :
I) Block comments use * on subsequent lines

---
  drivers/staging/comedi/comedilib.h | 32 ++++++++++++++++----------------
  1 file changed, 16 insertions(+), 16 deletions(-)

Please could you mention comedilib.h in the Subject line? E.g.:

staging: comedi: comedilib.h: Fix block comments

It helps to localize the affected area more.

Signature · 2 lines
-=( Ian Abbott @ MEV Ltd.    E-mail: <[email protected]> )=-
-=(                          Web: http://www.mev.co.uk/  )=-