test: fix crash in pmd_perf_test
PATCH 1/1 test: fix crash in pmd_perf_test
Fix crash in pmd_perf_test autotest (div by 0) when no packets received Also fixes the fact that the test passes even if exec_burst fails
To repeat the issue:
The system must be incorrectly set up so that all packets will be lost, i.e. no loopback cable, etc. This is an edge case, but still the test should not crash or pass when failing.
run the test app
RTE>> set_rxtx_sc poll_before_xmit
RTE>> pmd_perf_autotest
--snip--
Quoted 4 lines
Generate 4096 packets @socket 1 start to receive total expect 4096 4096 packets lost, IDLE 10000 times Floating point exception (core dumped)
--- app/test/test_pmd_perf.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-)
app/test/test_pmd_perf.c +9 -3
@@ -626,7 +626,10 @@ timeout:rte_free (pkts_burst); -return diff_tsc / total; +if (total >0 ) +return diff_tsc / total; +else +return -1 ; } static int
@@ -673,8 +676,10 @@ exec_burst(uint32_t flags, int lcore)/* wait for polling finished */ diff_tsc =rte_eal_wait_lcore (lcore); -if (diff_tsc <0 ) +if (diff_tsc <0 ) { +printf ("exec_burst: Failed to measure cycles per packet\n" );return -1 ; + }printf ("Result: %d cycles per packet\n" , diff_tsc);
@@ -811,7 +816,8 @@ test_pmd_perf(void)return -1 ; }else if (sc_flag ==SC_BURST_POLL_FIRST || sc_flag ==SC_BURST_XMIT_FIRST ) -exec_burst (sc_flag, slave_id); +if (exec_burst (sc_flag, slave_id) <0 ) +return -1 ;/* port tear down */ for (portid =0 ; portid < nb_ports; portid++) {
Signature · 1 line
2.1.0
Thomas Monjalon
Applied2015-11-23 11:45, David Hunt:
Quoted 11 lines
Fix crash in
pmd_perf_testautotest (div by 0) when no packets received Also fixes the fact that the test passes even ifexec_burstfailsTo repeat the issue:
The system must be incorrectly set up so that all packets will be lost, i.e. no loopback cable, etc. This is an edge case, but still the test should not crash or pass when failing.
run the test app
RTE>>set_rxtx_scpoll_before_xmit
RTE>>pmd_perf_autotest
--snip--
Quoted 6 lines
Quoted 4 lines
Generate 4096 packets @socket 1 start to receive total expect 4096 4096 packets lost, IDLE 10000 times Floating point exception (core dumped)
Signed-off-by David Hunt <[email protected]>
Applied, thanks