net: fec: no need to test for the return type of of_property_read_u32
Subsystems (3)
PATCH 1/1 net: fec: no need to test for the return type of of_property_read_u32
in case of error no need to set num_tx and num_rx = 1, because in case of error these variables will remain unchanged by of_property_read_u32 ie 1 only
Signed-off-by Saurabh Sengar <[email protected]>
--- drivers/net/ethernet/freescale/fec_main.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-)
drivers/net/ethernet/freescale/fec_main.c +2 -7
@@ -3277,7 +3277,6 @@ static void fec_enet_get_queue_num(struct platform_device *pdev, int *num_tx, int *num_rx) { struct device_node *np = pdev->dev.of_node; -int err; *num_tx = *num_rx =1 ;
@@ -3285,13 +3284,9 @@ fec_enet_get_queue_num(struct platform_device *pdev, int *num_tx, int *num_rx)return ;/* parse the num of tx and rx queues */ - err =of_property_read_u32 (np,"fsl,num-tx-queues" , num_tx); -if (err) - *num_tx =1 ; +of_property_read_u32 (np,"fsl,num-tx-queues" , num_tx); - err =of_property_read_u32 (np,"fsl,num-rx-queues" , num_rx); -if (err) - *num_rx =1 ; +of_property_read_u32 (np,"fsl,num-rx-queues" , num_rx);if (*num_tx <1 || *num_tx >FEC_ENET_MAX_TX_QS ) { dev_warn(&pdev->dev, "Invalid num_tx(=%d), fall back to 1\n",
Signature · 1 line
1.9.1
From: Saurabh Sengar <[email protected]>
Date: Mon, 23 Nov 2015 19:21:48 +0530
Quoted 4 lines
in case of error no need to set
num_txandnum_rx= 1, because in case of error these variables will remain unchanged byof_property_read_u32ie 1 onlySigned-off-by Saurabh Sengar <[email protected]>
Applied.