Skip to contentSkip to conversation

thermal: exynos: use of_property_read_u8()

PATCH In review Saurabh Sengar 3 participants 3 messages Nov 23, 2015 – Nov 24, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 thermal: exynos: use of_property_read_u8()

use of_property_read_u8() for u8 variables,
also changed the return type to void as this function return type is nowhere used.

---
 drivers/thermal/samsung/exynos_tmu.c | 30 +++++++++++++-----------------
 1 file changed, 13 insertions(+), 17 deletions(-)
drivers/thermal/samsung/exynos_tmu.c +13 -17
index fa61eff..b692c95 100644
@@ -1128,20 +1128,16 @@ static int exynos_of_get_soc_type(struct device_node *np)
 	return -EINVAL;
 }
 
-static int exynos_of_sensor_conf(struct device_node *np,
+static void exynos_of_sensor_conf(struct device_node *np,
 				 struct exynos_tmu_platform_data *pdata)
 {
-	u32 value;
-	int ret;
-
 	of_node_get(np);
 
-	ret = of_property_read_u32(np, "samsung,tmu_gain", &value);
-	pdata->gain = (u8)value;
-	of_property_read_u32(np, "samsung,tmu_reference_voltage", &value);
-	pdata->reference_voltage = (u8)value;
-	of_property_read_u32(np, "samsung,tmu_noise_cancel_mode", &value);
-	pdata->noise_cancel_mode = (u8)value;
+	of_property_read_u8(np, "samsung,tmu_gain", &pdata->gain);
+	of_property_read_u8(np, "samsung,tmu_reference_voltage",
+				&pdata->reference_voltage);
+	of_property_read_u8(np, "samsung,tmu_noise_cancel_mode",
+				&pdata->noise_cancel_mode);
 
 	of_property_read_u32(np, "samsung,tmu_efuse_value",
 			     &pdata->efuse_value);
@@ -1150,18 +1146,18 @@ static int exynos_of_sensor_conf(struct device_node *np,
 	of_property_read_u32(np, "samsung,tmu_max_efuse_value",
 			     &pdata->max_efuse_value);
 
-	of_property_read_u32(np, "samsung,tmu_first_point_trim", &value);
-	pdata->first_point_trim = (u8)value;
-	of_property_read_u32(np, "samsung,tmu_second_point_trim", &value);
-	pdata->second_point_trim = (u8)value;
-	of_property_read_u32(np, "samsung,tmu_default_temp_offset", &value);
-	pdata->default_temp_offset = (u8)value;
+	of_property_read_u8(np, "samsung,tmu_first_point_trim",
+				&pdata->first_point_trim);
+	of_property_read_u8(np, "samsung,tmu_second_point_trim",
+				&pdata->second_point_trim);
+	of_property_read_u8(np, "samsung,tmu_default_temp_offset",
+				&pdata->default_temp_offset);
 
 	of_property_read_u32(np, "samsung,tmu_cal_type", &pdata->cal_type);
 	of_property_read_u32(np, "samsung,tmu_cal_mode", &pdata->cal_mode);
 
 	of_node_put(np);
-	return 0;
+	return;
 }
 
 static int exynos_map_dt_data(struct platform_device *pdev)
Signature · 1 line
1.9.1
#1 lore raw
Quoted 4 lines · Saurabh Sengar

use of_property_read_u8() for u8 variables,
also changed the return type to void as this function return type is nowhere used.

I would be good if you could split both changes into two patches.

Also, I still do not understand properly the proposal to use u8.

Why are they u8?

If they are so, please document them in their DT bindings. Today, the bindings tell us they are s32 (as there is nothing really specifying the type).

BR

Quoted 49 lines
---
 drivers/thermal/samsung/exynos_tmu.c | 30 +++++++++++++-----------------
 1 file changed, 13 insertions(+), 17 deletions(-)
drivers/thermal/samsung/exynos_tmu.c +9 -16
index fa61eff..b692c95 100644
@@ -1128,20 +1128,16 @@ static int exynos_of_get_soc_type(struct device_node *np)
 	return -EINVAL;
 }
 
-static int exynos_of_sensor_conf(struct device_node *np,
+static void exynos_of_sensor_conf(struct device_node *np,
 				 struct exynos_tmu_platform_data *pdata)
 {
-	u32 value;
-	int ret;
-
 	of_node_get(np);
 
-	ret = of_property_read_u32(np, "samsung,tmu_gain", &value);
-	pdata->gain = (u8)value;
-	of_property_read_u32(np, "samsung,tmu_reference_voltage", &value);
-	pdata->reference_voltage = (u8)value;
-	of_property_read_u32(np, "samsung,tmu_noise_cancel_mode", &value);
-	pdata->noise_cancel_mode = (u8)value;
+	of_property_read_u8(np, "samsung,tmu_gain", &pdata->gain);
+	of_property_read_u8(np, "samsung,tmu_reference_voltage",
+				&pdata->reference_voltage);
+	of_property_read_u8(np, "samsung,tmu_noise_cancel_mode",
+				&pdata->noise_cancel_mode);
 
 	of_property_read_u32(np, "samsung,tmu_efuse_value",
 			     &pdata->efuse_value);
@@ -1150,18 +1146,18 @@ static int exynos_of_sensor_conf(struct device_node *np,
 	of_property_read_u32(np, "samsung,tmu_max_efuse_value",
 			     &pdata->max_efuse_value);
 
-	of_property_read_u32(np, "samsung,tmu_first_point_trim", &value);
-	pdata->first_point_trim = (u8)value;
-	of_property_read_u32(np, "samsung,tmu_second_point_trim", &value);
-	pdata->second_point_trim = (u8)value;
-	of_property_read_u32(np, "samsung,tmu_default_temp_offset", &value);
-	pdata->default_temp_offset = (u8)value;
+	of_property_read_u8(np, "samsung,tmu_first_point_trim",
+				&pdata->first_point_trim);
+	of_property_read_u8(np, "samsung,tmu_second_point_trim",

drivers/thermal/samsung/exynos_tmu.c static int exynos_of_sensor_conf(struct device_node *np, · line 1160

Quoted 10 lines
drivers/thermal/samsung/exynos_tmu.c +4 -1
+				&pdata->second_point_trim);
+	of_property_read_u8(np, "samsung,tmu_default_temp_offset",
+				&pdata->default_temp_offset);
 
 	of_property_read_u32(np, "samsung,tmu_cal_type", &pdata->cal_type);
 	of_property_read_u32(np, "samsung,tmu_cal_mode", &pdata->cal_mode);
 
 	of_node_put(np);
-	return 0;
+	return;

The landing return; is not needed.

Quoted 6 lines
drivers/thermal/samsung/exynos_tmu.c +0 -0
 }
 
 static int exynos_map_dt_data(struct platform_device *pdev)
Signature · 1 line
1.9.1
#2 lore raw
Quoted 8 lines · Eduardo Valentin
Quoted 4 lines · Saurabh Sengar

use of_property_read_u8() for u8 variables,
also changed the return type to void as this function return type is nowhere used.

I would be good if you could split both changes into two patches.

Quoted 7 lines

Also, I still do not understand properly the proposal to use u8.

Why are they u8?

If they are so, please document them in their DT bindings. Today, the bindings tell us they are s32 (as there is nothing really specifying the type).

It looks like u8 came from platform data from old times when the driver did not support DT. All of our Exynos mainline boards are converted to DT, so I think legacy platform data can be also changed to match DT. Which means changing from u8 to u32.

Best regards,
Krzysztof