Skip to contentSkip to conversation

extcon: arizona: Update naming for micd-timeout DT to include units

PATCH In review Charles Keepax 3 participants 4 messages Nov 23, 2015 – Dec 7, 2015

Subsystems (2)
Device tree bindings External connector subsystem (extcon)
lore
Share & tools
lore

Charles Keepax

author
#0 lore raw

PATCH 1/1 extcon: arizona: Update naming for micd-timeout DT to include units

Add time units of -ms (milliseconds) to wlf,micd-timeout.

Signed-off-by Charles Keepax <ckeepax-yzvPICuk2AATkU/[email protected]>
---
 .../devicetree/bindings/extcon/extcon-arizona.txt  |    2 +-
 drivers/extcon/extcon-arizona.c                    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/extcon/extcon-arizona.txt +1 -1
index da9813b..05d85ac 100644
@@ -33,7 +33,7 @@ Optional properties:
     specified as per the ARIZONA_MICD_TIME_XXX defines.
   - wlf,micd-dbtime : Microphone detection hardware debounces specified as the
     number of measurements to take, valid values being 2 and 4.
-  - wlf,micd-timeout : Timeout for microphone detection, specified in
+  - wlf,micd-timeout-ms : Timeout for microphone detection, specified in
     milliseconds.
   - wlf,micd-force-micbias : Force MICBIAS continuously on during microphone
     detection.
drivers/extcon/extcon-arizona.c +1 -1
index c377030..8647533 100644
@@ -1230,7 +1230,7 @@ static int arizona_extcon_device_get_pdata(struct arizona *arizona)
 	device_property_read_u32(arizona->dev, "wlf,micd-dbtime",
 				 &pdata->micd_dbtime);
 
-	device_property_read_u32(arizona->dev, "wlf,micd-timeout",
+	device_property_read_u32(arizona->dev, "wlf,micd-timeout-ms",
 				 &pdata->micd_timeout);
 
 	pdata->micd_force_micbias = device_property_read_bool(arizona->dev,
Signature · 6 lines
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
maintainer
#1 lore raw
Quoted 27 lines · Charles Keepax

Add time units of -ms (milliseconds) to wlf,micd-timeout.

Signed-off-by Charles Keepax <ckeepax-yzvPICuk2AATkU/[email protected]>
---
 .../devicetree/bindings/extcon/extcon-arizona.txt  |    2 +-
 drivers/extcon/extcon-arizona.c                    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/extcon/extcon-arizona.txt +1 -1
index da9813b..05d85ac 100644
@@ -33,7 +33,7 @@ Optional properties:
     specified as per the ARIZONA_MICD_TIME_XXX defines.
   - wlf,micd-dbtime : Microphone detection hardware debounces specified as the
     number of measurements to take, valid values being 2 and 4.
-  - wlf,micd-timeout : Timeout for microphone detection, specified in
+  - wlf,micd-timeout-ms : Timeout for microphone detection, specified in
     milliseconds.
   - wlf,micd-force-micbias : Force MICBIAS continuously on during microphone
     detection.
drivers/extcon/extcon-arizona.c +0 -0
index c377030..8647533 100644

drivers/extcon/extcon-arizona.c static int arizona_extcon_device_get_pdata(struct arizona *arizona) · line 1236

Quoted 8 lines
drivers/extcon/extcon-arizona.c +1 -1
@@ -1230,7 +1230,7 @@ static int arizona_extcon_device_get_pdata(struct arizona *arizona)
 	device_property_read_u32(arizona->dev, "wlf,micd-dbtime",
 				 &pdata->micd_dbtime);
 
-	device_property_read_u32(arizona->dev, "wlf,micd-timeout",
+	device_property_read_u32(arizona->dev, "wlf,micd-timeout-ms",
 				 &pdata->micd_timeout);
 
 	pdata->micd_force_micbias = device_property_read_bool(arizona->dev,

Applied it.

Thanks,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#2 lore raw
In reply to Charles Keepax
Quoted 26 lines · Charles Keepax

Add time units of -ms (milliseconds) to wlf,micd-timeout.

Signed-off-by Charles Keepax <[email protected]>
---
 .../devicetree/bindings/extcon/extcon-arizona.txt  |    2 +-
 drivers/extcon/extcon-arizona.c                    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/extcon/extcon-arizona.txt +1 -1
index da9813b..05d85ac 100644
@@ -33,7 +33,7 @@ Optional properties:
     specified as per the ARIZONA_MICD_TIME_XXX defines.
   - wlf,micd-dbtime : Microphone detection hardware debounces specified as the
     number of measurements to take, valid values being 2 and 4.
-  - wlf,micd-timeout : Timeout for microphone detection, specified in
+  - wlf,micd-timeout-ms : Timeout for microphone detection, specified in
     milliseconds.
   - wlf,micd-force-micbias : Force MICBIAS continuously on during microphone
     detection.
drivers/extcon/extcon-arizona.c +0 -0
index c377030..8647533 100644

drivers/extcon/extcon-arizona.c static int arizona_extcon_device_get_pdata(struct arizona *arizona) · line 1236

Quoted 8 lines
drivers/extcon/extcon-arizona.c +1 -1
@@ -1230,7 +1230,7 @@ static int arizona_extcon_device_get_pdata(struct arizona *arizona)
 	device_property_read_u32(arizona->dev, "wlf,micd-dbtime",
 				 &pdata->micd_dbtime);
 
-	device_property_read_u32(arizona->dev, "wlf,micd-timeout",
+	device_property_read_u32(arizona->dev, "wlf,micd-timeout-ms",
 				 &pdata->micd_timeout);
 
 	pdata->micd_force_micbias =

device_property_read_bool(arizona->dev,

While the change is nice, new kernel is supposed to work with old DTS. So you'd need to check for both properties here..
Pavel

Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
maintainer
#3 lore raw

Hi Pavel,

Quoted 34 lines · Pavel Machek
Quoted 33 lines · Charles Keepax

Add time units of -ms (milliseconds) to wlf,micd-timeout.

Signed-off-by Charles Keepax <[email protected]>
---
 .../devicetree/bindings/extcon/extcon-arizona.txt  |    2 +-
 drivers/extcon/extcon-arizona.c                    |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Documentation/devicetree/bindings/extcon/extcon-arizona.txt +1 -1
index da9813b..05d85ac 100644
@@ -33,7 +33,7 @@ Optional properties:
     specified as per the ARIZONA_MICD_TIME_XXX defines.
   - wlf,micd-dbtime : Microphone detection hardware debounces specified as the
     number of measurements to take, valid values being 2 and 4.
-  - wlf,micd-timeout : Timeout for microphone detection, specified in
+  - wlf,micd-timeout-ms : Timeout for microphone detection, specified in
     milliseconds.
   - wlf,micd-force-micbias : Force MICBIAS continuously on during microphone
     detection.
drivers/extcon/extcon-arizona.c +1 -1
index c377030..8647533 100644
@@ -1230,7 +1230,7 @@ static int arizona_extcon_device_get_pdata(struct arizona *arizona)
 	device_property_read_u32(arizona->dev, "wlf,micd-dbtime",
 				 &pdata->micd_dbtime);
 
-	device_property_read_u32(arizona->dev, "wlf,micd-timeout",
+	device_property_read_u32(arizona->dev, "wlf,micd-timeout-ms",
 				 &pdata->micd_timeout);
Quoted 5 lines

drivers/extcon/extcon-arizona.c static int arizona_extcon_device_get_pdata(struct arizona *arizona) · line 1236

Quoted 1 line
drivers/extcon/extcon-arizona.c +0 -0
 	pdata->micd_force_micbias =

device_property_read_bool(arizona->dev,

While the change is nice, new kernel is supposed to work with old DTS. So you'd need to check for both properties here..

This is new DT option. There are no dtbs usingt this property in latest kernel. So, ther is no issue.

Thanks,
Chanwoo Choi