PCI: Fix NUMA bounds check
Subsystems (2)
PATCH 1/1 PCI: Fix NUMA bounds check
Suggested here: http://marc.info/?l=linux-pci&m=144706760307247&w=2
P.
-----8<-----
The fix for 1266963 ("PCI: Prevent out of bounds access in numa_node override") should allow for the setting of all valid NUMA states including NUMA_NO_NODE, which is also interpreted as "any node". This change splits the test into a range check, and then a separate check to see if the node is online.
Fixes 1266963 ("PCI: Prevent out of bounds access in numa_node override")
Cc Sasha Levin <[email protected]>
Cc Bjorn Helgaas <[email protected]>
Signed-off-by Prarit Bhargava <[email protected]>
--- drivers/pci/pci-sysfs.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/pci/pci-sysfs.c +4 -1
@@ -216,7 +216,10 @@ static ssize_t numa_node_store(struct device *dev,if (ret)return ret; -if (node >=MAX_NUMNODES || !node_online (node)) +if (node <NUMA_NO_NODE || node >=MAX_NUMNODES ) +return -EINVAL ; + +if (node !=NUMA_NO_NODE && !node_online (node))return -EINVAL ;add_taint (TAINT_FIRMWARE_WORKAROUND ,LOCKDEP_STILL_OK );
Signature · 1 line
1.7.9.3