igb: Add I210 cable fault detection to self test
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 5/5 igb: Add I210 cable fault detection to self test
From: Joe Schultz <[email protected]>
Add an offline diagnostic test for the I210 internal PHY which checks for cable faults and reports the distance along the cable where the fault was detected. Fault types detected include open, short, and cross-pair short.
--- drivers/net/ethernet/intel/igb/e1000_defines.h | 13 +- drivers/net/ethernet/intel/igb/igb_ethtool.c | 192 ++++++++++++++++++++++++- 2 files changed, 199 insertions(+), 6 deletions(-)
drivers/net/ethernet/intel/igb/e1000_defines.h +12 -1
@@ -931,6 +931,7 @@#define I347AT4_PCDL1 0x11/* Pair 1 PHY Cable Diagnostics Length */ #define I347AT4_PCDL2 0x12/* Pair 2 PHY Cable Diagnostics Length */ #define I347AT4_PCDL3 0x13/* Pair 3 PHY Cable Diagnostics Length */ +#define I347AT4_PCDR 0x14/* PHY Cable Diagnostics Results */ #define I347AT4_PCDC 0x15/* PHY Cable Diagnostics Control */ #define I347AT4_PAGE_SELECT 0x16
@@ -951,7 +952,17 @@#define I347AT4_PSCR_DOWNSHIFT_8X 0x7000/* i347-AT4 PHY Cable Diagnostics Control */ -#define I347AT4_PCDC_CABLE_LENGTH_UNIT 0x0400/* 0=cm 1=meters */ +#define I347AT4_PCDC_CABLE_LENGTH_UNIT 0x0400/* 0=cm 1=meters */ +#define I347AT4_PCDC_CABLE_DIAG_STATUS 0x0800 +#define I347AT4_PCDC_DISABLE_CROSS_PAIR 0x2000 +#define I347AT4_PCDC_RUN_AT_AUTONEG 0x4000 +#define I347AT4_PCDC_RUN_TEST 0x8000 + +/* i347-AT4 PHY Cable Diagnostics Results */ +#define I347AT4_PCDR_CABLE_OK 0x0001/* No faults detected on pair */ +#define I347AT4_PCDR_CABLE_OPEN 0x0002/* Open pair detected */ +#define I347AT4_PCDR_CABLE_SHORT 0x0003/* Shorted pair detected */ +#define I347AT4_PCDR_CABLE_CROSS_SHORT 0x0004/* Cross-pair short detected */ /* Marvell 1112 only registers */ #define M88E1112_VCT_DSP_DISTANCE 0x001A
drivers/net/ethernet/intel/igb/igb_ethtool.c +187 -5
247 lines not on this page · raw message
Signature · 1 line
1.9.1
PATCH 5/5 igb: Add I210 cable fault detection to self test
Quoted 7 lines · Aaron Sierra
From: Joe Schultz <[email protected]>
Add an offline diagnostic test for the I210 internal PHY which checks for cable faults and reports the distance along the cable where the fault was detected. Fault types detected include open, short, and cross-pair short.
Quoted 7 lines
Signed-off-by Joe Schultz <[email protected]>Signed-off-by Aaron Sierra <[email protected]>---
?drivers/net/ethernet/intel/igb/e1000_defines.h |? 13 +- ?drivers/net/ethernet/intel/igb/igb_ethtool.c?? | 192
++++++++++++++++++++++++-
?2 files changed, 199 insertions(+), 6 deletions(-)
This patch does not apply cleanly due to changes to igb_ethtool.c.
?Please update this patch with my current next-queue tree (dev-queue
branch) and resubmit just this patch.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20151124/601f712e/attachment.asc>
PATCH 5/5 igb: Add I210 cable fault detection to self test
----- Original Message -----
Quoted 22 lines
From: "Jeff Kirsher" <[email protected]>
To: "Aaron Sierra" <[email protected]>, intel-wired-lan at lists.osuosl.org
Cc: "Carolyn Wyborny" <[email protected]>, "Joe Schultz" <[email protected]>
Sent: Tuesday, November 24, 2015 3:49:01 PM
Subject: Re: [PATCH 5/5] igb: Add I210 cable fault detection to self testQuoted 7 lines · Aaron Sierra
From: Joe Schultz <[email protected]>
Add an offline diagnostic test for the I210 internal PHY which checks for cable faults and reports the distance along the cable where the fault was detected. Fault types detected include open, short, and cross-pair short.
Quoted 7 lines
Signed-off-by Joe Schultz <[email protected]>Signed-off-by Aaron Sierra <[email protected]>---
?drivers/net/ethernet/intel/igb/e1000_defines.h |? 13 +- ?drivers/net/ethernet/intel/igb/igb_ethtool.c?? | 192
++++++++++++++++++++++++-
?2 files changed, 199 insertions(+), 6 deletions(-)
Quoted 3 lines
This patch does not apply cleanly due to changes to
igb_ethtool.c. ?Please update this patch with my current next-queue tree (dev-queue branch) and resubmit just this patch.
Jeff,
Sorry, I was out of the office last week. I'll look into getting you an updated version of this patch soon.
-Aaron S.