Skip to contentSkip to conversation

fm10k: fix wrong Rx func is used

PATCH Applied Chen Jing D(Mark) 3 participants 3 messages Nov 27, 2015 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fm10k: fix wrong Rx func is used

From: "Chen Jing D(Mark)" <[email protected]>

Steps to reproduce the bug:
1. All Rx offloading is disabled and start the device, then Vector Rx is used.
2. Stop the device. Re-configure to enable hw_ip_checksum = 1, start the device again.
3. In this case, assume regular Rx should be used since Vector Rx doesn't support ip checksum offload. But actually Vector Rx is used and cause checksum won't be done by hardware.

The reason is after re-configuring, driver misses an "else" in func fm10k_set_rx_function(). Then Rx func in last round are used.

Fixes 77a8ab47("fm10k: select best Rx function")
---
 drivers/net/fm10k/fm10k_ethdev.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/fm10k/fm10k_ethdev.c +2 -0
index 4f23ce3..e4aed94 100644
@@ -2486,6 +2486,8 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)
 			dev->rx_pkt_burst = fm10k_recv_pkts_vec;
 	} else if (dev->data->scattered_rx)
 		dev->rx_pkt_burst = fm10k_recv_scattered_pkts;
+	else
+		dev->rx_pkt_burst = fm10k_recv_pkts;
 
 	rx_using_sse =
 		(dev->rx_pkt_burst == fm10k_recv_scattered_pkts_vec ||
Signature · 1 line
1.7.7.6
Acked-by on v1 1/1
#1 lore raw

Hi,

Quoted 45 lines

-----Original Message-----
From: Chen, Jing D
Sent: Friday, November 27, 2015 9:56 AM
To: [email protected]
Cc: Wang, Xiao W <[email protected]>; Chen, Jing D <[email protected]>
Subject: [PATCH] fm10k: fix wrong Rx func is used

From: "Chen Jing D(Mark)" <[email protected]>

Steps to reproduce the bug:
1. All Rx offloading is disabled and start the device, then Vector Rx is used.
2. Stop the device. Re-configure to enable hw_ip_checksum = 1, start the device again.
3. In this case, assume regular Rx should be used since Vector Rx doesn't support ip checksum offload. But actually Vector Rx is used and cause checksum won't be done by hardware.

The reason is after re-configuring, driver misses an "else" in func fm10k_set_rx_function(). Then Rx func in last round are used.

Fixes 77a8ab47("fm10k: select best Rx function")
---
 drivers/net/fm10k/fm10k_ethdev.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
drivers/net/fm10k/fm10k_ethdev.c +2 -1
index 4f23ce3..e4aed94 100644
@@ -2486,6 +2486,8 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)
 			dev->rx_pkt_burst = fm10k_recv_pkts_vec;
 	} else if (dev->data->scattered_rx)
 		dev->rx_pkt_burst = fm10k_recv_scattered_pkts;
+	else
+		dev->rx_pkt_burst = fm10k_recv_pkts;
 
 	rx_using_sse =
 		(dev->rx_pkt_burst == fm10k_recv_scattered_pkts_vec ||
--
Quoted 1 line

1.7.7.6

Acked-by Xiao Wang on v1 1/1 Applied
#2 lore raw
In reply to Chen Jing D(Mark)

2015-11-27 09:55, Chen Jing D:

Quoted 11 lines

From: "Chen Jing D(Mark)" <[email protected]>

Steps to reproduce the bug:
1. All Rx offloading is disabled and start the device, then Vector Rx is used.
2. Stop the device. Re-configure to enable hw_ip_checksum = 1, start the device again.
3. In this case, assume regular Rx should be used since Vector Rx doesn't support ip checksum offload. But actually Vector Rx is used and cause checksum won't be done by hardware.

Quoted 5 lines

The reason is after re-configuring, driver misses an "else" in func fm10k_set_rx_function(). Then Rx func in last round are used.

Fixes 77a8ab47("fm10k: select best Rx function")

git log -1 --abbrev=12 --format='Fixes: %h ("%s")' 77a8ab47

Fixes 77a8ab47eb38 ("fm10k: select best Rx function")
Quoted 2 lines

Applied, thanks