Skip to contentSkip to conversation

Bluetooth: Fix updating wrong instance's scan_rsp data

PATCH In review Johan Hedberg 2 participants 2 messages Nov 27, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Bluetooth: Fix updating wrong instance's scan_rsp data

From: Johan Hedberg <[email protected]>

The __hci_req_update_scan_rsp_data gets the instance to be updated which should get passed to update_inst_scan_rsp_data() instead of always enabling the current instance.

---
 net/bluetooth/hci_request.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/bluetooth/hci_request.c +1 -1
index adfcd6f1d0de..edf2199de4ff 100644
@@ -1018,7 +1018,7 @@ void __hci_req_update_scan_rsp_data(struct hci_request *req, int instance)
 	if (instance == HCI_ADV_CURRENT)
 		instance = get_current_adv_instance(req->hdev);
 
-	update_inst_scan_rsp_data(req, get_current_adv_instance(req->hdev));
+	update_inst_scan_rsp_data(req, instance);
 }
 
 static u8 create_instance_adv_data(struct hci_dev *hdev, u8 instance, u8 *ptr)
Signature · 1 line
2.5.0
maintainer
#1 lore raw

Hi Johan,

Quoted 8 lines

The __hci_req_update_scan_rsp_data gets the instance to be updated which should get passed to update_inst_scan_rsp_data() instead of always enabling the current instance.

---
net/bluetooth/hci_request.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

patch has been applied to bluetooth-next tree.

Regards

Marcel