arm: socfpga: Remove fsloadcmd from environment

PATCH New Chin Liang See 3 participants 9 messages Nov 27, 2015

lore

Share & tools

lore

Chin Liang See

author

2015-11-27 02:27 UTC #0 lore raw

PATCH 1/1 arm: socfpga: Remove fsloadcmd from environment

Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command.

Signed-off-by Chin Liang See <[email protected]>

Cc Dinh Nguyen <[email protected]>

Cc Pavel Machek <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Stefan Roese <[email protected]>

---
 include/configs/socfpga_arria5_socdk.h   | 1 -
 include/configs/socfpga_cyclone5_socdk.h | 1 -
 include/configs/socfpga_de0_nano_soc.h   | 1 -
 include/configs/socfpga_sockit.h         | 1 -
 include/configs/socfpga_socrates.h       | 1 -
 5 files changed, 5 deletions(-)

include/configs/socfpga_arria5_socdk.h +0 -1

index 0506336..9337a58 100644
@@ -81,7 +81,6 @@
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
 	"fdtimagesize=0x7000\0" \
-	"fsloadcmd=ext2load\0" \
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

include/configs/socfpga_cyclone5_socdk.h +0 -1

index d7369ee..3b2cfb0 100644
@@ -81,7 +81,6 @@
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
 	"fdtimagesize=0x7000\0" \
-	"fsloadcmd=ext2load\0" \
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

include/configs/socfpga_de0_nano_soc.h +0 -1

index b371a9b..16e146c 100644
@@ -74,7 +74,6 @@
 	"bootimage=zImage\0" \
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
-		"fsloadcmd=ext2load\0" \
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

include/configs/socfpga_sockit.h +0 -1

index d26f53d..5bcee05 100644
@@ -79,7 +79,6 @@
 	"bootimage=zImage\0" \
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
-		"fsloadcmd=ext2load\0" \
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

include/configs/socfpga_socrates.h +0 -1

index 6331251..16a2a86 100644
@@ -75,7 +75,6 @@
 	"bootimage=zImage\0" \
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
-		"fsloadcmd=ext2load\0" \
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

Signature · 1 line

2.2.0

Stefan Roese

2015-11-27 03:18 UTC #1 lore raw

PATCH 1/1 arm: socfpga: Remove fsloadcmd from environment

Quoted 70 lines · Chin Liang See

Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command.

Signed-off-by Chin Liang See <[email protected]>

Cc Dinh Nguyen <[email protected]>

Cc Pavel Machek <[email protected]>

Cc Marek Vasut <[email protected]>

Cc Stefan Roese <[email protected]>

---
  include/configs/socfpga_arria5_socdk.h   | 1 -
  include/configs/socfpga_cyclone5_socdk.h | 1 -
  include/configs/socfpga_de0_nano_soc.h   | 1 -
  include/configs/socfpga_sockit.h         | 1 -
  include/configs/socfpga_socrates.h       | 1 -
  5 files changed, 5 deletions(-)

include/configs/socfpga_arria5_socdk.h +0 -1

index 0506336..9337a58 100644
@@ -81,7 +81,6 @@
  	"fdt_addr=100\0" \
  	"fdtimage=socfpga.dtb\0" \
  	"fdtimagesize=0x7000\0" \
-	"fsloadcmd=ext2load\0" \
  	"bootm ${loadaddr} - ${fdt_addr}\0" \
  	"mmcroot=/dev/mmcblk0p2\0" \
  	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

include/configs/socfpga_cyclone5_socdk.h +0 -1

index d7369ee..3b2cfb0 100644
@@ -81,7 +81,6 @@
  	"fdt_addr=100\0" \
  	"fdtimage=socfpga.dtb\0" \
  	"fdtimagesize=0x7000\0" \
-	"fsloadcmd=ext2load\0" \
  	"bootm ${loadaddr} - ${fdt_addr}\0" \
  	"mmcroot=/dev/mmcblk0p2\0" \
  	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

include/configs/socfpga_de0_nano_soc.h +0 -1

index b371a9b..16e146c 100644
@@ -74,7 +74,6 @@
  	"bootimage=zImage\0" \
  	"fdt_addr=100\0" \
  	"fdtimage=socfpga.dtb\0" \
-		"fsloadcmd=ext2load\0" \
  	"bootm ${loadaddr} - ${fdt_addr}\0" \
  	"mmcroot=/dev/mmcblk0p2\0" \
  	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

include/configs/socfpga_sockit.h +0 -1

index d26f53d..5bcee05 100644
@@ -79,7 +79,6 @@
  	"bootimage=zImage\0" \
  	"fdt_addr=100\0" \
  	"fdtimage=socfpga.dtb\0" \
-		"fsloadcmd=ext2load\0" \
  	"bootm ${loadaddr} - ${fdt_addr}\0" \
  	"mmcroot=/dev/mmcblk0p2\0" \
  	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

include/configs/socfpga_socrates.h +0 -0

index 6331251..16a2a86 100644

include/configs/socfpga_socrates.h line 80

Quoted 7 lines

include/configs/socfpga_socrates.h +0 -1

@@ -75,7 +75,6 @@
  	"bootimage=zImage\0" \
  	"fdt_addr=100\0" \
  	"fdtimage=socfpga.dtb\0" \
-		"fsloadcmd=ext2load\0" \
  	"bootm ${loadaddr} - ${fdt_addr}\0" \
  	"mmcroot=/dev/mmcblk0p2\0" \
  	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

Reviewed-by Stefan Roese <[email protected]>

Thanks,
Stefan

Marek Vasut

2015-11-27 10:35 UTC #2 lore raw

PATCH 1/1 arm: socfpga: Remove fsloadcmd from environment

In reply to Chin Liang See

Quoted 22 lines · Chin Liang See

Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command.
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
---
 include/configs/socfpga_arria5_socdk.h   | 1 -
 include/configs/socfpga_cyclone5_socdk.h | 1 -
 include/configs/socfpga_de0_nano_soc.h   | 1 -
 include/configs/socfpga_sockit.h         | 1 -
 include/configs/socfpga_socrates.h       | 1 -
 5 files changed, 5 deletions(-)
(quoted diff) +0 -0
b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 100644

include/configs/socfpga_arria5_socdk.h line 86

Quoted 7 lines

include/configs/socfpga_arria5_socdk.h +0 -1

@@ -81,7 +81,6 @@
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
 	"fdtimagesize=0x7000\0" \
-	"fsloadcmd=ext2load\0" \
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \

This doesn't apply to u-boot-socfpga/master . Any idea why ?

Best regards,
Marek Vasut

Chin Liang See

author

2015-11-27 12:10 UTC #3 lore raw

PATCH 1/1 arm: socfpga: Remove fsloadcmd from environment

Quoted 18 lines · Marek Vasut

Quoted 17 lines · Chin Liang See
Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command.
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
---
 include/configs/socfpga_arria5_socdk.h   | 1 -
 include/configs/socfpga_cyclone5_socdk.h | 1 -
 include/configs/socfpga_de0_nano_soc.h   | 1 -
 include/configs/socfpga_sockit.h         | 1 -
 include/configs/socfpga_socrates.h       | 1 -
 5 files changed, 5 deletions(-)

Quoted 15 lines

include/configs/socfpga_arria5_socdk.h line 86
Quoted 13 lines
(quoted diff) +0 -0
b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 100644
include/configs/socfpga_arria5_socdk.h +0 -1
@@ -81,7 +81,6 @@
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
 	"fdtimagesize=0x7000\0" \
-	"fsloadcmd=ext2load\0" \
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
This doesn't apply to u-boot-socfpga/master . Any idea why ?

Oh, this patch was on top of the QSPI patch. As that patch is acked, I am thinking that will be applied first than this (if acked).

Thanks
Chin Liang

Quoted 3 lines

Best regards,
Marek Vasut

Marek Vasut

2015-11-27 12:14 UTC #4 lore raw

PATCH 1/1 arm: socfpga: Remove fsloadcmd from environment

Quoted 33 lines · Chin Liang See

Quoted 32 lines · Marek Vasut
Quoted 31 lines · Chin Liang See
Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command.
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
---
 include/configs/socfpga_arria5_socdk.h   | 1 -
 include/configs/socfpga_cyclone5_socdk.h | 1 -
 include/configs/socfpga_de0_nano_soc.h   | 1 -
 include/configs/socfpga_sockit.h         | 1 -
 include/configs/socfpga_socrates.h       | 1 -
 5 files changed, 5 deletions(-)
(quoted diff) +0 -0
b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 100644
include/configs/socfpga_arria5_socdk.h +0 -1
@@ -81,7 +81,6 @@
 
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
 	"fdtimagesize=0x7000\0" \
 
-	"fsloadcmd=ext2load\0" \
 

Quoted 8 lines

Quoted 5 lines
include/configs/socfpga_arria5_socdk.h line 86
Quoted 3 lines
include/configs/socfpga_arria5_socdk.h +0 -0
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
This doesn't apply to u-boot-socfpga/master . Any idea why ?
Oh, this patch was on top of the QSPI patch. As that patch is acked, I am thinking that will be applied first than this (if acked).

Um, what did I smoke what I acked that patch ? :O

btw. if you have some inter-patch deps, it'd be real nice if you could put a note about that somewhere next time.

Best regards,
Marek Vasut

Chin Liang See

author

2015-11-27 12:18 UTC #5 lore raw

PATCH 1/1 arm: socfpga: Remove fsloadcmd from environment

Quoted 41 lines · Marek Vasut

Quoted 40 lines · Chin Liang See
Quoted 38 lines · Marek Vasut
Quoted 31 lines · Chin Liang See
Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command.
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
---
 include/configs/socfpga_arria5_socdk.h   | 1 -
 include/configs/socfpga_cyclone5_socdk.h | 1 -
 include/configs/socfpga_de0_nano_soc.h   | 1 -
 include/configs/socfpga_sockit.h         | 1 -
 include/configs/socfpga_socrates.h       | 1 -
 5 files changed, 5 deletions(-)
(quoted diff) +0 -0
b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 100644
include/configs/socfpga_arria5_socdk.h +0 -1
@@ -81,7 +81,6 @@
 
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
 	"fdtimagesize=0x7000\0" \
 
-	"fsloadcmd=ext2load\0" \
 
include/configs/socfpga_arria5_socdk.h line 86
Quoted 3 lines
include/configs/socfpga_arria5_socdk.h +0 -0
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
This doesn't apply to u-boot-socfpga/master . Any idea why ?

Quoted 6 lines

Quoted 3 lines
Oh, this patch was on top of the QSPI patch. As that patch is acked, I
am thinking that will be applied first than this (if acked).
Um, what did I smoke what I acked that patch ? :O

Oh its actually acked by Pavel. But let me know if you want me to let this patch go first than QSPI.

Quoted 4 lines

btw. if you have some inter-patch deps, it'd be real nice if you could
put a note about that somewhere next time.

Noted.

Thanks
Chin Liang

Quoted 2 lines

Best regards,
Marek Vasut

Marek Vasut

2015-11-27 12:52 UTC #6 lore raw

PATCH 1/1 arm: socfpga: Remove fsloadcmd from environment

In reply to Chin Liang See

Quoted 33 lines · Chin Liang See

Quoted 32 lines · Marek Vasut
Quoted 31 lines · Chin Liang See
Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command.
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
---
 include/configs/socfpga_arria5_socdk.h   | 1 -
 include/configs/socfpga_cyclone5_socdk.h | 1 -
 include/configs/socfpga_de0_nano_soc.h   | 1 -
 include/configs/socfpga_sockit.h         | 1 -
 include/configs/socfpga_socrates.h       | 1 -
 5 files changed, 5 deletions(-)
(quoted diff) +0 -0
b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 100644
include/configs/socfpga_arria5_socdk.h +0 -1
@@ -81,7 +81,6 @@
 
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
 	"fdtimagesize=0x7000\0" \
 
-	"fsloadcmd=ext2load\0" \
 

Quoted 8 lines

Quoted 5 lines
include/configs/socfpga_arria5_socdk.h line 86
Quoted 3 lines
include/configs/socfpga_arria5_socdk.h +0 -0
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
This doesn't apply to u-boot-socfpga/master . Any idea why ?
Oh, this patch was on top of the QSPI patch. As that patch is acked, I am thinking that will be applied first than this (if acked).

I'm inclined to pick this one up early and what for the QSPI situation to pan out. Can you resubmit this one on top of u-boot-socfpga/master ? I can fix the patch myself too tho...

Best regards,
Marek Vasut

Chin Liang See

author

2015-11-27 13:09 UTC #7 lore raw

PATCH 1/1 arm: socfpga: Remove fsloadcmd from environment

Quoted 45 lines · Marek Vasut

Quoted 40 lines · Chin Liang See
Quoted 31 lines · Marek Vasut
Quoted 29 lines · Chin Liang See
Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command.
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
---
 include/configs/socfpga_arria5_socdk.h   | 1 -
 include/configs/socfpga_cyclone5_socdk.h | 1 -
 include/configs/socfpga_de0_nano_soc.h   | 1 -
 include/configs/socfpga_sockit.h         | 1 -
 include/configs/socfpga_socrates.h       | 1 -
 5 files changed, 5 deletions(-)
(quoted diff) +0 -0
b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 100644
include/configs/socfpga_arria5_socdk.h +0 -0
@@ -81,7 +81,6 @@
 
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
 	"fdtimagesize=0x7000\0" \
 
Quoted 7 lines
include/configs/socfpga_arria5_socdk.h line 86
Quoted 5 lines
include/configs/socfpga_arria5_socdk.h +0 -1
-	"fsloadcmd=ext2load\0" \
 
include/configs/socfpga_arria5_socdk.h +0 -0
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
This doesn't apply to u-boot-socfpga/master . Any idea why ?
Quoted 3 lines
Oh, this patch was on top of the QSPI patch. As that patch is acked, I
am thinking that will be applied first than this (if acked).

Quoted 6 lines

I'm inclined to pick this one up early and what for the QSPI situation to pan
out. Can you resubmit this one on top of u-boot-socfpga/master ? I can fix the
patch myself too tho...

Sure, let me do that as its a quick one :)

Thanks
Chin Liang

Quoted 2 lines

Best regards,
Marek Vasut

Marek Vasut

2015-11-27 13:16 UTC #8 lore raw

PATCH 1/1 arm: socfpga: Remove fsloadcmd from environment

Quoted 47 lines · Chin Liang See

Quoted 46 lines · Marek Vasut
Quoted 44 lines · Chin Liang See
Quoted 32 lines · Marek Vasut
On Friday, November 27, 2015 at 03:27:51 AM, Chin Liang See
Quoted 29 lines · wrote:
Remove fsloadcmd / ext2load as we are using load command which use the corresponding latest file system command.
Signed-off-by Chin Liang See <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Dinh Nguyen <[email protected]>
Cc Pavel Machek <[email protected]>
Cc Marek Vasut <[email protected]>
Cc Stefan Roese <[email protected]>
---
 include/configs/socfpga_arria5_socdk.h   | 1 -
 include/configs/socfpga_cyclone5_socdk.h | 1 -
 include/configs/socfpga_de0_nano_soc.h   | 1 -
 include/configs/socfpga_sockit.h         | 1 -
 include/configs/socfpga_socrates.h       | 1 -
 5 files changed, 5 deletions(-)
(quoted diff) +0 -0
b/include/configs/socfpga_arria5_socdk.h index 0506336..9337a58 100644
include/configs/socfpga_arria5_socdk.h +0 -0
@@ -81,7 +81,6 @@
 
 	"fdt_addr=100\0" \
 	"fdtimage=socfpga.dtb\0" \
 	"fdtimagesize=0x7000\0" \
 
Quoted 7 lines
include/configs/socfpga_arria5_socdk.h line 86
Quoted 5 lines
include/configs/socfpga_arria5_socdk.h +0 -1
-	"fsloadcmd=ext2load\0" \
 
include/configs/socfpga_arria5_socdk.h +0 -0
 	"bootm ${loadaddr} - ${fdt_addr}\0" \
 	"mmcroot=/dev/mmcblk0p2\0" \
 	"mmcboot=setenv bootargs " CONFIG_BOOTARGS \
This doesn't apply to u-boot-socfpga/master . Any idea why ?
Oh, this patch was on top of the QSPI patch. As that patch is acked, I
am thinking that will be applied first than this (if acked).

Quoted 7 lines

Quoted 5 lines
I'm inclined to pick this one up early and what for the QSPI situation to pan
out. Can you resubmit this one on top of u-boot-socfpga/master ? I can fix the
patch myself too tho...
Sure, let me do that as its a quick one :)

Thanks :)

Best regards,
Marek Vasut