Skip to contentSkip to conversation

qt5/qt53d: new package

PATCH New Jordon Wu 3 participants 6 messages Dec 1, 2015 – Dec 4, 2015

lore
Share & tools
lore

Jordon Wu

author
#0 lore raw

PATCH 1/1 qt5/qt53d: new package

---
 package/qt5/Config.in        |  1 +
 package/qt5/qt53d/Config.in  | 22 ++++++++++++++++
 package/qt5/qt53d/qt53d.hash |  4 +++
 package/qt5/qt53d/qt53d.mk   | 61 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 88 insertions(+)
 create mode 100755 package/qt5/qt53d/Config.in
 create mode 100755 package/qt5/qt53d/qt53d.hash
 create mode 100755 package/qt5/qt53d/qt53d.mk
package/qt5/Config.in +1 -0
index 22fd0c0..93936ae 100644
@@ -45,6 +45,7 @@ source "package/qt5/qt5webchannel/Config.in"
 source "package/qt5/qt5websockets/Config.in"
 source "package/qt5/qt5x11extras/Config.in"
 source "package/qt5/qt5xmlpatterns/Config.in"
+source "package/qt5/qt53d/Config.in"
 comment "legacy compatibility"
 source "package/qt5/qt5quick1/Config.in"
 source "package/qt5/qt5script/Config.in"
package/qt5/qt53d/Config.in new file +22 -0
new file mode 100755
index 0000000..e3080c9
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_QT53D
+	bool "qt53d"
+	select BR2_PACKAGE_QT5BASE
+	select BR2_PACKAGE_QT5BASE_GUI
+	select BR2_PACKAGE_QT5DECLARATIVE
+	select BR2_PACKAGE_QT5IMAGEFORMATS
+	help
+	  Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  This package corresponds to the qt53d module.
+
+	  http://qt.io
+
+if BR2_PACKAGE_QT53D
+
+config BR2_PACKAGE_QT53D_EXAMPLES
+	bool "Compile and install examples (with code)"
+	help
+	  If unsure, say N.
+
+endif
package/qt5/qt53d/qt53d.hash new file +4 -0
new file mode 100755
index 0000000..bb65454
@@ -0,0 +1,4 @@
+# Hashes from: http://download.qt.io/official_releases/qt/5.5/5.5.0/submodules/qt3d-opensource-src-5.5.0.tar.xz.mirrorlist
+sha256 bf6c54fbb6f279e9bd6fd67f7faa8e61ac4273baa06a56f8946346adc8c3568e qt3d-opensource-src-5.5.0.tar.xz
+sha1   dc76e83eaafd7c0edccd8557f03fbfd61ea68213                         qt3d-opensource-src-5.5.0.tar.xz
+md5    508c90c3a2a5f37f0f7c2dd696ab10f5                                 qt3d-opensource-src-5.5.0.tar.xz
package/qt5/qt53d/qt53d.mk new file +61 -0

61 lines not on this page · raw message

Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 qt5/qt53d: new package

Dear Jordon Wu,

Quoted 10 lines · Jordon Wu
---
 package/qt5/Config.in        |  1 +
 package/qt5/qt53d/Config.in  | 22 ++++++++++++++++
 package/qt5/qt53d/qt53d.hash |  4 +++
 package/qt5/qt53d/qt53d.mk   | 61 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 88 insertions(+)
 create mode 100755 package/qt5/qt53d/Config.in
 create mode 100755 package/qt5/qt53d/qt53d.hash
 create mode 100755 package/qt5/qt53d/qt53d.mk

For information, we have already a patch pending to add qt5 3d, from Peter Seiderer, which was sent just a few days ago. See:
http://patchwork.ozlabs.org/patch/547753/.

Maybe you can compare your implementation proposed by Peter (in Cc) and see if there's anything to add to Peter's patch ?

Don't hesitate to test Peter's patch and provide your Tested-by if it works for you.

Best regards,

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
author
#2 lore raw

PATCH 1/1 qt5/qt53d: new package

Hi Thomas,

I tested Peter's patch, It didn't handle qt3d's plugins, qml and examples cases.

Best Regards
Jordon Wu

2015-12-01 20:20 GMT+08:00 Thomas Petazzoni <
[email protected]>:

Quoted 25 lines

Dear Jordon Wu,

Quoted 6 lines · Jordon Wu
---
 package/qt5/Config.in        |  1 +
 package/qt5/qt53d/Config.in  | 22 ++++++++++++++++
 package/qt5/qt53d/qt53d.hash |  4 +++
 package/qt5/qt53d/qt53d.mk   | 61

++++++++++++++++++++++++++++++++++++++++++++

Quoted 4 lines
 4 files changed, 88 insertions(+)
 create mode 100755 package/qt5/qt53d/Config.in
 create mode 100755 package/qt5/qt53d/qt53d.hash
 create mode 100755 package/qt5/qt53d/qt53d.mk

For information, we have already a patch pending to add qt5 3d, from Peter Seiderer, which was sent just a few days ago. See:
http://patchwork.ozlabs.org/patch/547753/.

Maybe you can compare your implementation proposed by Peter (in Cc) and see if there's anything to add to Peter's patch ?

Don't hesitate to test Peter's patch and provide your Tested-by if it works for you.

Quoted 8 lines

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151202/940fc91e/attachment-0001.html>

#3 lore raw

PATCH 1/1 qt5/qt53d: new package

Hello Jordon,

Quoted 4 lines · Jordon Wu

Hi Thomas,

I tested Peter's patch, It didn't handle qt3d's plugins, qml and examples cases.

Thanks for testing, short answer to your three critics (longer answer for details in an upcoming answer to your patch):

- plugins: the only qt3d plugin is in src/plugins/sceneparsers/assimp and needs the assimp library [1] to build (see the README file for additional info). The assimp library is (not yet?) available as buildroot package...

- qml: what do you mean is missing in my patch?

- examples: o.k. missing from my patch, but many examples need the assimp plugin at run time... I think best would be if you could submit the example enhancement on top of my patch?

Regards,
Peter

[1] http://assimp.sourceforge.net/

Quoted 40 lines

Best Regards
Jordon Wu

2015-12-01 20:20 GMT+08:00 Thomas Petazzoni <
thomas.petazzoni at free-electrons.com>:

Quoted 33 lines

Dear Jordon Wu,

Quoted 6 lines · Jordon Wu
---
 package/qt5/Config.in        |  1 +
 package/qt5/qt53d/Config.in  | 22 ++++++++++++++++
 package/qt5/qt53d/qt53d.hash |  4 +++
 package/qt5/qt53d/qt53d.mk   | 61

++++++++++++++++++++++++++++++++++++++++++++

Quoted 4 lines
 4 files changed, 88 insertions(+)
 create mode 100755 package/qt5/qt53d/Config.in
 create mode 100755 package/qt5/qt53d/qt53d.hash
 create mode 100755 package/qt5/qt53d/qt53d.mk

For information, we have already a patch pending to add qt5 3d, from Peter Seiderer, which was sent just a few days ago. See:
http://patchwork.ozlabs.org/patch/547753/.

Maybe you can compare your implementation proposed by Peter (in Cc) and see if there's anything to add to Peter's patch ?

Don't hesitate to test Peter's patch and provide your Tested-by if it works for you.

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

author
#4 lore raw

PATCH 1/1 qt5/qt53d: new package

Hi Peter,

plugins: It seems make sense handle qt3d plugins after qt3d 5.6 released as assimp is included as thirdparty in qt3d 5.6 branch

qml: below qml need to copy to target. and my patch should change to copy qt3d's only
output/staging/usr/qml/Qt3D/
??? Input
? ??? libquick3dinputplugin.so
? ??? qmldir
??? libquick3dcoreplugin.so
??? qmldir
??? Renderer

    ??? libquick3drendererplugin.so
    ??? qmldir

examples: same as plugins. It's better handle it after qt3d 5.6 released or change to 5.6 branch using git repo

I will commit a enhancement after your patch applied. Thanks

Best Regards
Jordon Wu

2015-12-04 5:45 GMT+08:00 Peter Seiderer <[email protected]>:

Quoted 19 lines

Hello Jordon,

Quoted 4 lines · Jordon Wu

Hi Thomas,

I tested Peter's patch, It didn't handle qt3d's plugins, qml and examples cases.

Thanks for testing, short answer to your three critics (longer answer for details in an upcoming answer to your patch):

- plugins: the only qt3d plugin is in src/plugins/sceneparsers/assimp and needs the assimp library [1] to build (see the README file for additional info). The assimp library is (not yet?) available as buildroot package...

- qml: what do you mean is missing in my patch?

Quoted 51 lines

- examples: o.k. missing from my patch, but many examples need the assimp plugin at run time... I think best would be if you could submit the example enhancement on top of my patch?

Regards,
Peter

[1] http://assimp.sourceforge.net/

Quoted 40 lines

Best Regards
Jordon Wu

2015-12-01 20:20 GMT+08:00 Thomas Petazzoni <
thomas.petazzoni at free-electrons.com>:

Quoted 33 lines

Dear Jordon Wu,

Quoted 6 lines · Jordon Wu
---
 package/qt5/Config.in        |  1 +
 package/qt5/qt53d/Config.in  | 22 ++++++++++++++++
 package/qt5/qt53d/qt53d.hash |  4 +++
 package/qt5/qt53d/qt53d.mk   | 61

++++++++++++++++++++++++++++++++++++++++++++

Quoted 4 lines
 4 files changed, 88 insertions(+)
 create mode 100755 package/qt5/qt53d/Config.in
 create mode 100755 package/qt5/qt53d/qt53d.hash
 create mode 100755 package/qt5/qt53d/qt53d.mk

For information, we have already a patch pending to add qt5 3d, from Peter Seiderer, which was sent just a few days ago. See:
http://patchwork.ozlabs.org/patch/547753/.

Maybe you can compare your implementation proposed by Peter (in Cc) and see if there's anything to add to Peter's patch ?

Don't hesitate to test Peter's patch and provide your Tested-by if it works for you.

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151204/357c8f19/attachment.html>

#5 lore raw

PATCH 1/1 qt5/qt53d: new package

In reply to Jordon Wu

Hello Jordon,

Quoted 29 lines · Jordon Wu
---
 package/qt5/Config.in        |  1 +
 package/qt5/qt53d/Config.in  | 22 ++++++++++++++++
 package/qt5/qt53d/qt53d.hash |  4 +++
 package/qt5/qt53d/qt53d.mk   | 61 ++++++++++++++++++++++++++++++++++++++++++++
 4 files changed, 88 insertions(+)
 create mode 100755 package/qt5/qt53d/Config.in
 create mode 100755 package/qt5/qt53d/qt53d.hash
 create mode 100755 package/qt5/qt53d/qt53d.mk
package/qt5/Config.in +1 -0
index 22fd0c0..93936ae 100644
@@ -45,6 +45,7 @@ source "package/qt5/qt5webchannel/Config.in"
 source "package/qt5/qt5websockets/Config.in"
 source "package/qt5/qt5x11extras/Config.in"
 source "package/qt5/qt5xmlpatterns/Config.in"
+source "package/qt5/qt53d/Config.in"
 comment "legacy compatibility"
 source "package/qt5/qt5quick1/Config.in"
 source "package/qt5/qt5script/Config.in"
package/qt5/qt53d/Config.in new file +0 -0
new file mode 100755
index 0000000..e3080c9

package/qt5/qt53d/Config.in line 6

Quoted 6 lines
package/qt5/qt53d/Config.in new file +6 -0
@@ -0,0 +1,22 @@
+config BR2_PACKAGE_QT53D
+	bool "qt53d"
+	select BR2_PACKAGE_QT5BASE
+	select BR2_PACKAGE_QT5BASE_GUI
+	select BR2_PACKAGE_QT5DECLARATIVE
+	select BR2_PACKAGE_QT5IMAGEFORMATS

Why select QT5IMAGEFORMATS? Qt3d compiles without it...

Quoted 22 lines
package/qt5/qt53d/Config.in new file +16 -0
+	help
+	  Qt is a cross-platform application and UI framework for
+	  developers using C++.
+
+	  This package corresponds to the qt53d module.
+
+	  http://qt.io
+
+if BR2_PACKAGE_QT53D
+
+config BR2_PACKAGE_QT53D_EXAMPLES
+	bool "Compile and install examples (with code)"
+	help
+	  If unsure, say N.
+
+endif
package/qt5/qt53d/qt53d.hash new file +0 -0
new file mode 100755
index 0000000..bb65454

package/qt5/qt53d/qt53d.hash line 4

Quoted 4 lines
package/qt5/qt53d/qt53d.hash new file +4 -0
@@ -0,0 +1,4 @@
+# Hashes from: http://download.qt.io/official_releases/qt/5.5/5.5.0/submodules/qt3d-opensource-src-5.5.0.tar.xz.mirrorlist
+sha256 bf6c54fbb6f279e9bd6fd67f7faa8e61ac4273baa06a56f8946346adc8c3568e qt3d-opensource-src-5.5.0.tar.xz
+sha1   dc76e83eaafd7c0edccd8557f03fbfd61ea68213                         qt3d-opensource-src-5.5.0.tar.xz
+md5    508c90c3a2a5f37f0f7c2dd696ab10f5                                 qt3d-opensource-src-5.5.0.tar.xz

I think one (strong) hash is enough?

Quoted 11 lines
package/qt5/qt53d/qt53d.mk new file +5 -0
new file mode 100755
index 0000000..8f64107
@@ -0,0 +1,61 @@
+################################################################################
+#
+# qt53d
+#
+################################################################################

package/qt5/qt53d/qt53d.mk line 15

Quoted 10 lines
package/qt5/qt53d/qt53d.mk new file +10 -0
+
+QT53D_VERSION = $(QT5_VERSION)
+QT53D_SITE = $(QT5_SITE)
+QT53D_SOURCE = qt3d-opensource-src-$(QT53D_VERSION).tar.xz
+QT53D_DEPENDENCIES = qt5base qt5declarative qt5imageformats
+QT53D_INSTALL_STAGING = YES
+
+ifeq ($(BR2_PACKAGE_QT5BASE_LICENSE_APPROVED),y)
+QT53D_LICENSE = LGPLv2.1 with exception or LGPLv3
+QT53D_LICENSE_FILES = LICENSE.LGPLv21 LGPL_EXCEPTION.txt LICENSE.LGPLv3

The qt3d source contains only the files LICENSE.LGPLv3 and LICENSE.GPL...

Quoted 19 lines
package/qt5/qt53d/qt53d.mk new file +19 -0
+else
+QT53D_LICENSE = Commercial license
+QT53D_REDISTRIBUTE = NO
+endif
+
+define QT53D_CONFIGURE_CMDS
+	(cd $(@D); $(TARGET_MAKE_ENV) $(HOST_DIR)/usr/bin/qmake)
+endef
+
+define QT53D_BUILD_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
+		sub-src-all $(if $(BR2_PACKAGE_QT53D_EXAMPLES), sub-examples-all)
+endef
+
+define QT53D_INSTALL_STAGING_CMDS
+	$(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
+		sub-src-install_subtargets $(if $(BR2_PACKAGE_QT53D_EXAMPLES), sub-examples-install_subtargets)
+	$(QT5_LA_PRL_FILES_FIXUP)
+endef

package/qt5/qt53d/qt53d.mk line 44

Quoted 10 lines
package/qt5/qt53d/qt53d.mk new file +10 -0
+
+ifeq ($(BR2_STATIC_LIBS),)
+
+define QT53D_INSTALL_TARGET_LIBS
+	cp -dpf $(STAGING_DIR)/usr/lib/libQt53D*.so.* $(TARGET_DIR)/usr/lib
+endef
+
+define QT53D_INSTALL_TARGET_PLUGINS
+	cp -dpfr $(STAGING_DIR)/usr/lib/qt/plugins/* $(TARGET_DIR)/usr/lib/qt/plugins
+endef

Why copy the complete plugins directory? Copying the only qt3d plugin would be enough (but this one is not build because of the missing assimp library in buildroot)...

Quoted 7 lines
package/qt5/qt53d/qt53d.mk new file +7 -0
+
+ifeq ($(BR2_PACKAGE_QT53D_EXAMPLES),y)
+define QT53D_INSTALL_TARGET_EXAMPLES
+	cp -dpfr $(STAGING_DIR)/usr/lib/qt/examples/qt3d $(TARGET_DIR)/usr/lib/qt/examples/
+endef
+endif
+

package/qt5/qt53d/qt53d.mk line 61

Quoted 10 lines
package/qt5/qt53d/qt53d.mk new file +10 -0
+endif
+
+define QT53D_INSTALL_TARGET_CMDS
+	cp -dpfr $(STAGING_DIR)/usr/qml $(TARGET_DIR)/usr
+	$(QT53D_INSTALL_TARGET_LIBS)
+	$(QT53D_INSTALL_TARGET_PLUGINS)
+	$(QT53D_INSTALL_TARGET_EXAMPLES)
+endef
+
+$(eval $(generic-package))

I would prefer a follow up patch on my patch only adding the example configure option (and maybe a second/third one adding the assimp library and enabling the assimp qt3d plugin)...

Regards,
Peter