Skip to contentSkip to conversation

arm: socfpga: arria10: add additional i2c nodes for Arria10

PATCH New dinguyen at opensource.altera.com 4 participants 4 messages Dec 1, 2015 – Dec 2, 2015

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/socfpga architecture
lore
Share & tools
lore

dinguyen at opensource.altera.com

author
#0 lore raw

PATCH 1/1 arm: socfpga: arria10: add additional i2c nodes for Arria10

From: Dinh Nguyen <[email protected]>

Add remaining 3 I2C base addresses for the Arria10.

Signed-off-by Dinh Nguyen <[email protected]>
---
 arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/mach-socfpga/include/mach/base_addr_a10.h +4 -0
index a7056d4..8653dd5 100644
@@ -29,6 +29,10 @@
 #define SOCFPGA_MPUL2_ADDRESS			0xfffff000
 #define SOCFPGA_I2C0_ADDRESS			0xffc02200
 #define SOCFPGA_I2C1_ADDRESS			0xffc02300
+#define SOCFPGA_I2C2_ADDRESS			0xffc02400
+#define SOCFPGA_I2C3_ADDRESS			0xffc02500
+#define SOCFPGA_I2C4_ADDRESS			0xffc02600
+
 
 #define SOCFPGA_ECC_OCRAM_ADDRESS		0xff8c3000
 #define SOCFPGA_UART0_ADDRESS			0xffc02000
Signature · 1 line
2.6.2
#1 lore raw

PATCH 1/1 arm: socfpga: arria10: add additional i2c nodes for Arria10

Quoted 14 lines · dinguyen at opensource.altera.com

From: Dinh Nguyen <[email protected]>

Add remaining 3 I2C base addresses for the Arria10.

Signed-off-by Dinh Nguyen <[email protected]>
---
  arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 4 ++++
  1 file changed, 4 insertions(+)
arch/arm/mach-socfpga/include/mach/base_addr_a10.h +0 -0
index a7056d4..8653dd5 100644

arch/arm/mach-socfpga/include/mach/base_addr_a10.h line 38

Quoted 10 lines
arch/arm/mach-socfpga/include/mach/base_addr_a10.h +4 -0
@@ -29,6 +29,10 @@
  #define SOCFPGA_MPUL2_ADDRESS			0xfffff000
  #define SOCFPGA_I2C0_ADDRESS			0xffc02200
  #define SOCFPGA_I2C1_ADDRESS			0xffc02300
+#define SOCFPGA_I2C2_ADDRESS			0xffc02400
+#define SOCFPGA_I2C3_ADDRESS			0xffc02500
+#define SOCFPGA_I2C4_ADDRESS			0xffc02600
+
 
  #define SOCFPGA_ECC_OCRAM_ADDRESS		0xff8c3000
  #define SOCFPGA_UART0_ADDRESS			0xffc02000

Nitpicking, but there seems to be one empty line too much added above.

Other than this:

Reviewed-by Stefan Roese <[email protected]>

BTW: Is anyone working on DM conversion of this I2C driver? All those macros for the base addresses would not be needed then.

Thanks,
Stefan

#2 lore raw

PATCH 1/1 arm: socfpga: arria10: add additional i2c nodes for Arria10

Quoted 33 lines · Stefan Roese
Quoted 26 lines · dinguyen at opensource.altera.com

From: Dinh Nguyen <[email protected]>

Add remaining 3 I2C base addresses for the Arria10.

Signed-off-by Dinh Nguyen <[email protected]>

---

  arch/arm/mach-socfpga/include/mach/base_addr_a10.h | 4 ++++
  1 file changed, 4 insertions(+)
(quoted diff) +0 -0

b/arch/arm/mach-socfpga/include/mach/base_addr_a10.h index a7056d4..8653dd5 100644

arch/arm/mach-socfpga/include/mach/base_addr_a10.h +4 -0
@@ -29,6 +29,10 @@
 
  #define SOCFPGA_MPUL2_ADDRESS			0xfffff000
  #define SOCFPGA_I2C0_ADDRESS			0xffc02200
  #define SOCFPGA_I2C1_ADDRESS			0xffc02300
 
+#define SOCFPGA_I2C2_ADDRESS			0xffc02400
+#define SOCFPGA_I2C3_ADDRESS			0xffc02500
+#define SOCFPGA_I2C4_ADDRESS			0xffc02600
+
Quoted 2 lines
  #define SOCFPGA_ECC_OCRAM_ADDRESS		0xff8c3000
  #define SOCFPGA_UART0_ADDRESS			0xffc02000

Nitpicking, but there seems to be one empty line too much added above.

Quoted 6 lines

Other than this:

Reviewed-by Stefan Roese <[email protected]>

BTW: Is anyone working on DM conversion of this I2C driver? All those macros for the base addresses would not be needed then.

Fixed and applied.

Best regards,
Marek Vasut