Skip to contentSkip to conversation

usb: add support for generic EHCI devices

PATCH New Alexey Brodkin 3 participants 3 messages Dec 2, 2015

Subsystems (2)
USB USB ehci driver
lore
Share & tools
lore

Alexey Brodkin

author
#0 lore raw

PATCH v4 1/1 usb: add support for generic EHCI devices

From: Alexey Brodkin <[email protected]>

This driver is meant to be used with any EHCI-compatible host controller in case if there's no need for platform-specific glue such as setup of controller or PHY's power mode via GPIOs etc.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Simon Glass <[email protected]>
Cc Marek Vasut <[email protected]>

---

Changes compared to v3:
* Added dependency on DM_USB
* Changed U_BOOT_DRIVER name to unique "ehci_generic"
* Switched "Reviewed-by" tags back to "Cc" because of quite significant changes compared to v1

Changes compared to v2:
* Driver is disabled by default now
* Use uintptr_t instead of uint32_t for "struct ehci_hcor" address calculation

Changes compared to v1:
* Updated commit message with removal of Synopsys board mention
* Cleaned-up ehci_usb_remove()

 drivers/usb/host/Kconfig        |  8 +++++++
 drivers/usb/host/Makefile       |  1 +
 drivers/usb/host/ehci-generic.c | 50 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 59 insertions(+)
 create mode 100644 drivers/usb/host/ehci-generic.c
drivers/usb/host/Kconfig +8 -0
index 2a2bffe..0096a2f 100644
@@ -73,4 +73,12 @@ config USB_EHCI_UNIPHIER
 	---help---
 	  Enables support for the on-chip EHCI controller on UniPhier SoCs.
 
+config USB_EHCI_GENERIC
+	bool "Support for generic EHCI USB controller"
+	depends on OF_CONTROL
+	depends on DM_USB
+	default n
+	---help---
+	  Enables support for generic EHCI controller.
+
 endif
drivers/usb/host/Makefile +1 -0
index f70f38c..b9b4471 100644
@@ -32,6 +32,7 @@ else
 obj-$(CONFIG_USB_EHCI_FSL) += ehci-fsl.o
 endif
 obj-$(CONFIG_USB_EHCI_FARADAY) += ehci-faraday.o
+obj-$(CONFIG_USB_EHCI_GENERIC) += ehci-generic.o
 obj-$(CONFIG_USB_EHCI_EXYNOS) += ehci-exynos.o
 obj-$(CONFIG_USB_EHCI_MXC) += ehci-mxc.o
 obj-$(CONFIG_USB_EHCI_MXS) += ehci-mxs.o
drivers/usb/host/ehci-generic.c new file +50 -0

50 lines not on this page · raw message

Signature · 1 line
2.4.3
Applied
#1 lore raw

PATCH v4 1/1 usb: add support for generic EHCI devices

Quoted 11 lines · Alexey Brodkin

From: Alexey Brodkin <[email protected]>

This driver is meant to be used with any EHCI-compatible host controller in case if there's no need for platform-specific glue such as setup of controller or PHY's power mode via GPIOs etc.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Simon Glass <[email protected]>
Cc Marek Vasut <[email protected]>

Applied, thanks.

Best regards,
Marek Vasut

#2 lore raw

PATCH v4 1/1 usb: add support for generic EHCI devices

In reply to Alexey Brodkin
Quoted 28 lines · Alexey Brodkin

From: Alexey Brodkin <[email protected]>

This driver is meant to be used with any EHCI-compatible host controller in case if there's no need for platform-specific glue such as setup of controller or PHY's power mode via GPIOs etc.

Signed-off-by Alexey Brodkin <[email protected]>
Cc Stephen Warren <[email protected]>
Cc Simon Glass <[email protected]>
Cc Marek Vasut <[email protected]>

---

Changes compared to v3:
* Added dependency on DM_USB
* Changed U_BOOT_DRIVER name to unique "ehci_generic"
* Switched "Reviewed-by" tags back to "Cc" because of quite significant changes compared to v1

Changes compared to v2:
* Driver is disabled by default now
* Use uintptr_t instead of uint32_t for "struct ehci_hcor" address calculation

Changes compared to v1:
* Updated commit message with removal of Synopsys board mention
* Cleaned-up ehci_usb_remove()

Quoted 5 lines
 drivers/usb/host/Kconfig        |  8 +++++++
 drivers/usb/host/Makefile       |  1 +
 drivers/usb/host/ehci-generic.c | 50 +++++++++++++++++++++++++++++++++++++++++
 3 files changed, 59 insertions(+)
 create mode 100644 drivers/usb/host/ehci-generic.c
Reviewed-by Simon Glass <[email protected]>