Skip to contentSkip to conversation

crypto: n2 - Use platform_register/unregister_drivers()

PATCH In review Thierry Reding 3 participants 3 messages Dec 2, 2015 – Dec 4, 2015 Crypto API

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 crypto: n2 - Use platform_register/unregister_drivers()

From: Thierry Reding <[email protected]>

These new helpers simplify implementing multi-driver modules and properly handle failure to register one driver by unregistering all previously registered drivers.

---
 drivers/crypto/n2_core.c | 17 +++++++----------
 1 file changed, 7 insertions(+), 10 deletions(-)
drivers/crypto/n2_core.c +7 -10
index 5450880abb7b..739a786b9f08 100644
@@ -2243,22 +2243,19 @@ static struct platform_driver n2_mau_driver = {
 	.remove		=	n2_mau_remove,
 };
 
+static struct platform_driver * const drivers[] = {
+	&n2_crypto_driver,
+	&n2_mau_driver,
+};
+
 static int __init n2_init(void)
 {
-	int err = platform_driver_register(&n2_crypto_driver);
-
-	if (!err) {
-		err = platform_driver_register(&n2_mau_driver);
-		if (err)
-			platform_driver_unregister(&n2_crypto_driver);
-	}
-	return err;
+	return platform_register_drivers(drivers, ARRAY_SIZE(drivers));
 }
 
 static void __exit n2_exit(void)
 {
-	platform_driver_unregister(&n2_mau_driver);
-	platform_driver_unregister(&n2_crypto_driver);
+	platform_unregister_drivers(drivers, ARRAY_SIZE(drivers));
 }
 
 module_init(n2_init);
Signature · 1 line
2.5.0
maintainer
#2 lore raw
In reply to Thierry Reding
Quoted 7 lines · Thierry Reding

From: Thierry Reding <[email protected]>

These new helpers simplify implementing multi-driver modules and properly handle failure to register one driver by unregistering all previously registered drivers.

Patch applied. Thanks.

Signature · 3 lines
Email: Herbert Xu <[email protected]>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt