Skip to contentSkip to conversation

perf buildid-list: Fix return value of perf buildid-list -k

PATCH Applied Michael Petlan 2 participants 2 messages Dec 2, 2015 – Dec 6, 2015 perf events

lore
Share & tools
lore

Michael Petlan

author
#0 lore raw

PATCH 1/1 perf buildid-list: Fix return value of perf buildid-list -k

The buildid string length is returned by perf buildid-list -k command. Since a non-zero return value means an error, perf buildid-list -k cmd should return 0 when successful instead.

Before:

	# perf buildid-list -k
	39356d74e96e02346fe0ec1f3f162b6c522bac62
	# echo $?
	41

After:

	# perf buildid-list -k
	39356d74e96e02346fe0ec1f3f162b6c522bac62
	# echo $?
	0
Signed-off-by Michael Petlan <[email protected]>
---
 tools/perf/builtin-buildid-list.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-buildid-list.c +1 -1
index 918b4de..6419f57 100644
@@ -110,7 +110,7 @@ int cmd_buildid_list(int argc, const char **argv,
 	setup_pager();
 
 	if (show_kernel)
-		return sysfs__fprintf_build_id(stdout);
+		return !(sysfs__fprintf_build_id(stdout) > 0);
 
 	return perf_session__list_build_ids(force, with_hits);
 }
Applied
#1 lore raw

Em Wed, Dec 02, 2015 at 07:27:51PM +0100, Michael Petlan escreveu:

Quoted 10 lines

The buildid string length is returned by perf buildid-list -k command. Since a non-zero return value means an error, perf buildid-list -k cmd should return 0 when successful instead.

Before:

	# perf buildid-list -k
	39356d74e96e02346fe0ec1f3f162b6c522bac62
	# echo $?
	41

Thanks, applied.

Quoted 26 lines

After:

	# perf buildid-list -k
	39356d74e96e02346fe0ec1f3f162b6c522bac62
	# echo $?
	0
Signed-off-by Michael Petlan <[email protected]>
---
 tools/perf/builtin-buildid-list.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/builtin-buildid-list.c +1 -1
index 918b4de..6419f57 100644
@@ -110,7 +110,7 @@ int cmd_buildid_list(int argc, const char **argv,
 	setup_pager();
 
 	if (show_kernel)
-		return sysfs__fprintf_build_id(stdout);
+		return !(sysfs__fprintf_build_id(stdout) > 0);
 
 	return perf_session__list_build_ids(force, with_hits);
 }