usb: ehci: ohci: fix bool assignments
Subsystems (3)
PATCH 1/1 usb: ehci: ohci: fix bool assignments
When assigning bool use true instead of 1. If declaring it as static and it's false there's no need to initialize it, since static variables are zeroed by default.
Caught by coccinelle.
Signed-off-by Geyslan G. Bem <[email protected]>
--- drivers/usb/host/ehci-hcd.c | 2 +- drivers/usb/host/ohci-hcd.c | 4 ++-- drivers/usb/host/u132-hcd.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)
drivers/usb/host/ehci-hcd.c +1 -1
@@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO);MODULE_PARM_DESC (park,"park setting; 1-3 back-to-back async packets" );/* for flakey hardware, ignore overcurrent indicators */ -static bool ignore_oc =0 ; +static bool ignore_oc;module_param (ignore_oc, bool,S_IRUGO );MODULE_PARM_DESC (ignore_oc,"ignore bogus hardware overcurrent indications" );
drivers/usb/host/ohci-hcd.c +2 -2
@@ -99,13 +99,13 @@ static void io_watchdog_func(unsigned long _ohci);/* Some boards misreport power switching/overcurrent */ -static bool distrust_firmware =1 ; +static bool distrust_firmware = true;module_param (distrust_firmware, bool,0 );MODULE_PARM_DESC (distrust_firmware,"true to distrust firmware power/overcurrent setup" );/* Some boards leave IR set wrongly, since they fail BIOS/SMM handshakes */ -static bool no_handshake =0 ; +static bool no_handshake;module_param (no_handshake, bool,0 );MODULE_PARM_DESC (no_handshake,"true (not default) disables BIOS handshake" );
drivers/usb/host/u132-hcd.c +1 -1
@@ -73,7 +73,7 @@ MODULE_LICENSE("GPL");#define INT_MODULE_PARM (n, v) static int n = v;module_param(n, int, 0444)INT_MODULE_PARM (testing,0 );/* Some boards misreport power switching/overcurrent*/ -static bool distrust_firmware =1 ; +static bool distrust_firmware = true;module_param (distrust_firmware, bool,0 );MODULE_PARM_DESC (distrust_firmware,"true to distrust firmware power/overcurren" "t setup" );
Signature · 1 line
2.6.3
Quoted 7 lines · Geyslan G. Bem
When assigning bool use true instead of 1. If declaring it as static and it's false there's no need to initialize it, since static variables are zeroed by default.
Caught by coccinelle.
Signed-off-by Geyslan G. Bem <[email protected]>
Quoted 55 lines
--- drivers/usb/host/ehci-hcd.c | 2 +- drivers/usb/host/ohci-hcd.c | 4 ++-- drivers/usb/host/u132-hcd.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-)drivers/usb/host/ehci-hcd.c +1
-1@@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO);MODULE_PARM_DESC (park,"park setting; 1-3 back-to-back async packets" );/* for flakey hardware, ignore overcurrent indicators */ -static bool ignore_oc =0 ; +static bool ignore_oc;module_param (ignore_oc, bool,S_IRUGO );MODULE_PARM_DESC (ignore_oc,"ignore bogus hardware overcurrent indications" );drivers/usb/host/ohci-hcd.c +2
-2@@ -99,13 +99,13 @@ static void io_watchdog_func(unsigned long _ohci);/* Some boards misreport power switching/overcurrent */ -static bool distrust_firmware =1 ; +static bool distrust_firmware = true;module_param (distrust_firmware, bool,0 );MODULE_PARM_DESC (distrust_firmware,"true to distrust firmware power/overcurrent setup" );/* Some boards leave IR set wrongly, since they fail BIOS/SMM handshakes */ -static bool no_handshake =0 ; +static bool no_handshake;module_param (no_handshake, bool,0 );MODULE_PARM_DESC (no_handshake,"true (not default) disables BIOS handshake" );drivers/usb/host/u132-hcd.c +1
-2@@ -73,7 +73,7 @@ MODULE_LICENSE("GPL");#define INT_MODULE_PARM (n, v) static int n = v;module_param(n, int, 0444)INT_MODULE_PARM (testing,0 );/* Some boards misreport power switching/overcurrent*/ -static bool distrust_firmware =1 ; +static bool distrust_firmware = true;module_param (distrust_firmware, bool,0 );MODULE_PARM_DESC (distrust_firmware,"true to distrust firmware power/overcurren" "t setup" ); --2.6.3
Signature · 1 line
Peter