Skip to contentSkip to conversation

scsi_dh_alua: Remove stale variables

PATCH Applied Hannes Reinecke 4 participants 4 messages Dec 3, 2015 – Dec 8, 2015 SCSI

lore
Share & tools
lore

Hannes Reinecke

author
#0 lore raw

PATCH 1/1 scsi_dh_alua: Remove stale variables

With commit 83ea0e5e3501 these variables became obsolete, but weren't removed.

Signed-off-by Hannes Reinecke <[email protected]>
---
 drivers/scsi/device_handler/scsi_dh_alua.c | 2 --
 1 file changed, 2 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +0 -2
index f100cbb..5a328bf 100644
@@ -320,8 +320,6 @@ static int alua_check_tpgs(struct scsi_device *sdev)
  */
 static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h)
 {
-	unsigned char *d;
-	unsigned char __rcu *vpd_pg83;
 	int rel_port = -1, group_id;
 
 	group_id = scsi_vpd_tpg_id(sdev, &rel_port);
Signature · 1 line
1.8.5.6
Reviewed-by on v1 1/1
#1 lore raw
Quoted 20 lines · Hannes Reinecke

With commit 83ea0e5e3501 these variables became obsolete, but weren't removed.

Signed-off-by Hannes Reinecke <[email protected]>

---
 drivers/scsi/device_handler/scsi_dh_alua.c | 2 --

 1 file changed, 2 deletions(-)
drivers/scsi/device_handler/scsi_dh_alua.c +0 -2
index f100cbb..5a328bf 100644
@@ -320,8 +320,6 @@ static int alua_check_tpgs(struct scsi_device *sdev)
   */
  static int alua_check_vpd(struct scsi_device *sdev, struct alua_dh_data *h)
  {
-	unsigned char *d;
-	unsigned char __rcu *vpd_pg83;
  	int rel_port = -1, group_id;
Quoted 2 lines


  group_id = scsi_vpd_tpg_id(sdev, &rel_port);

Reviewed-by Johannes Thumshirn <[email protected]>

--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Applied
#3 lore raw
In reply to Hannes Reinecke
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Hannes" == Hannes Reinecke <[email protected]> writes:

Hannes> With commit 83ea0e5e3501 these variables became obsolete, but Hannes> weren't removed.

Applied to 4.5/scsi-queue.

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering