sched: fix build on Atom without SSE4 support
PATCH 1/1 sched: fix build on Atom without SSE4 support
Thanks for the pointers Thomas. Here is a signed-off patch re-submission with some explanation, to the best of my experience.
Irrelevant of the target, the preprocessor #ifdef SSE2 for the grinder_pipe_exists function is inadequate since the __mm_testz_si128 function requires SSE4.1, PTEST instruction described in
https://en.wikipedia.org/wiki/SSE4#SSE4.1 (I do no have better spec reference). I have bumped the preprocessor #ifdef to require SSE4.
The Atom N2600 does not have SSE4, http://ark.intel.com/products/58916,
and so I had trouble building rte_sched with optimized version of grinder_pipe_exists, with following:
error: inlining failed in call to always_inline _mm_testz_si128’:
target specific option mismatch
GCC 4.9 correctly identifies my target as not having SSE4, and with provided patch builds the non-optimized version of grinder_pipe_exists.
--- lib/librte_sched/rte_sched.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
lib/librte_sched/rte_sched.c +3 -3
@@ -55,8 +55,8 @@#ifdef RTE_SCHED_VECTOR #include <rte_vect.h> -#if defined(__SSE2__) -#define SCHED_VECTOR_SSE2 +#if defined(__SSE4__) +#define SCHED_VECTOR_SSE4 #endif #endif
@@ -1672,7 +1672,7 @@ grinder_schedule(struct rte_sched_port *port, uint32_t pos)return 1 ; } -#ifdef SCHED_VECTOR_SSE2 +#ifdef SCHED_VECTOR_SSE4 static inline int grinder_pipe_exists (struct rte_sched_port *port,uint32_t base_pipe)
Signature · 1 line
2.1.0
Thomas Monjalon
Applied2015-12-05 17:27, Mike Sowka:
Quoted 2 lines
Thanks for the pointers Thomas. Here is a signed-off patch re-submission with some explanation, to the best of my experience.
Thanks, it is really well detailed.
It would have been perfect with -v2 --in-reply-to :)
Quoted 12 lines
Irrelevant of the target, the preprocessor #ifdef SSE2 for the
grinder_pipe_existsfunction is inadequate since the__mm_testz_si128function requires SSE4.1, PTEST instruction described in
https://en.wikipedia.org/wiki/SSE4#SSE4.1 (I do no have better spec reference). I have bumped the preprocessor #ifdef to require SSE4.The Atom N2600 does not have SSE4, http://ark.intel.com/products/58916,
and so I had trouble buildingrte_schedwith optimized version ofgrinder_pipe_exists, with following:
error: inlining failed in call toalways_inline_mm_testz_si128’:
target specific option mismatch
Quoted 5 lines
GCC 4.9 correctly identifies my target as not having SSE4, and with provided patch builds the non-optimized version of
grinder_pipe_exists.Signed-off-by Mike Sowka <[email protected]>
Applied, thanks