Skip to contentSkip to conversation

Patch "macvtap: unbreak receiving of gro skb with frag list" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Dec 6, 2015

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

macvtap: unbreak receiving of gro skb with frag list

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
macvtap-unbreak-receiving-of-gro-skb-with-frag-list.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Sat Dec 5 21:06:41 PST 2015

From: Jason Wang <[email protected]>
Date: Fri, 23 Oct 2015 00:57:05 -0400
Subject: macvtap: unbreak receiving of gro skb with frag list

From: Jason Wang <[email protected]>

[ Upstream commit f23d538bc24a83c16127c2eb82c9cf1adc2b5149 ]

We don't have fraglist support in TAP_FEATURES. This will lead software segmentation of gro skb with frag list. Fixes by having frag list support in TAP_FEATURES.

With this patch single session of netperf receiving were restored from about 5Gb/s to about 12Gb/s on mlx4.

Fixes a567dd6252 ("macvtap: simplify usage of tap_features")

---
 drivers/net/macvtap.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/macvtap.c +1 -1
@@ -68,7 +68,7 @@ static const struct proto_ops macvtap_so
 #define TUN_OFFLOADS (NETIF_F_HW_CSUM | NETIF_F_TSO_ECN | NETIF_F_TSO | \
 		      NETIF_F_TSO6 | NETIF_F_UFO)
 #define RX_OFFLOADS (NETIF_F_GRO | NETIF_F_LRO)
-#define TAP_FEATURES (NETIF_F_GSO | NETIF_F_SG)
+#define TAP_FEATURES (NETIF_F_GSO | NETIF_F_SG | NETIF_F_FRAGLIST)
 
 static struct macvlan_dev *macvtap_get_vlan_rcu(const struct net_device *dev)
 {

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/virtio-net-drop-netif_f_fraglist.patch queue-3.14/macvtap-unbreak-receiving-of-gro-skb-with-frag-list.patch