Skip to contentSkip to conversation

ARM: dts: sun7i: Add Itead Ibox support

PATCH New codekipper at gmail.com 2 participants 5 messages Dec 8, 2015 – Dec 14, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ARM: dts: sun7i: Add Itead Ibox support

From: Marcus Cooper <[email protected]>

The Itead Ibox is a multi board device based on the Allwinner A20 SoC. It contains the A20 Itead Core module and a base board for the external interfaces.

The core module comes with 4GB NAND and 1GB DDR RAM.

The base board to which the core board is connected provides 3 USB 2.0 Host ports, 1 USB 2.0 OTG, 1 uSD slot, 10/100 Ethernet port, HDMI, IR receiver, SPDIF and a 32-pin GPIO header. This header expands the features of core board by exposing the VGA pins, audio In/Out pins, SATA, SPI, I2C, UARTS, USB-OTG and power.

As there is an A10 version of the Itead Core Module and at least one other base board to support then this patch partitions the device tree files with some consideration that these variants may be added later.

---
 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/sun7i-a20-itead-core.dtsi    |  83 ++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts     |  98 ++++++++++++++++++++++
 arch/arm/boot/dts/sunxi-itead-core-common.dtsi | 111 +++++++++++++++++++++++++
 4 files changed, 293 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-core.dtsi
 create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
 create mode 100644 arch/arm/boot/dts/sunxi-itead-core-common.dtsi
arch/arm/boot/dts/Makefile +1 -0
index cc7309b..ee8a1dc 100644
@@ -637,6 +637,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \
 	sun7i-a20-cubieboard2.dtb \
 	sun7i-a20-cubietruck.dtb \
 	sun7i-a20-hummingbird.dtb \
+	sun7i-a20-itead-ibox.dtb \
 	sun7i-a20-i12-tvbox.dtb \
 	sun7i-a20-icnova-swac.dtb \
 	sun7i-a20-m3.dtb \
arch/arm/boot/dts/sun7i-a20-itead-core.dtsi new file +83 -0

83 lines not on this page · raw message

arch/arm/boot/dts/sun7i-a20-itead-ibox.dts new file +98 -0

98 lines not on this page · raw message

arch/arm/boot/dts/sunxi-itead-core-common.dtsi new file +111 -0

111 lines not on this page · raw message

Signature · 1 line
2.6.3
#1 lore raw

PATCH 2/2 ARM: dts: sun7i: Add audio codec to Itead Ibox

From: Marcus Cooper <[email protected]>

---
 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/sun7i-a20-itead-ibox.dts +4 -0
index 90ff677..0950b59 100644
@@ -70,6 +70,10 @@
 	status = "okay";
 };
 
+&codec {
+	status = "okay";
+};
+
 &gmac {
 	pinctrl-names = "default";
 	pinctrl-0 = <&gmac_pins_mii_a>;
Signature · 1 line
2.6.3
#2 lore raw

PATCH 2/2 ARM: dts: sun7i: Add audio codec to Itead Ibox

Hi,

Quoted 3 lines · codekipper at gmail.com

From: Marcus Cooper <[email protected]>

A commit log would be nice :)

Quoted 9 lines
---
 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts | 4 ++++
 1 file changed, 4 insertions(+)
arch/arm/boot/dts/sun7i-a20-itead-ibox.dts +0 -0
index 90ff677..0950b59 100644

arch/arm/boot/dts/sun7i-a20-itead-ibox.dts line 76

Quoted 7 lines
arch/arm/boot/dts/sun7i-a20-itead-ibox.dts +4 -0
@@ -70,6 +70,10 @@
 	status = "okay";
 };
 
+&codec {
+	status = "okay";
+};
+

This can be squashed in the previous patch.

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151211/e516a837/attachment.sig>
#3 lore raw

PATCH 1/2 ARM: dts: sun7i: Add Itead Ibox support

In reply to codekipper at gmail.com

Hi,

Quoted 19 lines · codekipper at gmail.com

From: Marcus Cooper <[email protected]>

The Itead Ibox is a multi board device based on the Allwinner A20 SoC. It contains the A20 Itead Core module and a base board for the external interfaces.

The core module comes with 4GB NAND and 1GB DDR RAM.

The base board to which the core board is connected provides 3 USB 2.0 Host ports, 1 USB 2.0 OTG, 1 uSD slot, 10/100 Ethernet port, HDMI, IR receiver, SPDIF and a 32-pin GPIO header. This header expands the features of core board by exposing the VGA pins, audio In/Out pins, SATA, SPI, I2C, UARTS, USB-OTG and power.

As there is an A10 version of the Itead Core Module and at least one other base board to support then this patch partitions the device tree files with some consideration that these variants may be added later.

Quoted 9 lines
---
 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/sun7i-a20-itead-core.dtsi    |  83 ++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts     |  98 ++++++++++++++++++++++
 arch/arm/boot/dts/sunxi-itead-core-common.dtsi | 111 +++++++++++++++++++++++++
 4 files changed, 293 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-core.dtsi
 create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
 create mode 100644 arch/arm/boot/dts/sunxi-itead-core-common.dtsi

So, it looks like you're doing several things in this patch:

1) Create a common DTSI for all itead core variants (sunxi-itead-core-common.dtsi)

2) Create an A20 variant of the itead core
3) Add support for a board using the A20 itead core.

Please make three different patches for this, and converting the A10 itead board would be a good idea too.

Thanks!
Maxime

Signature · 10 lines
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151211/36d132a4/attachment.sig>
#4 lore raw

PATCH 1/2 ARM: dts: sun7i: Add Itead Ibox support

Quoted 34 lines · Maxime Ripard

Hi,

Quoted 19 lines · codekipper at gmail.com

From: Marcus Cooper <[email protected]>

The Itead Ibox is a multi board device based on the Allwinner A20 SoC. It contains the A20 Itead Core module and a base board for the external interfaces.

The core module comes with 4GB NAND and 1GB DDR RAM.

The base board to which the core board is connected provides 3 USB 2.0 Host ports, 1 USB 2.0 OTG, 1 uSD slot, 10/100 Ethernet port, HDMI, IR receiver, SPDIF and a 32-pin GPIO header. This header expands the features of core board by exposing the VGA pins, audio In/Out pins, SATA, SPI, I2C, UARTS, USB-OTG and power.

As there is an A10 version of the Itead Core Module and at least one other base board to support then this patch partitions the device tree files with some consideration that these variants may be added later.

Quoted 9 lines
---
 arch/arm/boot/dts/Makefile                     |   1 +
 arch/arm/boot/dts/sun7i-a20-itead-core.dtsi    |  83 ++++++++++++++++++
 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts     |  98 ++++++++++++++++++++++
 arch/arm/boot/dts/sunxi-itead-core-common.dtsi | 111 +++++++++++++++++++++++++
 4 files changed, 293 insertions(+)
 create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-core.dtsi
 create mode 100644 arch/arm/boot/dts/sun7i-a20-itead-ibox.dts
 create mode 100644 arch/arm/boot/dts/sunxi-itead-core-common.dtsi

So, it looks like you're doing several things in this patch:

Quoted 8 lines

1) Create a common DTSI for all itead core variants (sunxi-itead-core-common.dtsi)

2) Create an A20 variant of the itead core
3) Add support for a board using the A20 itead core.

Please make three different patches for this, and converting the A10 itead board would be a good idea too.

Sure, I will split this into four(or five) patches and include the A10 variant. I haven't got a A10 Itead board but I've seen that someone has just popped on irc asking questions about it. I will ping them to see if they can verify it for me.
CK

Quoted 8 lines

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com