Skip to contentSkip to conversation

sbc8641: drop bogus PHY IRQ entries from DTS file

PATCH Applied Paul Gortmaker 4 participants 10 messages Dec 8, 2015 – Dec 14, 2015

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sbc8641: drop bogus PHY IRQ entries from DTS file

This file was originally cloned off of the MPC8641D-HPCN reference platform, which actually had a PHY IRQ line connected. However this board does not. The bogus entry was largely inert and went undetected until commit 321beec5047af83db90c88114b7e664b156f49fe ("net: phy: Use interrupts when available in NOLINK state") was added to the tree.

With the above commit, the board fails to NFS boot since it sits waiting for a PHY IRQ event that of course never arrives. Removing the bogus entries from the DTS file fixes the issue.

---
 arch/powerpc/boot/dts/sbc8641d.dts | 8 --------
 1 file changed, 8 deletions(-)
arch/powerpc/boot/dts/sbc8641d.dts +0 -8
index 631ede72e226..68f0ed7626bd 100644
@@ -227,23 +227,15 @@
 				reg = <0x520 0x20>;
 
 				phy0: ethernet-phy@1f {
-					interrupt-parent = <&mpic>;
-					interrupts = <10 1>;
 					reg = <0x1f>;
 				};
 				phy1: ethernet-phy@0 {
-					interrupt-parent = <&mpic>;
-					interrupts = <10 1>;
 					reg = <0>;
 				};
 				phy2: ethernet-phy@1 {
-					interrupt-parent = <&mpic>;
-					interrupts = <10 1>;
 					reg = <1>;
 				};
 				phy3: ethernet-phy@2 {
-					interrupt-parent = <&mpic>;
-					interrupts = <10 1>;
 					reg = <2>;
 				};
 				tbi0: tbi-phy@11 {
Signature · 1 line
2.6.1
#1 lore raw
Quoted 10 lines · Paul Gortmaker

This file was originally cloned off of the MPC8641D-HPCN reference platform, which actually had a PHY IRQ line connected. However this board does not. The bogus entry was largely inert and went undetected until commit 321beec5047af83db90c88114b7e664b156f49fe ("net: phy: Use interrupts when available in NOLINK state") was added to the tree.

With the above commit, the board fails to NFS boot since it sits waiting for a PHY IRQ event that of course never arrives. Removing the bogus entries from the DTS file fixes the issue.

Commit 321beec5047a ("net: phy: Use interrupts when available in NOLINK state") went into 4.4-rc2, so this is a fix for 4.4 right?

cheers

#2 lore raw
Quoted 9 lines · [Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file] On 09/12/2015…
Quoted 7 lines · Paul Gortmaker

This file was originally cloned off of the MPC8641D-HPCN reference platform, which actually had a PHY IRQ line connected. However this board does not. The bogus entry was largely inert and went undetected until commit 321beec5047af83db90c88114b7e664b156f49fe ("net: phy: Use interrupts when available in NOLINK state") was added to the tree.

Quoted 6 lines
Quoted 3 lines

With the above commit, the board fails to NFS boot since it sits waiting for a PHY IRQ event that of course never arrives. Removing the bogus entries from the DTS file fixes the issue.

Commit 321beec5047a ("net: phy: Use interrupts when available in NOLINK state") went into 4.4-rc2, so this is a fix for 4.4 right?

Correct, but I'm guessing there are not thousands of users of this board out there, so it probably doesn't matter a whole lot if it goes in the same release where the regression happened or one release later...

P.
--

Quoted 3 lines

cheers

#3 lore raw
Quoted 13 lines · Paul Gortmaker
Quoted 12 lines · [Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file] On 09/12/2015…
Quoted 10 lines · Paul Gortmaker

This file was originally cloned off of the MPC8641D-HPCN reference platform, which actually had a PHY IRQ line connected. However this board does not. The bogus entry was largely inert and went undetected until commit 321beec5047af83db90c88114b7e664b156f49fe ("net: phy: Use interrupts when available in NOLINK state") was added to the tree.

With the above commit, the board fails to NFS boot since it sits waiting for a PHY IRQ event that of course never arrives. Removing the bogus entries from the DTS file fixes the issue.

Quoted 6 lines
Quoted 2 lines

Commit 321beec5047a ("net: phy: Use interrupts when available in NOLINK state") went into 4.4-rc2, so this is a fix for 4.4 right?

Correct, but I'm guessing there are not thousands of users of this board out there, so it probably doesn't matter a whole lot if it goes in the same release where the regression happened or one release later...

OK sure. As it happens I'm just prepping a fixes branch, so I'll drop it in.

cheers

maintainer
#4 lore raw
In reply to Paul Gortmaker

From: Paul Gortmaker <[email protected]>
Date: Tue, 8 Dec 2015 17:44:02 -0500

Quoted 7 lines

This file was originally cloned off of the MPC8641D-HPCN reference platform, which actually had a PHY IRQ line connected. However this board does not. The bogus entry was largely inert and went undetected until commit 321beec5047af83db90c88114b7e664b156f49fe ("net: phy: Use interrupts when available in NOLINK state") was added to the tree.

Quoted 6 lines

With the above commit, the board fails to NFS boot since it sits waiting for a PHY IRQ event that of course never arrives. Removing the bogus entries from the DTS file fixes the issue.

I'm assuming this will go via the powerpc tree, not mine.

#5 lore raw
Quoted 9 lines · David Miller

From: Paul Gortmaker <[email protected]>
Date: Tue, 8 Dec 2015 17:44:02 -0500

Quoted 7 lines

This file was originally cloned off of the MPC8641D-HPCN reference platform, which actually had a PHY IRQ line connected. However this board does not. The bogus entry was largely inert and went undetected until commit 321beec5047af83db90c88114b7e664b156f49fe ("net: phy: Use interrupts when available in NOLINK state") was added to the tree.

Quoted 8 lines
Quoted 6 lines

With the above commit, the board fails to NFS boot since it sits waiting for a PHY IRQ event that of course never arrives. Removing the bogus entries from the DTS file fixes the issue.

I'm assuming this will go via the powerpc tree, not mine.

Yep I'll take it.

cheers

#6 lore raw
In reply to Paul Gortmaker
Quoted 10 lines · Paul Gortmaker

This file was originally cloned off of the MPC8641D-HPCN reference platform, which actually had a PHY IRQ line connected. However this board does not. The bogus entry was largely inert and went undetected until commit 321beec5047af83db90c88114b7e664b156f49fe ("net: phy: Use interrupts when available in NOLINK state") was added to the tree.

With the above commit, the board fails to NFS boot since it sits waiting for a PHY IRQ event that of course never arrives. Removing the bogus entries from the DTS file fixes the issue.

Hi Paul

Originally the interrupt is used for detecting the link has gone down. That would of also been bogus before. Have you tried this? If that is also broken, maybe you need to add a fixes: tag so that it gets back ported?

Andrew

#7 lore raw
Quoted 8 lines · [Re: [PATCH] sbc8641: drop bogus PHY IRQ entries from DTS file] On 09/12/2015…
Quoted 7 lines · Paul Gortmaker

This file was originally cloned off of the MPC8641D-HPCN reference platform, which actually had a PHY IRQ line connected. However this board does not. The bogus entry was largely inert and went undetected until commit 321beec5047af83db90c88114b7e664b156f49fe ("net: phy: Use interrupts when available in NOLINK state") was added to the tree.

Quoted 8 lines
Quoted 3 lines

With the above commit, the board fails to NFS boot since it sits waiting for a PHY IRQ event that of course never arrives. Removing the bogus entries from the DTS file fixes the issue.

Hi Paul

Originally the interrupt is used for detecting the link has gone down. That would of also been bogus before. Have you tried this? If

Haven't tried it, but chances are you are right.

Quoted 2 lines

that is also broken, maybe you need to add a fixes: tag so that it gets back ported?

Nobody noticed in the past ~7 years or so, but I guess I can point Greg at it once it is present in mainline. The main reason I'd Cc'd netdev is just to possibly save anyone else the investigation if they ran into the same issue on a different board -which seems highly probable IMHO.

Paul.
--

Quoted 2 lines

Andrew

#8 lore raw
Quoted 5 lines
Quoted 2 lines

Originally the interrupt is used for detecting the link has gone down. That would of also been bogus before. Have you tried this? If

Haven't tried it, but chances are you are right.

Quoted 7 lines
Quoted 2 lines

that is also broken, maybe you need to add a fixes: tag so that it gets back ported?

Nobody noticed in the past ~7 years or so, but I guess I can point Greg at it once it is present in mainline. The main reason I'd Cc'd netdev is just to possibly save anyone else the investigation if they ran into the same issue on a different board -which seems highly probable IMHO.

Yes, you are probably right about other boards. So this change might be considered as causing a regression. But if they are already broken, because link down does not work, there might be less demand to get the change reverted....

Andrew

reviewer Applied
#9 lore raw
In reply to Paul Gortmaker
Quoted 7 lines · Paul Gortmaker

This file was originally cloned off of the MPC8641D-HPCN reference platform, which actually had a PHY IRQ line connected. However this board does not. The bogus entry was largely inert and went undetected until commit 321beec5047af83db90c88114b7e664b156f49fe ("net: phy: Use interrupts when available in NOLINK state") was added to the tree.

Quoted 6 lines

With the above commit, the board fails to NFS boot since it sits waiting for a PHY IRQ event that of course never arrives. Removing the bogus entries from the DTS file fixes the issue.

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/5b01310cfc8d2302dcca1d8d

cheers