Skip to contentSkip to conversation

mtd: brcmnand: defer to devm_ioremap_resource() for error checking

PATCH In review Brian Norris 2 participants 3 messages Dec 10, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mtd: brcmnand: defer to devm_ioremap_resource() for error checking

devm_ioremap_resource() does error checking on the 'res' argument, so drop the error check in bcm6368_nand.c.

---
Compile tested only

 drivers/mtd/nand/brcmnand/bcm6368_nand.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/mtd/nand/brcmnand/bcm6368_nand.c +0 -3
index 7f5359be24f2..34c91b0e1e69 100644
@@ -105,9 +105,6 @@ static int bcm6368_nand_probe(struct platform_device *pdev)
 
 	res = platform_get_resource_byname(pdev,
 		IORESOURCE_MEM, "nand-int-base");
-	if (!res)
-		return -EINVAL;
-
 	priv->base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
Signature · 1 line
2.6.0.rc2.230.g3dd15c0
Tested-by on v1 1/1
#1 lore raw
Quoted 5 lines · Brian Norris

devm_ioremap_resource() does error checking on the 'res' argument, so drop the error check in bcm6368_nand.c.

Quoted 21 lines

---
Compile tested only

 drivers/mtd/nand/brcmnand/bcm6368_nand.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/mtd/nand/brcmnand/bcm6368_nand.c +0 -3
index 7f5359be24f2..34c91b0e1e69 100644
@@ -105,9 +105,6 @@ static int bcm6368_nand_probe(struct platform_device *pdev)
 
 	res = platform_get_resource_byname(pdev,
 		IORESOURCE_MEM, "nand-int-base");
-	if (!res)
-		return -EINVAL;
-
 	priv->base = devm_ioremap_resource(dev, res);
 	if (IS_ERR(priv->base))
 		return PTR_ERR(priv->base);
Signature · 1 line
Simon Arlott