Skip to contentSkip to conversation

arm64: dts: qcom: few i2c fixes

PATCH New Srinivas Kandagatla 1 participant 3 messages Dec 11, 2015

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover arm64: dts: qcom: few i2c fixes

Hi Andy,

Here are two i2c dt fixes which I have been using for long time on Landing team tree.

Can you please consider fixes for v4.5.

Thanks,
srini

Srinivas Kandagatla (2):
arm64: dts: fix the i2c aliasing to match to schematics.
arm64: dts: set the default i2c pin drive strength to 16mA

 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi  | 3 +++
 arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/2 arm64: dts: fix the i2c aliasing to match to schematics.

This patch fixes the i2c bus number aliasing so that it matches with the schematics bus naming.

Without this patch the user might would get bus numbers depending on the order the devices are probed.

---
 arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 3 +++
 1 file changed, 3 insertions(+)
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi +3 -0
index 6b8abbe..6f19956 100644
@@ -20,6 +20,9 @@
 	aliases {
 		serial0 = &blsp1_uart2;
 		serial1 = &blsp1_uart1;
+		i2c0	= &blsp_i2c2;
+		i2c1	= &blsp_i2c6;
+		i2c3	= &blsp_i2c4;
 	};
 
 	chosen {
Signature · 1 line
1.9.1
#2 lore raw

PATCH 2/2 arm64: dts: set the default i2c pin drive strength to 16mA

In reply to Srinivas Kandagatla

2mA drive strength is not enough when we connect multiple i2c devices on the bus with different pull up resistors.

This issue was detected when multiple i2c devices connected on the other side of level shifters on Linaro sensor board. Maxing up to 16mA made i2c much stable.

---
 arch/arm64/boot/dts/qcom/msm8916-pins.dtsi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/qcom/msm8916-pins.dtsi +3 -3
index 49ec55a..1991af7 100644
@@ -272,7 +272,7 @@
 		};
 		pinconf {
 			pins = "gpio6", "gpio7";
-			drive-strength = <2>;
+			drive-strength = <16>;
 			bias-disable = <0>;
 		};
 	};
@@ -296,7 +296,7 @@
 		};
 		pinconf {
 			pins = "gpio14", "gpio15";
-			drive-strength = <2>;
+			drive-strength = <16>;
 			bias-disable = <0>;
 		};
 	};
@@ -320,7 +320,7 @@
 		};
 		pinconf {
 			pins = "gpio22", "gpio23";
-			drive-strength = <2>;
+			drive-strength = <16>;
 			bias-disable = <0>;
 		};
 	};
Signature · 1 line
1.9.1