Skip to contentSkip to conversation

ARM: multi_v7_defconfig: Enable more OMAP family platforms

PATCH Applied Nishanth Menon 3 participants 13 messages Dec 14, 2015 – Dec 26, 2015 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

v2 cover ARM: multi_v7_defconfig: Enable more OMAP family platforms

Hi,

V1: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-April/336582.html
V2: is just a rebase of the series on top ov v4.4-rc5

Ran into all kinds of test farm issues recently, hence the delay in repost.. I still seem to have a few more quirks to resolve in the board test farm.. but as far as I can see, things look better after the series.

Series baseline: v4.4-rc5 (applies on next-20151214 as well)

Plain v4.4-rc5
1: am335x-evm: BOOT: PASS: err=5 warn=24: http://pastebin.ubuntu.com/14008259/
2: am335x-sk: BOOT: PASS: err=3 warn=20: http://pastebin.ubuntu.com/14008260/
3: am3517-evm: BOOT: PASS: alert=1 err=12 warn=45: http://pastebin.ubuntu.com/14008261/
4: am37x-evm: BOOT: PASS: err=5 warn=20: http://pastebin.ubuntu.com/14008263/
5: am437x-sk: BOOT: FAIL: http://pastebin.ubuntu.com/14008265/
6: am43xx-epos: BOOT: PASS: err=7 warn=20: http://pastebin.ubuntu.com/14008266/
7: am43xx-gpevm: BOOT: PASS: err=10 warn=25: http://pastebin.ubuntu.com/14008267/
8: BeagleBoard-X15: BOOT: PASS: http://pastebin.ubuntu.com/14008268/
9: BeagleBoard-XM: BOOT: PASS: err=15 warn=10: http://pastebin.ubuntu.com/14008270/
10: beagleboard-vanilla: BOOT: PASS: err=8 warn=12: http://pastebin.ubuntu.com/14008271/
11: beaglebone-black: BOOT: PASS: err=4 warn=13: http://pastebin.ubuntu.com/14008272/

12:          beaglebone: BOOT: FAIL: http://pastebin.ubuntu.com/14008273/
13:          craneboard: BOOT: PASS: err=15 warn=45: http://pastebin.ubuntu.com/14008275/
14:          dra72x-evm: BOOT: PASS: err=5 warn=11: http://pastebin.ubuntu.com/14008276/
15:          dra7xx-evm: BOOT: PASS: err=4 warn=9: http://pastebin.ubuntu.com/14008277/

16: ldp3430: BOOT: FAIL: http://pastebin.ubuntu.com/14008278/
17: n900: BOOT: PASS: err=5 warn=13: http://pastebin.ubuntu.com/14008280/
18: omap5-evm: BOOT: PASS: err=11 warn=16: http://pastebin.ubuntu.com/14008281/
19: pandaboard-es: BOOT: PASS: err=17 warn=24: http://pastebin.ubuntu.com/14008282/
20: pandaboard-vanilla: BOOT: PASS: err=17 warn=23: http://pastebin.ubuntu.com/14008283/
21: sdp3430: BOOT: PASS: err=17 warn=14: http://pastebin.ubuntu.com/14008284/
22: sdp4430: BOOT: PASS: err=20 warn=27: http://pastebin.ubuntu.com/14008285/
TOTAL = 22 boards, Booted Boards = 19, No Boot boards = 3

v4.4-rc5 + this series:
1: am335x-evm: BOOT: PASS: err=5 warn=22: http://pastebin.ubuntu.com/14010157/
2: am3517-evm: BOOT: PASS: alert=1 err=12 warn=45: http://pastebin.ubuntu.com/14010160/
3: am37x-evm: BOOT: PASS: err=5 warn=20: http://pastebin.ubuntu.com/14010161/
4: am437x-sk: BOOT: PASS: err=10 warn=20: http://pastebin.ubuntu.com/14010162/
5: am43xx-epos: BOOT: PASS: err=7 warn=20: http://pastebin.ubuntu.com/14010166/
6: am43xx-gpevm: BOOT: PASS: err=10 warn=25: http://pastebin.ubuntu.com/14010168/
7: BeagleBoard-X15: BOOT: PASS: err=4 warn=13: http://pastebin.ubuntu.com/14010170/
8: BeagleBoard-XM: BOOT: PASS: err=15 warn=10: http://pastebin.ubuntu.com/14010171/
9: beagleboard-vanilla: BOOT: PASS: err=8 warn=12: http://pastebin.ubuntu.com/14010172/
10: beaglebone-black: BOOT: PASS: err=4 warn=15: http://pastebin.ubuntu.com/14010173/

11:          beaglebone: BOOT: PASS: err=4 warn=11: http://pastebin.ubuntu.com/14010176/
12:          craneboard: BOOT: FAIL: http://pastebin.ubuntu.com/14010179/
13:          dra72x-evm: BOOT: PASS: err=5 warn=11: http://pastebin.ubuntu.com/14010180/
14:          dra7xx-evm: BOOT: PASS: err=4 warn=15: http://pastebin.ubuntu.com/14010183/

15: ldp3430: BOOT: FAIL: http://pastebin.ubuntu.com/14010184/
16: n900: BOOT: PASS: err=5 warn=13: http://pastebin.ubuntu.com/14010185/
17: omap5-evm: BOOT: PASS: err=11 warn=16: http://pastebin.ubuntu.com/14010188/
18: pandaboard-es: BOOT: PASS: err=17 warn=24: http://pastebin.ubuntu.com/14010189/
19: pandaboard-vanilla: BOOT: PASS: err=17 warn=22: http://pastebin.ubuntu.com/14010191/
20: sdp3430: BOOT: PASS: err=17 warn=14: http://pastebin.ubuntu.com/14010192/
21: sdp4430: BOOT: PASS: err=20 warn=27: http://pastebin.ubuntu.com/14010193/
TOTAL = 21 boards, Booted Boards = 19, No Boot boards = 2

Craneboard failure in the log was traced to older arago filesystem used -> need to update all boards soonish..

LDP is more interesting failure: http://pastebin.ubuntu.com/14010254/ change helps LDP3430 bootup. It does look like a driver bug of some sort at this point in time..

Nishanth Menon (3):
ARM: multi_v7_defconfig: Enable beaglebone PMIC TPS65217
ARM: multi_v7_defconfig: Enable AM437x PMIC TPS65218
ARM: multi_v7_defconfig: Enable generic SoC internal OMAP regulators

 arch/arm/configs/multi_v7_defconfig |    5 +++++
 1 file changed, 5 insertions(+)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH v2 1/3 ARM: multi_v7_defconfig: Enable beaglebone PMIC TPS65217

Enable PMIC for beaglebone similar to commit 7a5c6065669c ("ARM:
OMAP2+: omap2plus_defconfig: Add tps65217 support") - this allows multi_v7_defconfig to boot up on older beaglebone platforms.

---
 arch/arm/configs/multi_v7_defconfig |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/multi_v7_defconfig +2 -0
index 69a22fdb52a5..a8b6de1d6d9a 100644
@@ -411,6 +411,7 @@ CONFIG_MFD_SEC_CORE=y
 CONFIG_MFD_STMPE=y
 CONFIG_MFD_PALMAS=y
 CONFIG_MFD_TPS65090=y
+CONFIG_MFD_TPS65217=y
 CONFIG_MFD_TPS6586X=y
 CONFIG_MFD_TPS65910=y
 CONFIG_REGULATOR_AB8500=y
@@ -441,6 +442,7 @@ CONFIG_REGULATOR_S5M8767=y
 CONFIG_REGULATOR_TPS51632=y
 CONFIG_REGULATOR_TPS62360=y
 CONFIG_REGULATOR_TPS65090=y
+CONFIG_REGULATOR_TPS65217=y
 CONFIG_REGULATOR_TPS6586X=y
 CONFIG_REGULATOR_TPS65910=y
 CONFIG_REGULATOR_TWL4030=y
Signature · 1 line
1.7.9.5
#2 lore raw

Re: [PATCH V2 1/3] ARM: multi_v7_defconfig: Enable beaglebone PMIC TPS65217

Hi,

Quoted 3 lines · Nishanth Menon

Enable PMIC for beaglebone similar to commit 7a5c6065669c ("ARM:
OMAP2+: omap2plus_defconfig: Add tps65217 support") - this allows multi_v7_defconfig to boot up on older beaglebone platforms.

A similar one -

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/384289.html

your v1 was earlier than the above, so mine should > /dev/null.

Seems Arnd wants multi_v7_defconfig changes thr' submaintainers rather than directly (which I initially thought was supposed to be done)

Regards
afzal

#3 lore raw

Re: [PATCH V2 1/3] ARM: multi_v7_defconfig: Enable beaglebone PMIC TPS65217

Quoted 8 lines · Afzal Mohammed

Hi,

Quoted 3 lines · Nishanth Menon

Enable PMIC for beaglebone similar to commit 7a5c6065669c ("ARM:
OMAP2+: omap2plus_defconfig: Add tps65217 support") - this allows multi_v7_defconfig to boot up on older beaglebone platforms.

Quoted 5 lines

A similar one -

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/384289.html

your v1 was earlier than the above, so mine should > /dev/null.

If you'd like to, please reply back on original patch dropping your patch.. or if queued, I can drop mine (I dont see it on linux-next yet).

Quoted 3 lines

Seems Arnd wants multi_v7_defconfig changes thr' submaintainers rather than directly (which I initially thought was supposed to be done)

Just following what
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/376637.html
was told. I am ok as all the submaintainers should be in CC of this patch.

If you are ok with these patches, will appreciate to get a acked-by, if you dont mind.

Signature · 3 lines
---
Regards,
Nishanth Menon
#4 lore raw

Re: [PATCH V2 1/3] ARM: multi_v7_defconfig: Enable beaglebone PMIC TPS65217

Hi,

Quoted 9 lines · Nishanth Menon
Quoted 8 lines · Afzal Mohammed
Quoted 3 lines · Nishanth Menon

Enable PMIC for beaglebone similar to commit 7a5c6065669c ("ARM:
OMAP2+: omap2plus_defconfig: Add tps65217 support") - this allows multi_v7_defconfig to boot up on older beaglebone platforms.

A similar one -

Quoted 7 lines
Quoted 3 lines

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/384289.html

your v1 was earlier than the above, so mine should > /dev/null.

If you'd like to, please reply back on original patch dropping your patch.. or if queued, I can drop mine (I dont see it on linux-next yet).

That patch didn't get a reply at all, hence assuming that it won't be picked & don't want to create a noise on that silent thread ;), but if it gets applied, i will fight against my patch :)

Quoted 7 lines
Quoted 2 lines

Seems Arnd wants multi_v7_defconfig changes thr' submaintainers rather than directly (which I initially thought was supposed to be done)

Just following what
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-October/376637.html
was told. I am ok as all the submaintainers should be in CC of this patch.

Hmm..,

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/393016.html

but looks like Arnd applied it later.

Quoted 2 lines

If you are ok with these patches, will appreciate to get a acked-by, if you dont mind.

Changelog refers to old beagle bone's, does new ones have a different PMIC ?, i only have white bones ;)

Regards
afzal

#5 lore raw

Re: [PATCH V2 1/3] ARM: multi_v7_defconfig: Enable beaglebone PMIC TPS65217

On 12/16/2015 07:45 AM, Afzal Mohammed wrote:
[...]

Quoted 2 lines

Changelog refers to old beagle bone's, does new ones have a different PMIC ?, i only have white bones ;)

Blacks seem to boot (see cover-letter) - could be because of default configuration of tps65217. From my test log:
11: beaglebone-black: BOOT: PASS: err=4 warn=13:
http://pastebin.ubuntu.com/14008272/

Signature · 2 lines
Regards,
Nishanth Menon
#6 lore raw

Re: [PATCH V2 1/3] ARM: multi_v7_defconfig: Enable beaglebone PMIC TPS65217

Hi,

Quoted 9 lines · Nishanth Menon
Quoted 2 lines · Afzal Mohammed

Changelog refers to old beagle bone's, does new ones have a different PMIC ?, i only have white bones ;)

Blacks seem to boot (see cover-letter) - could be because of default configuration of tps65217. From my test log:
11: beaglebone-black: BOOT: PASS: err=4 warn=13:
http://pastebin.ubuntu.com/14008272/

But default is same for both right ? and since both uses same PMIC, something else - due to Uboot handling it differently ?

Regards
afzal

#7 lore raw

Re: [PATCH V2 1/3] ARM: multi_v7_defconfig: Enable beaglebone PMIC TPS65217

In reply to Afzal Mohammed
Quoted 16 lines · Afzal Mohammed

Hi,

Quoted 13 lines · Nishanth Menon
Quoted 11 lines · Afzal Mohammed
Quoted 3 lines · Nishanth Menon

Enable PMIC for beaglebone similar to commit 7a5c6065669c ("ARM:
OMAP2+: omap2plus_defconfig: Add tps65217 support") - this allows multi_v7_defconfig to boot up on older beaglebone platforms.

A similar one -

http://lists.infradead.org/pipermail/linux-arm-kernel/2015-November/384289.html

your v1 was earlier than the above, so mine should > /dev/null.

Quoted 7 lines
Quoted 3 lines

If you'd like to, please reply back on original patch dropping your patch.. or if queued, I can drop mine (I dont see it on linux-next yet).

That patch didn't get a reply at all, hence assuming that it won't be picked & don't want to create a noise on that silent thread ;), but if it gets applied, i will fight against my patch :)

As mentioned in the earlier reply, don't assume a patch that hasn't been applied yet won't be -- please follow up with a redaction of it if that's what you want. Since I go through my mail folder in chronological order, I come across your patch first and will apply it when I get to it.

Anyway, not a big deal since the contents is the same.

-Olof

#8 lore raw

Re: [PATCH V2 1/3] ARM: multi_v7_defconfig: Enable beaglebone PMIC TPS65217

Hi,

Quoted 10 lines · Olof Johansson
Quoted 3 lines · Afzal Mohammed

That patch didn't get a reply at all, hence assuming that it won't be picked & don't want to create a noise on that silent thread ;), but if it gets applied, i will fight against my patch :)

As mentioned in the earlier reply, don't assume a patch that hasn't been applied yet won't be -- please follow up with a redaction of it if that's what you want. Since I go through my mail folder in chronological order, I come across your patch first and will apply it when I get to it.

i will keep this in mind the next time.

Another reason that made me hesitant to ping either in positive of negative was that it was a trivial one.

Thanks Olof.

Regards
afzal

Quoted 2 lines

Anyway, not a big deal since the contents is the same.

#9 lore raw

PATCH v2 2/3 ARM: multi_v7_defconfig: Enable AM437x PMIC TPS65218

In reply to Nishanth Menon

Enable PMIC for AM437x platforms such as AM437x-sk similar to commit a186cf10da84 ("ARM: omap2plus_defconfig: enable TPS65218 configs"). This allows multi_v7_defconfig to boot up on AM437x-sk platform.

---
 arch/arm/configs/multi_v7_defconfig |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/multi_v7_defconfig +2 -0
index a8b6de1d6d9a..f8b61b7abc41 100644
@@ -412,6 +412,7 @@ CONFIG_MFD_STMPE=y
 CONFIG_MFD_PALMAS=y
 CONFIG_MFD_TPS65090=y
 CONFIG_MFD_TPS65217=y
+CONFIG_MFD_TPS65218=y
 CONFIG_MFD_TPS6586X=y
 CONFIG_MFD_TPS65910=y
 CONFIG_REGULATOR_AB8500=y
@@ -443,6 +444,7 @@ CONFIG_REGULATOR_TPS51632=y
 CONFIG_REGULATOR_TPS62360=y
 CONFIG_REGULATOR_TPS65090=y
 CONFIG_REGULATOR_TPS65217=y
+CONFIG_REGULATOR_TPS65218=y
 CONFIG_REGULATOR_TPS6586X=y
 CONFIG_REGULATOR_TPS65910=y
 CONFIG_REGULATOR_TWL4030=y
Signature · 1 line
1.7.9.5
#10 lore raw

Re: [PATCH V2 2/3] ARM: multi_v7_defconfig: Enable AM437x PMIC TPS65218

Quoted 5 lines · Nishanth Menon

Enable PMIC for AM437x platforms such as AM437x-sk similar to commit a186cf10da84 ("ARM: omap2plus_defconfig: enable TPS65218 configs"). This allows multi_v7_defconfig to boot up on AM437x-sk platform.

Applied, thanks.

-Olof

#11 lore raw

PATCH v2 3/3 ARM: multi_v7_defconfig: Enable generic SoC internal OMAP regulators

In reply to Nishanth Menon

ABB and PBIAS are internal LDO control regulators that are needed for maintaining proper functionality of OMAP architecture SoCs. Enable the same. PBIAS is already enabled, so just enable ABB regulator as well.

---
 arch/arm/configs/multi_v7_defconfig |    1 +
 1 file changed, 1 insertion(+)
arch/arm/configs/multi_v7_defconfig +1 -0
index f8b61b7abc41..eba026af7f90 100644
@@ -440,6 +440,7 @@ CONFIG_REGULATOR_QCOM_RPM=y
 CONFIG_REGULATOR_QCOM_SMD_RPM=y
 CONFIG_REGULATOR_S2MPS11=y
 CONFIG_REGULATOR_S5M8767=y
+CONFIG_REGULATOR_TI_ABB=y
 CONFIG_REGULATOR_TPS51632=y
 CONFIG_REGULATOR_TPS62360=y
 CONFIG_REGULATOR_TPS65090=y
Signature · 1 line
1.7.9.5
#12 lore raw

Re: [PATCH V2 3/3] ARM: multi_v7_defconfig: Enable generic SoC internal OMAP regulators

Quoted 5 lines · Nishanth Menon

ABB and PBIAS are internal LDO control regulators that are needed for maintaining proper functionality of OMAP architecture SoCs. Enable the same. PBIAS is already enabled, so just enable ABB regulator as well.

Applied, thanks.

-Olof