ixgbe: restore imissed stat counter
PATCH 1/1 ixgbe: restore imissed stat counter
This counter was left unmodified. Restore it in ixgbe_dev_stats_get.
The ierrors counter still includes imissed for ixgbe. This behaviour is not consistent amongst all drivers. Another patch may be needed to unify the meaning of the ierrors counter.
--- drivers/net/ixgbe/ixgbe_ethdev.c | 1 + 1 file changed, 1 insertion(+)
drivers/net/ixgbe/ixgbe_ethdev.c +1 -0
@@ -2546,6 +2546,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) }/* Rx Errors */ + stats->imissed = total_missed_rx; stats->ierrors = hw_stats->crcerrs + hw_stats->mspdc + hw_stats->rlec +
Signature · 1 line
2.1.4
Quoted 5 lines
From: Robin Jarry [mailto:[email protected]]
Subject: [PATCH] ixgbe: restore imissed stat counterThis counter was left unmodified. Restore it in
ixgbe_dev_stats_get.
Quoted 7 lines
The ierrors counter still includes imissed for ixgbe. This behaviour is not consistent amongst all drivers. Another patch may be needed to unify the meaning of the ierrors counter.
Fixes 5e50ad1c1b63 ("ixgbe: add specific stats")Signed-off-by Robin Jarry <[email protected]>
There is work to be done to allow easier distinction between drops due to the host, and errors due to bad packets.
Until that work is done, write the dropped packet count to imissed, so:
Thomas Monjalon
Applied2015-12-15 16:41, Van Haaren, Harry:
Quoted 11 lines
Quoted 11 lines
From: Robin Jarry [mailto:[email protected]]
Subject: [PATCH] ixgbe: restore imissed stat counterThis counter was left unmodified. Restore it in
ixgbe_dev_stats_get.The ierrors counter still includes imissed for ixgbe. This behaviour is not consistent amongst all drivers. Another patch may be needed to unify the meaning of the ierrors counter.
Fixes 5e50ad1c1b63 ("ixgbe: add specific stats")
Quoted 8 lines
Quoted 1 line
Signed-off-by Robin Jarry <[email protected]>There is work to be done to allow easier distinction between drops due to the host, and errors due to bad packets.
Until that work is done, write the dropped packet count to imissed, so:
Acked-by Harry van Haaren <[email protected]>
Applied, thanks