Skip to contentSkip to conversation

ixgbe: restore imissed stat counter

PATCH Applied Robin Jarry 3 participants 3 messages Dec 15, 2015 Network drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ixgbe: restore imissed stat counter

This counter was left unmodified. Restore it in ixgbe_dev_stats_get.

The ierrors counter still includes imissed for ixgbe. This behaviour is not consistent amongst all drivers. Another patch may be needed to unify the meaning of the ierrors counter.

Fixes 5e50ad1c1b63 ("ixgbe: add specific stats")
---
 drivers/net/ixgbe/ixgbe_ethdev.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/ixgbe/ixgbe_ethdev.c +1 -0
index 1b6cd8efe815..4c4c6dfb1622 100644
@@ -2546,6 +2546,7 @@ ixgbe_dev_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
 	}
 
 	/* Rx Errors */
+	stats->imissed  = total_missed_rx;
 	stats->ierrors  = hw_stats->crcerrs +
 	                  hw_stats->mspdc +
 	                  hw_stats->rlec +
Signature · 1 line
2.1.4
Acked-by on v1 1/1
#1 lore raw
Quoted 5 lines

From: Robin Jarry [mailto:[email protected]]
Subject: [PATCH] ixgbe: restore imissed stat counter

This counter was left unmodified. Restore it in ixgbe_dev_stats_get.

Quoted 7 lines

The ierrors counter still includes imissed for ixgbe. This behaviour is not consistent amongst all drivers. Another patch may be needed to unify the meaning of the ierrors counter.

Fixes 5e50ad1c1b63 ("ixgbe: add specific stats")

There is work to be done to allow easier distinction between drops due to the host, and errors due to bad packets.

Until that work is done, write the dropped packet count to imissed, so:

#2 lore raw

2015-12-15 16:41, Van Haaren, Harry:

Quoted 11 lines
Quoted 11 lines

From: Robin Jarry [mailto:[email protected]]
Subject: [PATCH] ixgbe: restore imissed stat counter

This counter was left unmodified. Restore it in ixgbe_dev_stats_get.

The ierrors counter still includes imissed for ixgbe. This behaviour is not consistent amongst all drivers. Another patch may be needed to unify the meaning of the ierrors counter.

Fixes 5e50ad1c1b63 ("ixgbe: add specific stats")
Quoted 8 lines
Quoted 1 line

There is work to be done to allow easier distinction between drops due to the host, and errors due to bad packets.

Until that work is done, write the dropped packet count to imissed, so:

Applied, thanks