netfilter: nf_tables: release objects on netns destruction
Subsystems (3)
Pablo Neira Ayuso
maintainerPATCH v3 1/5 netfilter: nf_tables: release objects on netns destruction
We have to release the existing objects on netns removal otherwise we leak them. Chains are unregistered in first place to make sure no packets are walking on our rules and sets anymore.
The object release happens by when we unregister the family via nft_release_afinfo() which is called from nft_unregister_afinfo() from the corresponding __net_exit path in every family.
Reported-by Patrick McHardy <[email protected]>
Signed-off-by Pablo Neira Ayuso <[email protected]>
---
v3: Release objects from nft_unregister_afinfo() path.
include/net/netfilter/nf_tables.h | 2 +- net/bridge/netfilter/nf_tables_bridge.c | 2 +- net/ipv4/netfilter/nf_tables_arp.c | 2 +- net/ipv4/netfilter/nf_tables_ipv4.c | 2 +- net/ipv6/netfilter/nf_tables_ipv6.c | 2 +- net/netfilter/nf_tables_api.c | 47 +++++++++++++++++++++++++++++++-- net/netfilter/nf_tables_inet.c | 2 +- net/netfilter/nf_tables_netdev.c | 2 +- 8 files changed, 52 insertions(+), 9 deletions(-)
include/net/netfilter/nf_tables.h +1 -1
@@ -882,7 +882,7 @@ struct nft_af_info { };int nft_register_afinfo (struct net *,struct nft_af_info *); -void nft_unregister_afinfo (struct nft_af_info *); +void nft_unregister_afinfo (struct net *,struct nft_af_info *);int nft_register_chain_type (const struct nf_chain_type *);void nft_unregister_chain_type (const struct nf_chain_type *);
net/bridge/netfilter/nf_tables_bridge.c +1 -1
@@ -141,7 +141,7 @@ err:static void nf_tables_bridge_exit_net (struct net *net) { -nft_unregister_afinfo (net->nft.bridge); +nft_unregister_afinfo (net, net->nft.bridge);kfree (net->nft.bridge); }
net/ipv4/netfilter/nf_tables_arp.c +1 -1
@@ -57,7 +57,7 @@ err:static void nf_tables_arp_exit_net (struct net *net) { -nft_unregister_afinfo (net->nft.arp); +nft_unregister_afinfo (net, net->nft.arp);kfree (net->nft.arp); }
net/ipv4/netfilter/nf_tables_ipv4.c +1 -1
@@ -78,7 +78,7 @@ err:static void nf_tables_ipv4_exit_net (struct net *net) { -nft_unregister_afinfo (net->nft.ipv4); +nft_unregister_afinfo (net, net->nft.ipv4);kfree (net->nft.ipv4); }
net/ipv6/netfilter/nf_tables_ipv6.c +1 -1
@@ -77,7 +77,7 @@ err:static void nf_tables_ipv6_exit_net (struct net *net) { -nft_unregister_afinfo (net->nft.ipv6); +nft_unregister_afinfo (net, net->nft.ipv6);kfree (net->nft.ipv6); }
net/netfilter/nf_tables_api.c +45 -2
73 lines not on this page · raw message
net/netfilter/nf_tables_inet.c +1 -1
@@ -57,7 +57,7 @@ err: static void __net_exit nf_tables_inet_exit_net(struct net *net) { -nft_unregister_afinfo (net->nft.inet); +nft_unregister_afinfo (net, net->nft.inet);kfree (net->nft.inet); }
net/netfilter/nf_tables_netdev.c +1 -1
@@ -139,7 +139,7 @@ err:static void nf_tables_netdev_exit_net (struct net *net) { -nft_unregister_afinfo (net->nft.netdev); +nft_unregister_afinfo (net, net->nft.netdev);kfree (net->nft.netdev); }
Signature · 1 line
2.1.4