Skip to contentSkip to conversation

net: usb: cdc_ncm: Adding support for two new Dell devices

PATCH Superseded Daniele Palmas 4 participants 7 messages Dec 16, 2015 – Dec 17, 2015 2 messages not in the archive

Subsystems (4)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover net: usb: cdc_ncm: Adding support for two new Dell devices

This patch series add support in the cdc_ncm driver for two devices based on the same platform, that are different only for carrier customization.

The devices do not have ARP capabilities.

Daniele Palmas (2):
net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband
Card
net: usb: cdc_ncm: Adding Dell DW5813 LTE AT&T Mobile Broadband Card

 drivers/net/usb/cdc_ncm.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)
Signature · 1 line
1.9.1

A message that is not in the archive (sent off-list or not yet received): 1450258765-11215-1-git-send-email-dnlplm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

PATCH 2/2 net: usb: cdc_ncm: Adding Dell DW5813 LTE AT&T Mobile Broadband Card

Dell DW5813 is a mobile broadband card with no ARP capabilities: the patch makes this device to use wwan_noarp_info struct

---
 drivers/net/usb/cdc_ncm.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/usb/cdc_ncm.c +7 -0
index 2c0257a..8e971a2 100644
@@ -1600,6 +1600,13 @@ static const struct usb_device_id cdc_devs[] = {
 	  .driver_info = (unsigned long)&wwan_noarp_info,
 	},
 
+	/* DW5813 LTE AT&T Mobile Broadband Card */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x81bc,
+		USB_CLASS_COMM,
+		USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
+	  .driver_info = (unsigned long)&wwan_noarp_info,
+	},
+
 	/* Dell branded MBM devices like DW5550 */
 	{ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
 		| USB_DEVICE_ID_MATCH_VENDOR,
Signature · 6 lines
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#3 lore raw
In reply to a message not in the archive
Quoted 11 lines · Daniele Palmas

This patch series add support in the cdc_ncm driver for two devices based on the same platform, that are different only for carrier customization.

The devices do not have ARP capabilities.

Daniele Palmas (2):
net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband
Card
net: usb: cdc_ncm: Adding Dell DW5813 LTE AT&T Mobile Broadband
Card

Quite interesting; Google knows nothing about these devices that I can find. What platform are these based on?

But in any case, since these blocks are almost identical to the DW5550 block, maybe update the comments to indicate that they need NOARP unlike the MBM platform that the 5550 is based on?

Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 7 lines · Dan Williams
Quoted 6 lines · Daniele Palmas

This patch series add support in the cdc_ncm driver for two devices based on the same platform, that are different only for carrier customization.

The devices do not have ARP capabilities.

Quoted 8 lines
Quoted 5 lines

Daniele Palmas (2):
net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband
Card
net: usb: cdc_ncm: Adding Dell DW5813 LTE AT&T Mobile Broadband
Card

Quite interesting; Google knows nothing about these devices that I can find. What platform are these based on?

There are a number of launchpad bugs reported for these devices. Don't know why they chose that channel.. This one:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1520147
shows that it is an Intel/Infineon based design.

BTW, DeWalt seems to own these device names :)

Bjørn

A message that is not in the archive (sent off-list or not yet received): 87fuz15kqc.fsf-lbf33ChDnrE/[email protected]

#6 lore raw

Hi Bjorn,

2015-12-17 13:21 GMT+01:00 Bjørn Mork <[email protected]>:

Quoted 17 lines
Quoted 7 lines · Dan Williams
Quoted 6 lines · Daniele Palmas

This patch series add support in the cdc_ncm driver for two devices based on the same platform, that are different only for carrier customization.

The devices do not have ARP capabilities.

Quoted 8 lines
Quoted 5 lines

Daniele Palmas (2):
net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband
Card
net: usb: cdc_ncm: Adding Dell DW5813 LTE AT&T Mobile Broadband
Card

Quite interesting; Google knows nothing about these devices that I can find. What platform are these based on?

Quoted 7 lines

There are a number of launchpad bugs reported for these devices. Don't know why they chose that channel.. This one:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1520147
shows that it is an Intel/Infineon based design.

BTW, DeWalt seems to own these device names :)

patches were passed first to Canonical for custom OS image testing.

413c:81ba is the HSPA+ variant of the family: however this does not use ncm, but ecm, see
https://github.com/torvalds/linux/commit/0b88393cdf6b1322522849e61f7a3328f4fd3843

Quoted 2 lines

Bjørn

Thanks,
Daniele
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#7 lore raw
In reply to Dan Williams

Hi Dan,

2015-12-16 18:12 GMT+01:00 Dan Williams <[email protected]>:

Quoted 7 lines · Daniele Palmas
Quoted 6 lines

This patch series add support in the cdc_ncm driver for two devices based on the same platform, that are different only for carrier customization.

The devices do not have ARP capabilities.

Quoted 9 lines
Quoted 5 lines

Daniele Palmas (2):
net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband
Card
net: usb: cdc_ncm: Adding Dell DW5813 LTE AT&T Mobile Broadband
Card

Quite interesting; Google knows nothing about these devices that I can find. What platform are these based on?

those devices are still in the testing stage, so there is nothing about them in the web. They are Infineon based.

Quoted 3 lines

But in any case, since these blocks are almost identical to the DW5550 block, maybe update the comments to indicate that they need NOARP unlike the MBM platform that the 5550 is based on?

Sure, I can do a V2 patch for that.

Quoted 2 lines

Dan

Thanks,
Daniele

#8 lore raw

PATCH 1/2 net: usb: cdc_ncm: Adding Dell DW5812 LTE Verizon Mobile Broadband Card

In reply to Daniele Palmas

Dell DW5812 is a mobile broadband card with no ARP capabilities: the patch makes this device to use wwan_noarp_info struct

---
 drivers/net/usb/cdc_ncm.c | 7 +++++++
 1 file changed, 7 insertions(+)
drivers/net/usb/cdc_ncm.c +7 -0
index b45e5ca..2c0257a 100644
@@ -1593,6 +1593,13 @@ static const struct usb_device_id cdc_devs[] = {
 	  .driver_info = (unsigned long) &wwan_info,
 	},
 
+	/* DW5812 LTE Verizon Mobile Broadband Card */
+	{ USB_DEVICE_AND_INTERFACE_INFO(0x413c, 0x81bb,
+		USB_CLASS_COMM,
+		USB_CDC_SUBCLASS_NCM, USB_CDC_PROTO_NONE),
+	  .driver_info = (unsigned long)&wwan_noarp_info,
+	},
+
 	/* Dell branded MBM devices like DW5550 */
 	{ .match_flags = USB_DEVICE_ID_MATCH_INT_INFO
 		| USB_DEVICE_ID_MATCH_VENDOR,
Signature · 1 line
1.9.1