Skip to contentSkip to conversation

leds: bcm6358: remove unneeded busy status check

PATCH In review Álvaro Fernández Rojas 2 participants 2 messages Dec 16, 2015 – Dec 17, 2015 LED

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 leds: bcm6358: remove unneeded busy status check

The busy status checking isn't needed while reading initial LED status.

---
 drivers/leds/leds-bcm6358.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/leds/leds-bcm6358.c +0 -3
index 7413e3e..b2cc066 100644
@@ -123,9 +123,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg,
 			led->cdev.brightness = LED_FULL;
 		} else if (!strcmp(state, "keep")) {
 			unsigned long val;
-
-			bcm6358_led_busy(led->mem);
-
 			val = bcm6358_led_read(led->mem + BCM6358_REG_MODE);
 			val &= BIT(led->pin);
 			if ((led->active_low && !val) ||
Signature · 1 line
1.9.1
#1 lore raw

Hi Alvaro,

Thanks for the patch. Applied.

Quoted 22 lines · Álvaro Fernández Rojas

The busy status checking isn't needed while reading initial LED status.

---
  drivers/leds/leds-bcm6358.c | 3 ---
  1 file changed, 3 deletions(-)
drivers/leds/leds-bcm6358.c +0 -3
index 7413e3e..b2cc066 100644
@@ -123,9 +123,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg,
  			led->cdev.brightness = LED_FULL;
  		} else if (!strcmp(state, "keep")) {
  			unsigned long val;
-
-			bcm6358_led_busy(led->mem);
-
  			val = bcm6358_led_read(led->mem + BCM6358_REG_MODE);
  			val &= BIT(led->pin);
  			if ((led->active_low && !val) ||
Signature · 2 lines
Best Regards,
Jacek Anaszewski