drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c
Subsystems (3)
PATCH 1/1 drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c
In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial:
make serial/atmel_serial.c explicitly non-modular") we removed the code relating to modular support since it currently only supports built in.
However, when redoing my build coverage for mips allmodconfig, which sets CONFIG_OF, I noticed a remaining line that needs to be removed, else we will get a build failure for an undefined module macro.
Unfortunately this didn't appear for any of the other arch I tested more frequently, such as ARM.
Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just remove the offending line.
--- drivers/tty/serial/atmel_serial.c | 2 -- 1 file changed, 2 deletions(-)
drivers/tty/serial/atmel_serial.c +0 -2
@@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = { { .compatible = "atmel,at91sam9260-usart" }, {/* sentinel */ } }; - -MODULE_DEVICE_TABLE (of, atmel_serial_dt_ids);#endif static inline struct atmel_uart_port *
Signature · 1 line
2.6.1
Quoted 8 lines · Paul Gortmaker
In commit
c39dfebc7798956fd2140ae6321786ff35da30c3("drivers/tty/serial:
makeserial/atmel_serial.cexplicitly non-modular") we removed the code relating to modular support since it currently only supports built in.However, when redoing my build coverage for mips allmodconfig, which sets
CONFIG_OF, I noticed a remaining line that needs to be removed, else we will get a build failure for an undefined module macro.
Quoted 8 lines
Unfortunately this didn't appear for any of the other arch I tested more frequently, such as ARM.
Since
MODULE_DEVICE_TABLEis a no-op for non-modular code, we can just remove the offending line.Fixes c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")Cc Nicolas Ferre <[email protected]>
Absolutely:
Thank you Sudip and Paul.
Bye,
Quoted 24 lines
Cc Jiri Slaby <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Sudip Mukherjee <[email protected]>Reported-by Sudip Mukherjee <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>--- drivers/tty/serial/atmel_serial.c | 2 -- 1 file changed, 2 deletions(-)drivers/tty/serial/atmel_serial.c +0
-2@@ -188,8 +188,6 @@ static const struct of_device_id atmel_serial_dt_ids[] = { { .compatible = "atmel,at91sam9260-usart" }, {/* sentinel */ } }; - -MODULE_DEVICE_TABLE (of, atmel_serial_dt_ids);#endif static inline struct atmel_uart_port *
Signature · 1 line
Nicolas Ferre
Quoted 14 lines · Paul Gortmaker
In commit
c39dfebc7798956fd2140ae6321786ff35da30c3("drivers/tty/serial:
makeserial/atmel_serial.cexplicitly non-modular") we removed the code relating to modular support since it currently only supports built in.However, when redoing my build coverage for mips allmodconfig, which sets
CONFIG_OF, I noticed a remaining line that needs to be removed, else we will get a build failure for an undefined module macro.Unfortunately this didn't appear for any of the other arch I tested more frequently, such as ARM.
Since
MODULE_DEVICE_TABLEis a no-op for non-modular code, we can just remove the offending line.
Quoted 7 lines
Fixes c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")Cc Nicolas Ferre <[email protected]>Cc Jiri Slaby <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Sudip Mukherjee <[email protected]>Reported-by Sudip Mukherjee <[email protected]>
regards
sudip
Quoted 22 lines · Paul Gortmaker
In commit
c39dfebc7798956fd2140ae6321786ff35da30c3("drivers/tty/serial:
makeserial/atmel_serial.cexplicitly non-modular") we removed the code relating to modular support since it currently only supports built in.However, when redoing my build coverage for mips allmodconfig, which sets
CONFIG_OF, I noticed a remaining line that needs to be removed, else we will get a build failure for an undefined module macro.Unfortunately this didn't appear for any of the other arch I tested more frequently, such as ARM.
Since
MODULE_DEVICE_TABLEis a no-op for non-modular code, we can just remove the offending line.Fixes c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")Cc Nicolas Ferre <[email protected]>Cc Jiri Slaby <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Sudip Mukherjee <[email protected]>Reported-by Sudip Mukherjee <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>
Quoted 1 line
---
I think this has not yet landed in linux-next. next-20151231 still fails.
regards
sudip
Quoted 25 lines · [Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from…
Quoted 22 lines · Paul Gortmaker
In commit
c39dfebc7798956fd2140ae6321786ff35da30c3("drivers/tty/serial:
makeserial/atmel_serial.cexplicitly non-modular") we removed the code relating to modular support since it currently only supports built in.However, when redoing my build coverage for mips allmodconfig, which sets
CONFIG_OF, I noticed a remaining line that needs to be removed, else we will get a build failure for an undefined module macro.Unfortunately this didn't appear for any of the other arch I tested more frequently, such as ARM.
Since
MODULE_DEVICE_TABLEis a no-op for non-modular code, we can just remove the offending line.Fixes c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")Cc Nicolas Ferre <[email protected]>Cc Jiri Slaby <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Sudip Mukherjee <[email protected]>Reported-by Sudip Mukherjee <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>Quoted 1 line
---
Quoted 2 lines
I think this has not yet landed in linux-next. next-20151231 still fails.
Greg has a lot of irons in the fire, and it is also the season where a lot of people have unplugged for the last two weeks to be with family, friends, etc, so lets be patient.
Thanks,
Paul.
--
Quoted 3 lines
regards
sudip
Quoted 27 lines · Paul Gortmaker
Quoted 25 lines · [Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from…
Quoted 23 lines · Paul Gortmaker
In commit
c39dfebc7798956fd2140ae6321786ff35da30c3("drivers/tty/serial:
makeserial/atmel_serial.cexplicitly non-modular") we removed the code relating to modular support since it currently only supports built in.However, when redoing my build coverage for mips allmodconfig, which sets
CONFIG_OF, I noticed a remaining line that needs to be removed, else we will get a build failure for an undefined module macro.Unfortunately this didn't appear for any of the other arch I tested more frequently, such as ARM.
Since
MODULE_DEVICE_TABLEis a no-op for non-modular code, we can just remove the offending line.Fixes c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular")Cc Nicolas Ferre <[email protected]>Cc Jiri Slaby <[email protected]>Cc Greg Kroah-Hartman <[email protected]>Cc Sudip Mukherjee <[email protected]>Reported-by Sudip Mukherjee <[email protected]>Signed-off-by Paul Gortmaker <[email protected]>---
Quoted 6 lines
Quoted 2 lines
I think this has not yet landed in linux-next. next-20151231 still fails.
Greg has a lot of irons in the fire, and it is also the season where a lot of people have unplugged for the last two weeks to be with family, friends, etc, so lets be patient.
Ohhh .. sorry , i didn't notice it will go through Greg.
regards
sudip