dm-thin: Fix race condition when destroying thin pool
Subsystems (2)
PATCH 1/1 dm-thin: Fix race condition when destroying thin pool
When a thin pool is being destroyed delayed work items are canceled using cancel_delayed_work item, which doesn't guarantee that on return the delayed item wasn't running. This can cause the workitem to requeue itself on an already destroyed workqueue. Fix this by using cancel_delayed_work item which guarantees that on return the workitem is not running anymore.
Fixes 905e51b39a555 ("dm thin: commit outstanding data every second")
Fixes 85ad643b7e7e52 ("dm thin: add timeout to stop out-of-data-space
mode holding IO forever")
Signed-off-by Nikolay Borisov <[email protected]>
Cc <[email protected]>
--- drivers/md/dm-thin.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/md/dm-thin.c +2 -2
@@ -3453,8 +3453,8 @@ static void pool_postsuspend(struct dm_target *ti)struct pool_c *pt = ti->private;struct pool *pool = pt->pool; -cancel_delayed_work (&pool->waker); -cancel_delayed_work (&pool->no_space_timeout); +cancel_delayed_work_sync (&pool->waker); +cancel_delayed_work_sync (&pool->no_space_timeout);flush_workqueue (pool->wq); (void )commit (pool); }
Signature · 1 line
2.5.0