Skip to contentSkip to conversation

drm/i915: HWSTAM is not a thing on SKL+

PATCH In review Ben Widawsky 3 participants 4 messages Dec 18, 2015

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915: HWSTAM is not a thing on SKL+

Compile tested only.

---
 drivers/gpu/drm/i915/intel_lrc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lrc.c +2 -1
index 42a7be1..a9bc207 100644
@@ -1466,7 +1466,8 @@ static int gen8_init_common_ring(struct intel_engine_cs *ring)
 	u8 next_context_status_buffer_hw;
 
 	I915_WRITE_IMR(ring, ~(ring->irq_enable_mask | ring->irq_keep_mask));
-	I915_WRITE(RING_HWSTAM(ring->mmio_base), 0xffffffff);
+	if (INTEL_INFO(ring->dev)->gen == 8)
+		I915_WRITE(RING_HWSTAM(ring->mmio_base), 0xffffffff);
 
 	if (ring->status_page.obj) {
 		I915_WRITE(RING_HWS_PGA(ring->mmio_base),
Signature · 6 lines
2.6.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 12 lines · Ben Widawsky

Compile tested only.

---
 drivers/gpu/drm/i915/intel_lrc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lrc.c +0 -0
index 42a7be1..a9bc207 100644

drivers/gpu/drm/i915/intel_lrc.c static int gen8_init_common_ring(struct intel_engine_cs *ring) · line 1471

Quoted 7 lines
drivers/gpu/drm/i915/intel_lrc.c +2 -1
@@ -1466,7 +1466,8 @@ static int gen8_init_common_ring(struct intel_engine_cs *ring)
 	u8 next_context_status_buffer_hw;
 
 	I915_WRITE_IMR(ring, ~(ring->irq_enable_mask | ring->irq_keep_mask));
-	I915_WRITE(RING_HWSTAM(ring->mmio_base), 0xffffffff);
+	if (INTEL_INFO(ring->dev)->gen == 8)
+		I915_WRITE(RING_HWSTAM(ring->mmio_base), 0xffffffff);
 

It seems that this has only been removed from render, other engines still has it on skl.

-Mika

Quoted 9 lines
drivers/gpu/drm/i915/intel_lrc.c +0 -0
 	if (ring->status_page.obj) {
 		I915_WRITE(RING_HWS_PGA(ring->mmio_base),
Signature · 6 lines
2.6.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw
Quoted 25 lines · Mika Kuoppala
Quoted 12 lines · Ben Widawsky

Compile tested only.

---
 drivers/gpu/drm/i915/intel_lrc.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_lrc.c +0 -0
index 42a7be1..a9bc207 100644

drivers/gpu/drm/i915/intel_lrc.c static int gen8_init_common_ring(struct intel_engine_cs *ring) · line 1471

Quoted 7 lines
drivers/gpu/drm/i915/intel_lrc.c +2 -1
@@ -1466,7 +1466,8 @@ static int gen8_init_common_ring(struct intel_engine_cs *ring)
 	u8 next_context_status_buffer_hw;
 
 	I915_WRITE_IMR(ring, ~(ring->irq_enable_mask | ring->irq_keep_mask));
-	I915_WRITE(RING_HWSTAM(ring->mmio_base), 0xffffffff);
+	if (INTEL_INFO(ring->dev)->gen == 8)
+		I915_WRITE(RING_HWSTAM(ring->mmio_base), 0xffffffff);
 

It seems that this has only been removed from render, other engines still has it on skl.

Quoted 2 lines

-Mika

Hmm. What I am looking at says EXCLUDE(SKL+) for BCS and VCS. Then for VECS it says HSW, BDW, CHV. So I guess we're not looking at the same thing :(

Quoted 9 lines
Quoted 9 lines
drivers/gpu/drm/i915/intel_lrc.c +0 -0
 	if (ring->status_page.obj) {
 		I915_WRITE(RING_HWS_PGA(ring->mmio_base),
Signature · 6 lines
2.6.4

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 5 lines
Ben Widawsky, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw

✗ failure: Fi.CI.BAT

In reply to Ben Widawsky
== Summary ==

== Summary ==

HEAD is now at ac2305b drm-intel-nightly: 2015y-12m-17d-16h-19m-23s UTC integration manifest
Applying: drm/i915: HWSTAM is not a thing on SKL+
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 drm/i915: HWSTAM is not a thing on SKL+

_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx