Skip to contentSkip to conversation

openjdk: fix host-user-contaminated QA issue

PATCH Superseded [email protected] 2 participants 4 messages Dec 18, 2015 – Jan 15, 2016

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 openjdk: fix host-user-contaminated QA issue

From: Jackie Huang <[email protected]>

Fixed:
WARNING: QA Issue: openjdk-8:
/openjdk-8-doc/usr/lib/jvm/openjdk-8/jre/THIRD_PARTY_README is owned by uid 1786, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]

The use of cp results in files in the recipe being owned by the user running bitbake, so fix the owner to root:root

---
 recipes-core/openjdk/openjdk-8_72b05.bb | 1 +
 1 file changed, 1 insertion(+)
recipes-core/openjdk/openjdk-8_72b05.bb +1 -0
index 96473f5..d962b1f 100644
@@ -20,6 +20,7 @@ do_install() {
     rm -rf ${D}${JDK_HOME}
         mkdir -p ${D}${JDK_HOME}
     cp -rp ${B}/images/j2sdk-image/* ${D}${JDK_HOME}
+    chown -R root:root ${D}${JDK_HOME}
     install -m644 ${WORKDIR}/jvm.cfg  ${D}${JDK_HOME}/jre/lib/${JDK_ARCH}/
     find ${D}${JDK_HOME} -name "*.debuginfo" -print0 | xargs -0 rm
 }
Signature · 1 line
2.3.5
#1 lore raw

PATCH 2/2 openjdk-8: skip the dev-so test

From: Jackie Huang <[email protected]>

Fixed:
ERROR: QA Issue: non -dev/-dbg/nativesdk- package contains symlink .so:
openjdk-8 path 'work/core2-64-poky-linux/openjdk-8/72b05-r0/packages-split/openjdk-8/usr/lib/jvm/openjdk-8/jre/lib/amd64/server/libjsig.so' [dev-so]

The symlink .so is valid so we just skip the test
just like what we does in openjdk-7.

---
 recipes-core/openjdk/openjdk-8_72b05.bb | 3 +++
 1 file changed, 3 insertions(+)
recipes-core/openjdk/openjdk-8_72b05.bb +3 -0
index d962b1f..8aa9f9f 100644
@@ -92,6 +92,9 @@ PROVIDES_${PN} = "java2-vm"
 RPROVIDES_${PN} = "java2-runtime"
 PROVIDES_${PN} = "java2-runtime"
 
+# There is a symlink to a .so but this one is valid.
+INSANE_SKIP_${PN} = "dev-so"
+
 inherit update-alternatives
 
 ALTERNATIVE_PRIORITY = "100"
Signature · 1 line
2.3.5
#2 lore raw

Re: [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test

Please ignore this since openjre-8 also has same issue, I will re-patch in a .inc. But a question I have is, why do we needs a different packaging strategy for openjdk-8 and there are two recipes: on for openjdk-8 and another for openjre-8? Openjdk-7 is using one recipe to provide openjdk-7-jdk and opendk-7-jre.

Thanks,
Jackie

Quoted 46 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of [email protected]
Sent: Friday, December 18, 2015 3:32 PM
To: [email protected]
Subject: [oe] [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test

From: Jackie Huang <[email protected]>

Fixed:
ERROR: QA Issue: non -dev/-dbg/nativesdk- package contains symlink .so:
openjdk-8 path 'work/core2-64-poky-linux/openjdk-8/72b05-r0/packages-split/openjdk-8/usr/lib/jvm/openjdk- 8/jre/lib/amd64/server/libjsig.so'
[dev-so]

The symlink .so is valid so we just skip the test
just like what we does in openjdk-7.

---
 recipes-core/openjdk/openjdk-8_72b05.bb | 3 +++
 1 file changed, 3 insertions(+)
recipes-core/openjdk/openjdk-8_72b05.bb +3 -1
index d962b1f..8aa9f9f 100644
@@ -92,6 +92,9 @@ PROVIDES_${PN} = "java2-vm"
 RPROVIDES_${PN} = "java2-runtime"
 PROVIDES_${PN} = "java2-runtime"
 
+# There is a symlink to a .so but this one is valid.
+INSANE_SKIP_${PN} = "dev-so"
+
 inherit update-alternatives
 
 ALTERNATIVE_PRIORITY = "100"
--

2.3.5

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#3 lore raw

Re: [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test

Quoted 8 lines

Am 22.12.2015 um 08:33 schrieb Huang, Jie (Jackie) <[email protected]>:

Please ignore this since openjre-8 also has same issue, I will re-patch in a .inc. But a question I have is, why do we needs a different packaging strategy for openjdk-8 and there are two recipes: on for openjdk-8 and another for openjre-8? Openjdk-7 is using one recipe to provide openjdk-7-jdk and opendk-7-jre.

That's easy to answer - openjdk-7-jre installs a part from an j2dk build, which includes more that just the jre. Since size matters on some embedded platforms, I decided to Do the right thing (tm) for Java8.

Quoted 44 lines

Thanks,
Jackie

Quoted 41 lines

-----Original Message-----
From: [email protected] [mailto:openembedded-devel- [email protected]] On Behalf Of [email protected]
Sent: Friday, December 18, 2015 3:32 PM
To: [email protected]
Subject: [oe] [meta-java][PATCH 2/2] openjdk-8: skip the dev-so test

From: Jackie Huang <[email protected]>

Fixed:
ERROR: QA Issue: non -dev/-dbg/nativesdk- package contains symlink .so:
openjdk-8 path 'work/core2-64-poky-linux/openjdk-8/72b05-r0/packages-split/openjdk-8/usr/lib/jvm/openjdk- 8/jre/lib/amd64/server/libjsig.so'
[dev-so]

The symlink .so is valid so we just skip the test
just like what we does in openjdk-7.

---
recipes-core/openjdk/openjdk-8_72b05.bb | 3 +++

1 file changed, 3 insertions(+)
recipes-core/openjdk/openjdk-8_72b05.bb +0 -0
index d962b1f..8aa9f9f 100644
@@ -92,6 +92,9 @@ PROVIDES_${PN} = "java2-vm"

RPROVIDES_${PN} = "java2-runtime"
PROVIDES_${PN} = "java2-runtime"

recipes-core/openjdk/openjdk-8_72b05.bb +3 -0
+# There is a symlink to a .so but this one is valid.
+INSANE_SKIP_${PN} = "dev-so"
+

inherit update-alternatives

ALTERNATIVE_PRIORITY = "100"
--
2.3.5

Quoted 10 lines
Quoted 5 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Jens Rehsack - [email protected]