Skip to contentSkip to conversation

hw/ppc/spapr_rtc: Remove bad class_size value

PATCH In review Thomas Huth 2 participants 2 messages Dec 18, 2015 – Dec 21, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hw/ppc/spapr_rtc: Remove bad class_size value

class_size = sizeof(XICSStateClass) does not make much sense in the RTC code and likely was just a copy-n-paste error. Let's simply remove it.

---
 hw/ppc/spapr_rtc.c | 1 -
 1 file changed, 1 deletion(-)
hw/ppc/spapr_rtc.c +0 -1
index 34b27db..b591a8e 100644
@@ -200,7 +200,6 @@ static const TypeInfo spapr_rtc_info = {
     .name          = TYPE_SPAPR_RTC,
     .parent        = TYPE_SYS_BUS_DEVICE,
     .instance_size = sizeof(sPAPRRTCState),
-    .class_size = sizeof(XICSStateClass),
     .class_init    = spapr_rtc_class_init,
 };
 
Signature · 1 line
1.8.3.1
#1 lore raw
Quoted 5 lines · Thomas Huth

class_size = sizeof(XICSStateClass) does not make much sense in the RTC code and likely was just a copy-n-paste error. Let's simply remove it.

Oops, that's an embarrasing error. Fix applied to ppc-for-2.5 and ppc-for-2.6

Quoted 16 lines
---
 hw/ppc/spapr_rtc.c | 1 -
 1 file changed, 1 deletion(-)
hw/ppc/spapr_rtc.c +0 -1
index 34b27db..b591a8e 100644
@@ -200,7 +200,6 @@ static const TypeInfo spapr_rtc_info = {
     .name          = TYPE_SPAPR_RTC,
     .parent        = TYPE_SYS_BUS_DEVICE,
     .instance_size = sizeof(sPAPRRTCState),
-    .class_size = sizeof(XICSStateClass),
     .class_init    = spapr_rtc_class_init,
 };
 
Signature · 4 lines
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson