Skip to contentSkip to conversation

staging: coding style cleanups for staging/panel driver

PATCH In review Bijosh T 4 participants 5 messages Dec 18, 2015 – Dec 19, 2015 Staging

lore
Share & tools
lore

Bijosh T

author
#0 lore raw

PATCH 1/1 staging: coding style cleanups for staging/panel driver

From: Bijosh T <[email protected]>

This patch fixes coding style errors for staging/panel driver.

---
 drivers/staging/panel/panel.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/staging/panel/panel.c +4 -3
index 79ac192..04d86f3 100644
@@ -947,7 +947,8 @@ static void lcd_clear_fast_s(void)
 		lcd_send_serial(0x5F);	/* R/W=W, RS=1 */
 		lcd_send_serial(' ' & 0x0F);
 		lcd_send_serial((' ' >> 4) & 0x0F);
-		usleep_range(40, 100);	/* the shortest data takes at least 40 us */
+		/* the shortest data takes at least 40 us */
+		usleep_range(40, 100);
 	}
 	spin_unlock_irq(&pprt_lock);
 
@@ -1788,7 +1789,7 @@ static void phys_scan_contacts(void)
 	gndmask = PNL_PINPUT(r_str(pprt)) & scan_mask_i;
 
 	/* grounded inputs are signals 40-44 */
-	phys_read |= (pmask_t) gndmask << 40;
+	phys_read |= (pmask_t)gndmask << 40;
 
 	if (bitmask != gndmask) {
 		/*
@@ -1804,7 +1805,7 @@ static void phys_scan_contacts(void)
 
 			w_dtr(pprt, oldval & ~bitval);	/* enable this output */
 			bitmask = PNL_PINPUT(r_str(pprt)) & ~gndmask;
-			phys_read |= (pmask_t) bitmask << (5 * bit);
+			phys_read |= (pmask_t)bitmask << (5 * bit);
 		}
 		w_dtr(pprt, oldval);	/* disable all outputs */
 	}
Signature · 1 line
2.5.0
#3 lore raw
Quoted 11 lines · Greg KH
Quoted 5 lines · Bijosh T

From: Bijosh T <[email protected]>

This patch fixes coding style errors for staging/panel driver.

I need a "full" name here, not just "T" as a last name, as odds are it's a bit longer than just that one character...

Please fix up and resend.

While you are resending please also mention which coding style error you have fixed.

regards
sudip

#4 lore raw
Quoted 8 lines · Sudip Mukherjee
Quoted 7 lines · Greg KH
Quoted 5 lines · Bijosh T

From: Bijosh T <[email protected]>

This patch fixes coding style errors for staging/panel driver.

Quoted 7 lines
Quoted 4 lines

I need a "full" name here, not just "T" as a last name, as odds are it's a bit longer than just that one character...

Please fix up and resend.

While you are resending please also mention which coding style error you have fixed.

Well, they are so minor (mostly spaces) that anyone interested should read the patch.

Willy