Skip to contentSkip to conversation

mpg123: add textrel to INSANE_SKIP

PATCH New Andre McCurdy 1 participant 1 message Dec 19, 2015

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpg123: add textrel to INSANE_SKIP

The x86 assembler optimisations contains text relocations and there are no upstream plans to fix them:

http://sourceforge.net/p/mpg123/bugs/168/

Benchmarking suggests that the SSE assembler is still clearly faster than the generic C code, so leave the assembler optimisations enabled.

---
 meta-multimedia/recipes-multimedia/mpg123/mpg123_1.22.4.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta-multimedia/recipes-multimedia/mpg123/mpg123_1.22.4.bb +4 -0
index 22ea572..d11a312 100644
@@ -51,6 +51,10 @@ EXTRA_OECONF = " \
     ${@bb.utils.contains('TUNE_FEATURES', 'altivec', '--with-cpu=altivec', '', d)} \
 "
 
+# The x86 assembler optimisations contains text relocations and there are no
+# upstream plans to fix them: http://sourceforge.net/p/mpg123/bugs/168/
+INSANE_SKIP_${PN}_append_x86 = " textrel"
+
 # Fails to build with thumb-1 (qemuarm)
 #| {standard input}: Assembler messages:
 #| {standard input}:47: Error: selected processor does not support Thumb mode `smull r5,r6,r7,r4'
Signature · 1 line
1.9.1