Skip to contentSkip to conversation

directfb.inc: enable bfd linker workaround for all arm targets

PATCH In review Andre McCurdy 2 participants 3 messages Dec 22, 2015 – Jan 14, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 directfb.inc: enable bfd linker workaround for all arm targets

Although the gold linker problems with DirectFB have only so far been observed with armv7a, they could potentially affect future arm targets too. Since there's no particular downside to using the bfd linker for DirectFB, apply the workaround to all arm targets.

---
 meta/recipes-graphics/directfb/directfb.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/directfb/directfb.inc +1 -1
index b905ab0..603aba3 100644
@@ -23,7 +23,7 @@ S = "${WORKDIR}/DirectFB-${PV}"
 LDFLAGS_append =" -lts -lm"
 
 # Workaround for linking issues seen with armv7a + gold
-LDFLAGS_append_armv7a = "${@base_contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
+LDFLAGS_append_arm = "${@base_contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
 
 BINCONFIG = "${bindir}/directfb-config"
 
Signature · 1 line
1.9.1
#1 lore raw

Andre

I have a fix for this issue in binutils

can you try it out if it works for you ?

https://github.com/kraj/openembedded-core/commit/0e35ad5a35262cfb7a6249ce158f76d1399d6cb4

Quoted 33 lines · Andre McCurdy

Although the gold linker problems with DirectFB have only so far been observed with armv7a, they could potentially affect future arm targets too. Since there's no particular downside to using the bfd linker for DirectFB, apply the workaround to all arm targets.

---
meta/recipes-graphics/directfb/directfb.inc | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/directfb/directfb.inc +0 -0
index b905ab0..603aba3 100644
@@ -23,7 +23,7 @@ S = "${WORKDIR}/DirectFB-${PV}"

LDFLAGS_append =" -lts -lm"

# Workaround for linking issues seen with armv7a + gold

meta/recipes-graphics/directfb/directfb.inc +1 -1
-LDFLAGS_append_armv7a = "${@base_contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
+LDFLAGS_append_arm = "${@base_contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"

BINCONFIG = "${bindir}/directfb-config"

--
1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#2 lore raw

Hi Khem,

Quoted 7 lines · Khem Raj

Andre

I have a fix for this issue in binutils

can you try it out if it works for you ?

https://github.com/kraj/openembedded-core/commit/0e35ad5a35262cfb7a6249ce158f76d1399d6cb4

I cherry picked 5803c581 from your master branch.

It does indeed seem to fix the errors previously seen with the gold linker.

Quoted 34 lines
Quoted 33 lines · Andre McCurdy

Although the gold linker problems with DirectFB have only so far been observed with armv7a, they could potentially affect future arm targets too. Since there's no particular downside to using the bfd linker for DirectFB, apply the workaround to all arm targets.

---
meta/recipes-graphics/directfb/directfb.inc | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/directfb/directfb.inc +0 -0
index b905ab0..603aba3 100644
@@ -23,7 +23,7 @@ S = "${WORKDIR}/DirectFB-${PV}"

LDFLAGS_append =" -lts -lm"

# Workaround for linking issues seen with armv7a + gold

meta/recipes-graphics/directfb/directfb.inc +1 -1
-LDFLAGS_append_armv7a = "${@base_contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
+LDFLAGS_append_arm = "${@base_contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"

BINCONFIG = "${bindir}/directfb-config"

--
1.9.1

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core